From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Christian Brauner <brauner@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Dan Carpenter <dan.carpenter@linaro.org>,
David Airlie <airlied@gmail.com>,
David Hildenbrand <david@redhat.com>, Hao Ge <gehao@kylinos.cn>,
Jani Nikula <jani.nikula@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Josef Bacik <josef@toxicpanda.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Miklos Szeredi <miklos@szeredi.hu>, Nhat Pham <nphamcs@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Ran Xiaokai <ran.xiaokai@zte.com.cn>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Simona Vetter <simona@ffwll.ch>,
Steven Rostedt <rostedt@goodmis.org>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Vlastimil Babka <vbabka@suse.cz>,
Yosry Ahmed <yosryahmed@google.com>, Yu Zhao <yuzhao@google.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCHv3 03/11] drm/i915/gem: Use PG_dropbehind instead of PG_reclaim
Date: Fri, 31 Jan 2025 14:38:42 +0100 [thread overview]
Message-ID: <Z5zSYtcGGp73Ip2c@ashyti-mobl2.lan> (raw)
In-Reply-To: <20250130100050.1868208-4-kirill.shutemov@linux.intel.com>
Hi Kirill,
On Thu, Jan 30, 2025 at 12:00:41PM +0200, Kirill A. Shutemov wrote:
> The recently introduced PG_dropbehind allows for freeing folios
> immediately after writeback. Unlike PG_reclaim, it does not need vmscan
> to be involved to get the folio freed.
>
> Instead of using folio_set_reclaim(), use folio_set_dropbehind() in
> __shmem_writeback()
>
> It is safe to leave PG_dropbehind on the folio if, for some reason
> (bug?), the folio is not in a writeback state after ->writepage().
> In these cases, the kernel had to clear PG_reclaim as it shared a page
> flag bit with PG_readahead.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
next prev parent reply other threads:[~2025-01-31 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250130100050.1868208-1-kirill.shutemov@linux.intel.com>
[not found] ` <20250130100050.1868208-5-kirill.shutemov@linux.intel.com>
2025-01-30 17:39 ` [PATCHv3 04/11] mm/zswap: " Nhat Pham
[not found] ` <20250130100050.1868208-6-kirill.shutemov@linux.intel.com>
2025-01-30 20:34 ` [PATCHv3 05/11] mm/truncate: Use folio_set_dropbehind() instead of deactivate_file_folio() Yu Zhao
[not found] ` <20250130100050.1868208-2-kirill.shutemov@linux.intel.com>
2025-01-30 20:36 ` [PATCHv3 01/11] mm/migrate: Transfer PG_dropbehind to the new folio Yu Zhao
[not found] ` <20250130100050.1868208-12-kirill.shutemov@linux.intel.com>
2025-01-30 20:38 ` [PATCHv3 11/11] mm: Rename PG_dropbehind to PG_reclaim Yu Zhao
[not found] ` <20250130100050.1868208-4-kirill.shutemov@linux.intel.com>
2025-01-31 13:38 ` Andi Shyti [this message]
[not found] ` <20250130100050.1868208-3-kirill.shutemov@linux.intel.com>
2025-01-31 13:37 ` [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios Andi Shyti
2025-01-31 14:21 ` Matthew Wilcox
2025-01-31 20:27 ` Shakeel Butt
[not found] ` <20250130100050.1868208-7-kirill.shutemov@linux.intel.com>
2025-01-31 21:32 ` [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG_reclaim Shakeel Butt
2025-02-01 8:01 ` Kairui Song
2025-02-03 7:14 ` Yu Zhao
2025-02-03 8:39 ` Kirill A. Shutemov
2025-02-04 0:47 ` Andrew Morton
2025-02-06 6:34 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5zSYtcGGp73Ip2c@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=Jason@zx2c4.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.carpenter@linaro.org \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gehao@kylinos.cn \
--cc=hannes@cmpxchg.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=josef@toxicpanda.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=miklos@szeredi.hu \
--cc=nphamcs@gmail.com \
--cc=osalvador@suse.de \
--cc=ran.xiaokai@zte.com.cn \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox