From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA5BAC0218A for ; Thu, 30 Jan 2025 14:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646842802A1; Thu, 30 Jan 2025 09:22:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F6C128029C; Thu, 30 Jan 2025 09:22:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BEEF2802A1; Thu, 30 Jan 2025 09:22:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 31AFF28029C for ; Thu, 30 Jan 2025 09:22:57 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D7EB7C0F08 for ; Thu, 30 Jan 2025 14:22:56 +0000 (UTC) X-FDA: 83064334752.22.E4D2543 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 3146818000D for ; Thu, 30 Jan 2025 14:22:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XmC540MW; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738246975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zBPwFHdewPI4agr5Oh0ubR+XXLYYmNdQxuFDAt/itGs=; b=XecjarvWzWl0hxguy/Zuh/gQPkCCtPyaWJfBDAcTEK0tjCv0aMTX5B0sydbtUHoIh57PNT f3UqIJ7G5DX4r/EUN5M20X7WGHM2mFUf/WRYqzDj6XNIJnpEWKFrJaaV+hee5QIPkE0iRt 4YvxRDgOIscs7AGGXQ6qcouXnmoUxok= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XmC540MW; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738246975; a=rsa-sha256; cv=none; b=T9zmiDHqyDx5sRMSiUxhE50KlYQpmuMzD3GrSRuRdRnG6KIJ68LyhTp4JsHkwWcRnFHj8z 0GVig8BmtlMjRBecR7KrY0WnkrcDROZaUaRQy3q4NiHqHjMgdHom+h2WMXzqZxKcb7IobQ hTFtXSMDG0PW4UvsiSjdpLD/U0G4TzQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zBPwFHdewPI4agr5Oh0ubR+XXLYYmNdQxuFDAt/itGs=; b=XmC540MWIRUY45L1ZCKLWbQEFZ bFzbA57v/pSPALqI/QMDIzNsLcNmdbaK1Pw7benRStsfZ+yD89AllrhvD/9SSvYZLKwc/HEZap7H5 Tmo/lLD6pflRJt8WceDAkoaBVdmiYQD+nyRDSzgntYutmfwHb1IDYBwlkL37uXMzFS1lzpeeed0/F 8aZdMxv6lowImW7mKCVtHuMrQtgvtL8SrMOToNw+4KsytgZA6Unq1YwUnRDciVNwTa9y8RdYAINco DUkHdD5f2u4J/1SyNI31E1jbCNH49TJczCyNKDwfzveGbfDpHYm79SEfAtWr90iEO+L7Vq2kTwh2O aFiEUMsg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tdVRI-0000000DRjY-17hY; Thu, 30 Jan 2025 14:22:40 +0000 Date: Thu, 30 Jan 2025 14:22:40 +0000 From: Matthew Wilcox To: Geert Uytterhoeven Cc: "Liam R. Howlett" , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH] xarray: port tests to kunit Message-ID: References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3146818000D X-Stat-Signature: qg4cthhoknwhrq3mgtu5aa75yzyfstgp X-Rspam-User: X-HE-Tag: 1738246972-670989 X-HE-Meta: U2FsdGVkX1+ynWxm8UpSNpUdqTd/fJBFV5jFPlQ14WtsNMh2XNTGnsNqVHVFRaA+OKwq502dWAbc9yTXVs2BTTYZh/nLp72hvkmQP9ZuHkTX8Wf4BMSqNFCxHYN4mvJjaIX8NayDDBQxnQtqtDRDTaI/aZzmHhrZu3MrIv2ea3euWYIjZac1ytPbQHizysHuaV9L2eYLbPU4nexVqk2GRTgefQn3u3ruTNkd8DF/LMIliKy0/mfFZDKJkk4OYNz1b/PJ06z6eZuQH3Nv/bFtt2MXi5hS5xMFKoAWIbiQatXzIB7QK116GjLpC1aWHr7Z2rcw+QRPdsq5viCdwTeHS+83X31Q1hoSes545j7ceN39RrfkIKTq7PtCU/CKacDc68vGFGNNrMBDivjeQt61zdhctsj2dxXSbmsRH349A8WIA6BoNmkkuXZmpzgS0SXlckP6T5GaspDjjLkR1Zy/MnmplSxWAqZG45r47B7IsUo9+Im/NCc9NoXvd/3ub7hzEWE4xaXJkxdlvZfQg31l/l9RavmwhC0zan06ut4NqJkJYSDWUpTPpebjZjjXqSKVq0okwULWc2c+skM2KDL2fqE9wrigVt13BZ4a9U+sjKqNWNpC3/jptl5o4oHs9CRj5xBsL+nCmFqpmnDWc+eqQLeJzRNGQx1oKX2fvUWuLdmx18n0JyKE/i07EbULI4qpfeaCdGKRnCsxAHT5x4l6dHltWfcyDHBxlyelJeFmc2Mj8Eqc/fZ0r54Ljt6Adre6fjfLrS40wWa14pJUyKkD9lAZ0zSFppFX7eE4NtTrMYbgvItqf5c4r3TmBdAdGAC980ezAD2hpYSk1wsAZ75n1ZShx+9vH3oXL+rn4MqoYTNzm5O0PSClb8scA+/xv3aJZ12mQ48cAR+Sh7lnUsO/WPIXpSKXQDIuYBZyGUOnAsvzelHyw/RxhO/jobBs0fRWFHTyOrHcIXLw1krjEV4 X4WqFAqD Ci8esRk96WfafiNoPrDgOatxuF1A8D7KzIxAC+DLEvLpjnZ/vUGdck6Y23DugoVOn2YU1wcXGz/coXKPqlPxXOMZhHjdwdHKU95w/8UjYtjhCzbBLvT96WlyNr+dsxVaf0kxMWyIPZIOsS1ddU2u+tzezqT/pmSRO2jPxS8OxCffhQ3xpEo1o3RLcurwHMYDYLoorf24u4oZM1f+ynObD5wFR7CKn2k+WmB6MAR/MoylzA/e3BJ48/gFo2bNeGUuRnWRtFhS/MBIjcfseouLNXyQjQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 09:21:12AM +0100, Geert Uytterhoeven wrote: > The long and obscure command line is a red herring: a simple > "modprobe test_xarray" is all it takes... That's all I've ever done. I'm confused/annoyed by all this "let's wrap everything up in some complex and obscure new thing" practice. > > You should look at the userspace testing (that this broke) as it has > > been really useful in certain scenarios. > > BTW, how do I even build tools/testing/radix-tree? > "make tools/help" doesn't show the radix-tree test. > "make tools/all" doesn't seem to try to build it. > Same for "make kselftest-all". I've never heard of any of those things. So I didn't try to make any of them work. > When trying the above, and ignoring failures due to missing packages > on my host: > - there are several weird build errors, > - this doesn't play well with O=, > - lots of scary warnings when building for 32-bit, > - ... Really? Turns out I haven't built for 32-bit on this laptop, so I'm installing all the packages I need now. I seem to reemember it being painful due to liburcu packaging not allowing me to install both a 32-bit and 64-bit package at the same time. > At least the kunit tests build (and run[1] ;-) most of the time... That's unworthy. kunit isn't trying to do anything nearly as hard as the radix tree tests are. > [1] test_xarray started failing on m68k recently > https://lore.kernel.org/all/CAMuHMdU_bfadUO=0OZ=AoQ9EAmQPA4wsLCBqohXR+QCeCKRn4A@mail.gmail.com/ I really wish Andrew would stop merging xarray patches.