From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E262C0218F for ; Thu, 30 Jan 2025 13:29:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B1CB280297; Thu, 30 Jan 2025 08:29:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 761D6280293; Thu, 30 Jan 2025 08:29:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB15280297; Thu, 30 Jan 2025 08:29:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 408CE280293 for ; Thu, 30 Jan 2025 08:29:28 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E772F120835 for ; Thu, 30 Jan 2025 13:29:27 +0000 (UTC) X-FDA: 83064199974.15.4EC400B Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf03.hostedemail.com (Postfix) with ESMTP id EEDBB20004 for ; Thu, 30 Jan 2025 13:29:25 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=g8eDjm8j; dmarc=none; spf=none (imf03.hostedemail.com: domain of simona.vetter@ffwll.ch has no SPF policy when checking 209.85.128.46) smtp.mailfrom=simona.vetter@ffwll.ch ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738243766; a=rsa-sha256; cv=none; b=C+lZD+ljgIhrWyiX5IVTcvtF9tNkSLwvvWYR5p1VZTS37qapZ7Go0yzaChJCJtUi4zqDAw W5yWm42Y7EiMFfycMaDjIEHv3FkT3xkeWV9NeNbveap+sXJl8wD7NqCVylj1J0KmYvFvYN wNinH2JKcymEtivEkh3kR6s7Sp3lA9M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ffwll.ch header.s=google header.b=g8eDjm8j; dmarc=none; spf=none (imf03.hostedemail.com: domain of simona.vetter@ffwll.ch has no SPF policy when checking 209.85.128.46) smtp.mailfrom=simona.vetter@ffwll.ch ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738243766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6CwN17MyPFKvtC6C01wmuj8jHUuL8qlluAzeR7k1VHs=; b=XVEHIWdrdPkU8FkiLhamShxFm3WkTU8unYL2kOpVvAS6urU/nB65T0FTi/KcWbrcqYBwUL G8EcnpATEzsHmodW0uxoCDZMtiFlXqRJcPYz16P80CGWmdPRCyoCODPMhgYFdGUaayFzja Nm9VBjHycnEC11wuxLENT6MzhkNtumc= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4368a293339so9120915e9.3 for ; Thu, 30 Jan 2025 05:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1738243764; x=1738848564; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=6CwN17MyPFKvtC6C01wmuj8jHUuL8qlluAzeR7k1VHs=; b=g8eDjm8jaIbavdwk27B78ooq5l5dxQOz+nzGH2GdwBiYvobc3DXJVOaxFxgxTgBJWo L2ID82lOMFlL2+WLGXrr62UadaLWYnJL59emc7zdEj3TrS7oEHD2tuyJI9VKVz6gyddc yIXT7Dly+bsopR/JykIuyDCiuI/Nje/lJXPsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738243764; x=1738848564; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6CwN17MyPFKvtC6C01wmuj8jHUuL8qlluAzeR7k1VHs=; b=dUE2rVuCIc7I4j9m/NUq3yfJeuE3Vvn3SYwJldjfRJ1WXnRdO1KO8XAPZBXlc0z8Su sTxqk4K6SyPoxZG2CfHumH6Ng+21K14GkWKi/kKMPPpPWFtBvg03QV14j/vIYAlBh7Sh 1VW++Xw2XASGpxxJepjaGy+4Sb7X38XaG4rn+utvdQ5u56HkCtQNuccbYSpEivBmffLB FMosc0H3Gt6d9ILodMP32Ja1vsyKaMsPc5eH/nCeOvtgG04EBENJK7pP2Mi2Q1AU6Qib Gv141N7AUrhSEC34+Ysk/TBwJkEncfkzUi+QxtrSBFyEcVAEQdeC9kNqUF4HMlS2m40V FjcQ== X-Forwarded-Encrypted: i=1; AJvYcCUaxndcwqfwc9XgR5RlF5MBH40/UHSwPZ2pPcN3uInYLx9YWbQwfmHKKhP2z6fz5bPrwzl6hNun8A==@kvack.org X-Gm-Message-State: AOJu0YxEjwyYP2Gvst+zux5rEIWlbRLqasLOzGrNr4KReC8vi8BuQohS ps4gp5jGI/FVwp3ze/AsKuwCoBQ+w8geJWX7QmwfhKAOUPYDI/av4vZ3IX1by98= X-Gm-Gg: ASbGnctFCrKccRkybIis39z6+sTLClb5FMVWtht7HpqEXYy6VxrVOxcll4Bv9x4MS7u 898GC/mQWOycJ/7vUtkn5qeC94Ba4Lga2rw4bvs1D+dDC8upIM5ZA7IGqTk1ZRVohbmWU6p35H6 u4gGs+PL758M/0pMfDRM5E3QFsIMgPixmugyuP4wfh6avPcOG292s3KzbHg+FAPldF2jDAOnaCr aGc2WvuMRMYgvimzTRQO01uAcZHTGdsEEb26KYDoeyQTuZinEpN6kM5BsRwOvEk6AS5IhNg3YAn qRJWk3Ys/JsNullvnYBcJAVQzO8= X-Google-Smtp-Source: AGHT+IHdrFYxzPnGyvPL9diVxB5aO5ood/KWzCJUp9hx1GIy5lqLPzKFdL5gi+Wc6C+yM8JgD/EQ9Q== X-Received: by 2002:a05:6000:2ce:b0:38c:3eab:2e13 with SMTP id ffacd0b85a97d-38c52093f22mr6600046f8f.46.1738243764347; Thu, 30 Jan 2025 05:29:24 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm2028563f8f.60.2025.01.30.05.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 05:29:23 -0800 (PST) Date: Thu, 30 Jan 2025 14:29:20 +0100 From: Simona Vetter To: David Hildenbrand Cc: Alistair Popple , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?iso-8859-1?B?Suly9G1l?= Glisse , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe Subject: Re: [PATCH v1 2/4] mm/mmu_notifier: drop owner from MMU_NOTIFY_EXCLUSIVE Message-ID: Mail-Followup-To: David Hildenbrand , Alistair Popple , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?iso-8859-1?B?Suly9G1l?= Glisse , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe References: <20250129115803.2084769-1-david@redhat.com> <20250129115803.2084769-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 6.12.11-amd64 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EEDBB20004 X-Stat-Signature: pkgdi6c7tofg1cagpfgnkboschhbdbdx X-Rspam-User: X-HE-Tag: 1738243765-840670 X-HE-Meta: U2FsdGVkX1/chok0yK/f+CguYgwaLKLkS+NwoezD/qDDcItoLyeqEXYLCexkh/pcZhH0I0Y+raqOzh/gP9tcqQiZP4Uzzc8diM9c2S2lizw5mSkZ+xZ5ZUWju715USMgy0/FV5wI3cjP+OmnM7NjjvMah9NuY0WYD4b8Gq6mcYHmW372fS44QK1B8qhABCZFbs8kovaNE3wCCUisbo/i+M0TmElLikeDVXo24uJQJ1fecK+S7Q5lFf9r/nedE3RueSk+5usnk9kLRIrPJZJp+AZBTHmKg2pRk5FRGLvjAlizVgLLU8rNVCl7fffCDbDCz0+CXtBGs/vk8VEVSfHmKvwpXN+5zfpA8+m93KFhSYg5xYMbIaW5giv9DUnNqLz21BaUM4hPdq2bd33aZWeJKKcm71J/RmufYsPyRHwDWoCDoP7bpf02uSrOPhQwez2Ncw1C/PLsnsXe6Y43ArldetJuH9xyC3XaDJdeOwrSWPmqRqcmOTe631PM4QpANnwuUDAOwCkVPB+gUDIofNsdvsYUqN9XVpAnsfu36wzRDdwARCaIP1r0vMYPFnaK15aAGtxJU1OYzGzlWU/gR4lGhMDlHX4efO+1WmRaBE/TdoD3QfEyELg+iW27lijEGbKpqHcY7CH8PO89ZL5RYzEy0sqGnu7Jo8siYVVZh8I5IuNxGcMCj/r7xBrME1Cs3BQbXudB1g7CV/QXBIGtasPqenEt0Atudljv2NggqZM1/thzoXIf+F1v5b7Yn6bI2a5bmOcXXlt1PqFONe0IullC88hIuzDbvus63Q3GsW8MjNzVlgPcaDjgZSgLuw1pAYdiv9JNsSkIm9W0Kopll25FKgp2mJ2sRFcjfvkp0b5RjQyftRBRfkvDLbfYrNWO3PFsFgk8iFl3VBoMSqsiZT4smgiJYQ+J/ha0ZZuOj5kk+TcfiWJ56sWU7fliDUHCY+X+LsOjuHV+9bib+GlQf03 D2DzTQP/ q/ekjE5ontQNKFM8Rh187wMUQtNkxDVuKGHHzCSLSY/YEkoUCOvKXeDHVxmvOY3um0R5GV8BQoT1K1zNAANzohxZAvsfYewKPxytiS7uZiY8HarsHwpFEoXeA0+/uNM1nCiJ509mCJhTm+8Ab+iokO1G7kZOU6p46OcLe5PQ01cLs1Jkg0RAqYbpkc8rwbbkMq5z7u7EFAwYmUyc5Hx7YZvoMk2RK6/o5NhamoEcNzQi5TP6QFZwZHJ6WCcX+fbFjLBg1b1Ks0GMInWTmDIWvjpSmSu9+ZOKwGqo4fh1dvrmR7qvd2okmnrKao865/ZT3sQDrKlfSBMZmGFxe9pqaIExWcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.402472, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 10:28:00AM +0100, David Hildenbrand wrote: > On 30.01.25 06:34, Alistair Popple wrote: > > Looking at hmm_test I see that doesn't use the sequence counter to ensure > > the PTE remains valid whilst it is mapped. I think that is probably wrong, so > > apologies if that lead you astray. > > Yes, the hmm_test does not completely follow the same model the nouveau > implementation does; so it might not be completely correct. But unrelated but just crossed my mind: I guess another crucial difference is that the hw (probably, not sure) will restart the fault if we don't repair it to its liking. So the hmm-test does need some kind of retry loop too somewhere to match that. But might be good to also still land some of the other improvements discussed in these threads to make make_device_exclusive a bit more reliable instead of relying on busy-looping throug the hw fault handler for everything. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch