From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F7EC02193 for ; Wed, 29 Jan 2025 23:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10A8428026D; Wed, 29 Jan 2025 18:03:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BA9728026C; Wed, 29 Jan 2025 18:03:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC43E28026D; Wed, 29 Jan 2025 18:03:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CEF2B28026C for ; Wed, 29 Jan 2025 18:03:02 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F5C5804CE for ; Wed, 29 Jan 2025 23:03:02 +0000 (UTC) X-FDA: 83062016604.26.6FBDA6D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 4EE1C1C000C for ; Wed, 29 Jan 2025 23:03:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=itWlX2OR; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738191780; a=rsa-sha256; cv=none; b=rp0YWyFwfJNpTjwWwLJZhn99WpVKyKFiSms1EMaMX6J4PRAppDa0/sH0LQm4nlvQkJ5tbl TJInkGLYdc9ViExpfT9HQxL53Tm0Onr02LKDsyPNSNsT30rN1e+6sviVGu4fysD/VzO+jz Bm+ImD304A7VVLatNIzSzEMYO/r+uis= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=itWlX2OR; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738191780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KfRVwiVvoIL5yKlVMJTKUtLAc62tnU62cuq5lssPDUQ=; b=rfaf7THp7+lgq/m1eaX6xU8f4+SfKO8deIuG1cSPeTHTl2eWfTXQctLXcScBuzvNwbVPWE EdCQoK6uScp8Yx14y+zK1JIHT7OoaKEbQDEQI6B0/YJShXgWISwiVFgL+k26/6kAcHOhod taBhX9puhQdrpRjQ+YqfxLZ2LABOF6g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KfRVwiVvoIL5yKlVMJTKUtLAc62tnU62cuq5lssPDUQ=; b=itWlX2ORYkxDIMR7KkPfVOS3of mA85c29LcGu6a4faK14Mlody6Myv+SWb1GHg19xlyJhbt5kNYKL2B6FpdlCzEbLARSUcwIQ41cQp2 X3vUGRs2gB+fEnK2awaGyv8k71Lho6DGBejeORiCL09uQN8gi/TjYFeHTA8uo4HmrpRscM4j6aLIz P3lIYaOUS7rd0pVqvJZizXk+7R5iOVbXpM+PqOLscrJzqevkL7Q7zxDqivU4iNaKk9v71jIu7WHqj TR4S7YHpuau7rMlzD3CKsqBglLYiS4B7CSyb0omVXOzya/c7BmEEinKDhwyRgTc5VhdLT/3KJbYAk J771SZTQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tdH51-0000000CYOC-1aDq; Wed, 29 Jan 2025 23:02:43 +0000 Date: Wed, 29 Jan 2025 23:02:43 +0000 From: Matthew Wilcox To: Tamir Duberstein Cc: "Liam R. Howlett" , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH] xarray: port tests to kunit Message-ID: References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 4EE1C1C000C X-Rspamd-Server: rspam10 X-Stat-Signature: wefy4rm3cnangoxqmq1userp3mih61cy X-HE-Tag: 1738191780-128927 X-HE-Meta: U2FsdGVkX1+ktRoE8WYAjWG1g2XRARq6dYvq6K/b908mZIezwF9aWthpkU3f97PjH5A9KnF5GUprFnmqTQZoBhnxRCqdAdUMiOKsWO515yabV0p7yOkaE+yGfjqX+LdE1+Iphx6JwlPo18Cq++ohocBG0VunNEamchK0hJRp1Vmaghxu95RlzGRfRbBM2VRynNhM7MaxkMlZCYaU+nE5b7BOjafopPqrQvBYYeGJtapxkfDMMm2Ktl0Gzl1XAYPKQ8rt6lwCFXRKOAgyjS8kuwxQgu3m9msK1eOHhLHtWb/G1hlQUbpyh/H158i5//TlsoAx0bD1L2d0sUOwn3vnrJBI5QjlWiP9fY7T6mH0a8t4TZ4Q8pxpfGQFOOS6fwCIrtaE/b046z/Gwd+B2zwXliA94WWTadv35bAjqwtiJ4Cvd1pfCwXCBgzEIEVJ2jT8ps4ffS+zAuLg6e0HmyeGXJP+G5WCzt6XIpJFO7Hr4ugQsuv8IquKl29vXW7xJydpMTg5MOD4uPuJrlIlFAmsr8Zpix4GPrSa+YrWvlCoYAfxQVbQjPvoM+vVVuZYTkWycxAnJJHWl2+1j6n/BgEn48yc86uyUsk6DODxLyM8HnFVWNOOp83IjLnAbnKUmwtmEuHOf9cQXeJyA/ACfNBFmrCd0c33ztlJfgP1Q03qbCOY8H8m7ogcWlDgUj6X/xMqqaJ/gvgGoTj9tnhpT6c6+osgjO3mPBCtbHb6u45fgSeTw4hy0tEZ9rLizI/mU72dfr002Sz+ehw3RSQVIf0t4eA/+h279lYHPhRCsdZLcTkrErIG8qgyNPjta7zfOEXHW95vUIJxKJWR4bKLNqoEE3aElxmbdQbLwjl1DcNK5DMH06HK8ydP1JCsTSpKOWLFeoFFaNrowbE3sHUwDjp16X3ZzHjAwFwf0VvpPe+F/PIkRTWEh/gURCrl9YesvWZv9ebHwmGpfSj6I06tfbx 5oRNBdMw Rk+Z8POrPIDjCObNJ5aDI1ZIVxywGZv5h428ZL9TGa1zOpA5jBWAYMJU7MFMcStKbQVC5iHHv/jvIn7rowh17/Xip8hxmAm0fRkOzNr8ZMThVzsFdq6XbAe0lDpGhau3VSp5cMDGjMHV59blONVoQLY9PGcdpv0LR0O5UHSGOrrXpK3BxAkCXAqHihhoM1OtCwhlg7smR47rAJHwDVe8oQIXJMdCegPpGqLOWDVJaDTwYQ3dmn+DyTFQTsMWN+vcbHRmDssXOQnS85OpVK6w4pldmt4gbdXICdoXopJytrU1/Nt6Fy6xbSJ6X+VdGcEqksqOBj/Di0nxk0oxWS9N9djdrAH/nBiuBBSca X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote: > > $ ./scripts/get_maintainer.pl --git lib/xarray.c > > Matthew Wilcox (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_lines:4/23=17%) > > Andrew Morton (supporter:LIBRARY CODE,commit_signer:3/3=100%) > > I'm not sure what you're asking. I used `b4 prep --auto-to-cc`. It > doesn't know that test_xarray.c and xarray.c have the same maintainer. You need to use your brain. You can't just say "I used the tool". Tools are just tools. Sometimes they're wrong. My email address is listed as the Author: of test_xarray.c. You should have noticed that. > For what it's worth the kunit invocation, while obscure, is > self-documenting. There's usage information that's reasonably > understandable embedded in the tool itself. I looked for the userspace > testing initially but failed to find > tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm > meant to compile this. kunit is useless. The test_xarray.c module is useless. If you break xarray, the kernel won't boot far enough to load any modules. You haven't thought about this AT ALL. cd tools/testing/radix-tree make Then you can run the tests, whichever ones make sense for you to run.