From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD39C02190 for ; Wed, 29 Jan 2025 23:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EB162800AC; Wed, 29 Jan 2025 18:11:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 973E42800AA; Wed, 29 Jan 2025 18:11:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EEAC2800AC; Wed, 29 Jan 2025 18:11:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5CA4B2800AA for ; Wed, 29 Jan 2025 18:11:32 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 07771453CA for ; Wed, 29 Jan 2025 23:11:32 +0000 (UTC) X-FDA: 83062038024.26.1791CA1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 602FD14000A for ; Wed, 29 Jan 2025 23:11:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XAlzvbpm; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738192290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QKrCOl8m/rCgj2HwdpxvnpKCmh7wiUqfd/v4l4GcjUc=; b=eVvKDIqNLussKeD4hvvxN2YB+mtyLF//FCqfnHGAL4DPpv+n2n7n3WFzQv4PZJCQnhcAL3 28i+pQd91fEnf1exUgPV1rGGXaLBbTPZfm8HkFzrzbTUhZTXuq+OxkDXtYfzYMf7La4qaj 72rluvc3p55C+cirM5ia9Qu0FLxIuL0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XAlzvbpm; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738192290; a=rsa-sha256; cv=none; b=mYJqDY7t8hWB2rqd4/ETVN8SAsucJ4YM3dloONlcIAUD0yOxCxiC6UiXoKy15NgZIj8odC kz/dH2VMpZGXcGR3wbfYwyY/OIlJkzSDbAnalGvTs0UuiGknZn2npcZx5SnwGIe2m7szmd Mh5gEbpRw0/2V/YCajuDyV14Fwgiy7U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QKrCOl8m/rCgj2HwdpxvnpKCmh7wiUqfd/v4l4GcjUc=; b=XAlzvbpm4PcdqKCBNo8ChFEShx lqZp17NxxDoP4sob5u58w7AX+GnxbL96EhyRp5zw+EiRrPm9v/XqNrH4/nrejYuxVIjqsPCqz9YwP WMKOB9JSXo8Hm3gkO35cRfNjT4Y2eBvLdqz52evfls3I1nKZpV3NZx6BhuUKxl+NCEw2Jrh7gm6Bj 8gZFqrfU1pvJtZ54J3RtryoRnnuNleBENVgW56ivU/gcjhbOU3SySG1FLFC3cntYHzmArpoHIkYaR detcDBHbIfOt7GkEL/RaJcrVpTK6ZZv1uSHlI9GlsJSld2ZLb2LwbjPlRNQNeyLSNHcSHQayK269J wbFRDBMw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tdHDP-0000000CYqS-0Mah; Wed, 29 Jan 2025 23:11:23 +0000 Date: Wed, 29 Jan 2025 23:11:22 +0000 From: Matthew Wilcox To: Tamir Duberstein Cc: "Liam R. Howlett" , Sidhartha Kumar , akpm@linux-foundation.org, christophe.leroy@csgroup.eu, geert@linux-m68k.org, justinstitt@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com, npiggin@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH] xarray: port tests to kunit Message-ID: References: <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com> <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 602FD14000A X-Stat-Signature: 75q4efpu7ff6sy37adiwiftdc7rq6wzu X-Rspam-User: X-HE-Tag: 1738192290-26310 X-HE-Meta: U2FsdGVkX18Ew8gk7GmZK3CY7eFjuo0pLhjzyExRv03MNJ9hvFH/q+sJnvgj3Lf0Du+iLEbgITM4cPZZmgnXiqvAh7ofXeG5qTqO1OvG3LHEs7Ahfm5NN2OChrQAd2iwZuc0CM/ekOgzDbkdpluVEB8cZoALQkHL/+YEuN8pwNSDwk+mTWgHDOmTLjWC3X7n4WUOr/IGIqhPWTyrbRrjXhivn55Ts3JMMZnKtA0Rn3a+JyuqVuXM6J6cFXwUfu6Kr9tY1mK8bppP7VJM1sEgHK2kb2MDh08AN+izWxbp11AQH8R5zLO+j0k8thMI8DyKkCP0567bQW17qoaE5WJ3985x8+lQ5LZw66FH079Opdd0VPRRLNHpre8Gdy8imDNM2SEHsxisubQPa8cJHJ+ToSJJFNR6mLZ0OYDdVhEO1245aB3mp5q36YGmF6zL8iB/G204DqCpy7gEw5JnjdXdqt0hYJDTV/ueTXmSgIj095W0k+ZQ7gz4yoQVAfNTAzlbqFO1Wch3V88Je+ek3pxUbr/ylZf1o5Of1Fpccr+18MSyCIMMTGSOlvE0HH674ydcyZ1s6u1xRELm+gAjYEOz5al4c5zUJUWWnZspK9Xwgy5jjFO9SuLzXDEfY6tbaoM+Po6HE+sIxk3RxkSbMswbsuR49G9q1QyWARx8w0gXx6GICD1aqhDkdtGeGIH7CPZw639y9N0XXbNUUj8JOi+Us6DhyPvY+bm7pksXaStEhnAz/VWtlUKCHfvBaGWW9RlHMslYMNFXug+kmTg1KS3DZrsufXBq6dd+QpvPIgTEKZb7AO/8rtJ061YAKWO9Pvi4jgB+LDt5E/0id7bXhooxS+4EX6/x6VkcffyzA2mqXZAGeX+HhM+Vi3/fRvikosNIDH58NbwPVMqfwfNs8n+wPaAnHDL/StJU1REVp5sfgyXRO+VtpsXi+c3ZVa/OZDm04Of6nCcYLEU9SilL4wQ kTpmm8z5 nDDJJ+Mh/lfqDt6zTkscD954oONbuQYiJ9tCK+w9U+Wc+fzusPK6CH3o8o6mYAWpRzIMOe9B7wVKiIPqwnx5TT040Z3UvUVZcilPX6psOtmJxPGJJL4UE1oAZKqeCfO15svDnI0EsHAVEKh6GWJAFVKfQsgFMjL1nQ8pqcHpdhRCAN9Z8LdY7ozOiwem63N52obHBz+8zMSvmfbHQbuOEyyfpOEpLXChQPJwKqg/GiGIKvS0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote: > The whole point of tools is to liberate stupid humans' brains like > mine from mundane tasks like working out who to email. The tool wasn't > wrong; it did exactly what you told it to do in your MAINTAINERS > entry. Tools do get things wrong. So do humans. When you take your hands off the steering wheel and the car crashes, it's still your fault. > > > For what it's worth the kunit invocation, while obscure, is > > > self-documenting. There's usage information that's reasonably > > > understandable embedded in the tool itself. I looked for the userspace > > > testing initially but failed to find > > > tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm > > > meant to compile this. > > > > kunit is useless. The test_xarray.c module is useless. If you break > > xarray, the kernel won't boot far enough to load any modules. You > > haven't thought about this AT ALL. > > I don't understand what you're saying here. Then I don't want to see any more patches from you until you do.