linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	akpm@linux-foundation.org, christophe.leroy@csgroup.eu,
	geert@linux-m68k.org, justinstitt@google.com,
	linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev,
	maddy@linux.ibm.com, morbo@google.com, mpe@ellerman.id.au,
	nathan@kernel.org, naveen@kernel.org, ndesaulniers@google.com,
	npiggin@gmail.com, linux-mm@kvack.org
Subject: Re: [PATCH] xarray: port tests to kunit
Date: Wed, 29 Jan 2025 23:11:22 +0000	[thread overview]
Message-ID: <Z5q1mkliUUM5Xlod@casper.infradead.org> (raw)
In-Reply-To: <CAJ-ks9ksSh-r6SmKsm7iJA6nCqvrhXZ8jtjP-YoeMNB6tF5a=g@mail.gmail.com>

On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote:
> The whole point of tools is to liberate stupid humans' brains like
> mine from mundane tasks like working out who to email. The tool wasn't
> wrong; it did exactly what you told it to do in your MAINTAINERS
> entry.

Tools do get things wrong.  So do humans.  When you take your hands off
the steering wheel and the car crashes, it's still your fault.

> > > For what it's worth the kunit invocation, while obscure, is
> > > self-documenting. There's usage information that's reasonably
> > > understandable embedded in the tool itself. I looked for the userspace
> > > testing initially but failed to find
> > > tools/testing/radix-tree/xarray.c. Even now, I'm not sure how I'm
> > > meant to compile this.
> >
> > kunit is useless.  The test_xarray.c module is useless.  If you break
> > xarray, the kernel won't boot far enough to load any modules.  You
> > haven't thought about this AT ALL.
> 
> I don't understand what you're saying here.

Then I don't want to see any more patches from you until you do.


  reply	other threads:[~2025-01-29 23:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com>
     [not found] ` <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com>
2025-01-29 21:26   ` Liam R. Howlett
2025-01-29 21:28     ` Tamir Duberstein
2025-01-29 22:26       ` Liam R. Howlett
2025-01-29 22:33         ` Tamir Duberstein
2025-01-29 23:02           ` Matthew Wilcox
2025-01-29 23:08             ` Tamir Duberstein
2025-01-29 23:11               ` Matthew Wilcox [this message]
2025-01-29 23:17                 ` Tamir Duberstein
2025-01-30  8:21         ` Geert Uytterhoeven
2025-01-30 12:51           ` Liam R. Howlett
2025-01-30 13:25             ` Geert Uytterhoeven
2025-01-30 14:05               ` Liam R. Howlett
2025-01-30 14:24                 ` Geert Uytterhoeven
2025-01-30 15:16                   ` Liam R. Howlett
2025-01-31  7:39                     ` Geert Uytterhoeven
2025-01-30 14:09               ` Lorenzo Stoakes
2025-01-30 14:38                 ` Geert Uytterhoeven
2025-01-30 14:49                   ` Lorenzo Stoakes
2025-01-30 14:22           ` Matthew Wilcox
2025-01-31  0:22       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5q1mkliUUM5Xlod@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=geert@linux-m68k.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=llvm@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=morbo@google.com \
    --cc=mpe@ellerman.id.au \
    --cc=nathan@kernel.org \
    --cc=naveen@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=npiggin@gmail.com \
    --cc=sidhartha.kumar@oracle.com \
    --cc=tamird@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox