From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E41C0218D for ; Wed, 29 Jan 2025 12:57:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12FE28005D; Wed, 29 Jan 2025 07:57:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC1D128005C; Wed, 29 Jan 2025 07:57:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3AEC28005D; Wed, 29 Jan 2025 07:57:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F15C28005C for ; Wed, 29 Jan 2025 07:57:49 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9B4131C7F05 for ; Wed, 29 Jan 2025 12:57:44 +0000 (UTC) X-FDA: 83060491248.18.A84A728 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf14.hostedemail.com (Postfix) with ESMTP id AE168100012 for ; Wed, 29 Jan 2025 12:57:42 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GKms713t; spf=pass (imf14.hostedemail.com: domain of qasdev00@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=qasdev00@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738155462; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=DTlHocQLKBLXqEFfrl1xRi7eJlfaPsdNridYLMUAhf4=; b=O/qLCKGwgcUFW+YK/Sq/fLsZfn2Icokuu0oAOxVjToZINbkx94RFC9YUrlXlKCX16zHH3Y n0+V5T1Suomm944aXlbJ9F3k92DbSilJuJHH4lf7zoLKI6vBZ+Hh3iQKUjb/zxa6DSy1Re CMOqltOe8xPnTCw5ZHGH0/NMXBs9VFU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738155462; a=rsa-sha256; cv=none; b=2AL4CNj6nhupvQOPxcSnuDH92LMSi/RAHgq5x6OllTJa8T7HPyeEqDOCAU0lYD+SiVeWh+ E8CI4TDzqu7KoZU+kgLghpte/UKjVcHZ9/R6D2N8bPBwc9Kwry4eTcMngfOtcpTEUqksuX tiYYmKbbss9rMH9HFZG+Tmh/6Ol9I5Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GKms713t; spf=pass (imf14.hostedemail.com: domain of qasdev00@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=qasdev00@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4361f65ca01so71552725e9.1 for ; Wed, 29 Jan 2025 04:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738155461; x=1738760261; darn=kvack.org; h=content-disposition:mime-version:reply-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=DTlHocQLKBLXqEFfrl1xRi7eJlfaPsdNridYLMUAhf4=; b=GKms713ttPdDfZ1k8zSWsF8872v9J9QwnfUO6pVnVNYEI7R/niK9RORsyg9MWhWZid zfwNncuX+kwYz6G9HDZL9PUGCtJ+UTQTiOfMFwWRarfmk9etkaeM/LdK3i198FOLnoAd xJi4mVbcn8D5SP/FYFU8GOlV15o7QxdeStOFxi7kIYbTpDfQDKFneyHgy8FwPe6BrWGX +StG98N3QbbNr1vSK83WGRyHviQPjHu2lYS5Mpb/yvFkPH8zwgyMdM3y6z0QZZcZfYRw ojiFjsUJuhy7mG4n6vVAKS9wXwxWOEgc8eBup3Jnc5qBgW2oJgFGlSY4tHZjZr6eu1xA RoDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738155461; x=1738760261; h=content-disposition:mime-version:reply-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DTlHocQLKBLXqEFfrl1xRi7eJlfaPsdNridYLMUAhf4=; b=TyEuM9NO2W6N3gETmJYBJuXFagxsiLrlMUGvrAQQ0hG3PCCl41ea74wH0U9/H8iR/B koew3sQNp04MKjfZ8SYvnPVJByDTR5FJkrEYx+mXWjSuul5uq6+obcuRR/5xWzhN0Xma 0qj5oE2jE++GcuegP9D0Fxt2baVLoOzFq9KHyO0pr38tuQeSzk5edSsxtNGECmD3SxxP ZIpC6YSPzMj0NX+sQzZPxApl/xkW8H++eyrWraSR6TFbX8cCzz/D6oNo6G77RvQxSgvA 9qxhGx6qfA2J+KwzMDzgQ5keHgOjkTJNO1AgZRv1Yq2E7raXXCT9HLasQGyOWrH1n6NL xg+g== X-Forwarded-Encrypted: i=1; AJvYcCUvugIbnrWMjC1rsqq8QBdZUMRfl7cb/2ldvLJfZ8U7XZr5RpyfLUIh1Qd+/uPv6DYPqmBFqPILpA==@kvack.org X-Gm-Message-State: AOJu0YxH7pJ9f3ZgTmgw1VjLqxTTOTOSoLS/2LmqrXwTb9b7yRGQoxX0 vmO+FpOxl5lePy7n0LA7c38clvxRs3r9+CBXqoP5HrsKndvDb/vx X-Gm-Gg: ASbGnctZ1SfnAKpRRCH3YE8aIxb1duIFxzL/6XnSbepNU/pz0YlsjL0B5U9Z6nrJVOq 5FHzncUtmnaqAppn0C071c1JXQlUeUbHVVxuRgZ4EwssCKQIzYhVGCL3Z1SrKgWidzhtQehsWGO SBE2bTu7CB2kRO66PWH6/lNIKsrpIucXLvgJxjRUG44MqAxre0HpoujrZDme6DJP5+zOWgAi+vU qGBi1k19H6Cpxh7ukX79HzO1Ka2k1Q4zKgMHmL/+S8SNehWWBRd8C/AgHm/Kw8L7v2lrg34KRbz Yulm0FcszTKq7irJACs= X-Google-Smtp-Source: AGHT+IF5M+zUFCUlQQ7RG8ypwocdkV029yWc6SVcb9yTpg/81d0h8dv0mxgrWzVDagpXSgMe7QtVIA== X-Received: by 2002:a05:600c:19d2:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438dc34b37bmr26409035e9.0.1738155460813; Wed, 29 Jan 2025 04:57:40 -0800 (PST) Received: from qasdev.system ([2a02:c7c:6696:8300:574c:cbc5:bae8:cfe0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1763e9sm17475001f8f.16.2025.01.29.04.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 04:57:40 -0800 (PST) Date: Wed, 29 Jan 2025 12:57:34 +0000 From: Qasim Ijaz To: Hugh Dickins Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/shmem: Fix invalid PTR_ERR(NULL) call in shmem_xattr_handler_set() Message-ID: Reply-To: 16055fb0-bed3-e000-8c36-6e4886b08c9d@google.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: etcswmhhf9scswdd5ztpr7kjkezf4u7g X-Rspam-User: X-Rspamd-Queue-Id: AE168100012 X-Rspamd-Server: rspam03 X-HE-Tag: 1738155462-603891 X-HE-Meta: U2FsdGVkX19AW3DCCRTca6a9X2a6UEH/HnF/kTdeZf0t3w5Sd85/M94WhKqgBbqDvLRkf176ESPEQ8Q8/Xrc88m4lWkF/F9DFo15AMpsFvi0Xn68Ytxt1m1uZVvYGuy/hvmPzseiIsn8AeI3YnsEmrFPOetdI04MSLfxMcD4n55MXpkUm+tc2gsRpoSH5U8YPMMFdJegwVjom5M94i260Sa+nIp65OZG3hp95Utq3PHwcLZ1XDe/5H6uhWiYHfNUYLIK6X6gXRbRjoGsz4FMyth2FZRmsJaQLI7nTvRk5e0BgzoRBUh+5ER0adZ4gxY9UmVEskMWtQhPCb1yHLGjku9qtoC1TYygommctNG5SOC79FdWcVqcc+Y+tKic8J7i5OtsFfAzp8F+mOGeSLRXGKmSlDbVfVx38b8pgJMg7HrRCQFrxV3jSJfqyljvsgr1xb2mvyXjBpYuGzZlnluc25luGx9tHwZ3P5ETkT+ZMVLZbhH6RJiavU+kzgF/1LtUXzBljhueH7uUsg/gvw1GueJVkKM4QHi7SgTkzljsOuzPwYjJmgzaIe40HlXPXkQXXoDCCGysgppillLgmWDW/tVW0qLA6j9Z/IyhdFN8VGdZBP2iNIipkCz/PE3VpwB1LIMXivHxKvjb0BuzMHMB5RcY77AmQ0IGLx8q8+7rl84awLT8XYlCIESmktgrV4cJiBho/3aELr4hen9wp3uVcK79lina2QNsCOfGjdqx9iPLki31bvqduQPAph5p9WCcGn8QU5Qj+8eAtLlQFQVJmCDv1tbAi2HzEK4niIgsWdWbEBbaXneXWHpUJc6W8LXzBy/3xzRTbyrWew1Tjaf4aBU0Uk6D+vwPCMuVXWxkpKcCEKh5Q3s8FpsxGVEUt+rz+sUAyAeXxyR5dmHZcTnd84eueB0zbkHNO5bmSJtf+AUT2YlBucU4Ba2qHq/K3eVrT6yB1CbMFB4Ofkg1GwN JqIX6Uau srYXD7qEl7DH9F7z6qxP5UMzQBKMgf+I1H5JkghLdE5mOsB9xejn7ER+bFJABPIhlfe5nIv9Ay5oV1GTGaNSCjDJZS0A3QPPTrDJ+QMbg3LujBEp5KTiGn/RyfSRjwzbwiM0NpHb0hbHpJU5W48jI5rU266Gom6bKTvFzdaSq5Jxk1lOqAvetCiGM716CMILbrgRqyEn8kOzBnySQsMGQ5IMO48xTj86wgnPrD9b3ty6fxEKH2fPXVS9O0yigVO2+Q+7THQC177Uih/CUUbGW4Ct58s6dSD4IReQ/GHnDfyr+taHtyvTRhPcUPYXpmM7ivon8Aivc+2f5vMZ7rhA6WDxrLrTgGxx2GRPXdB2MmlqH//VYJkQBs92HMoX46lN9a1OwnqvHSyCt4GGfH0HHBr7zANrYfch+MZraulHFEWyOI6mbiTxM99Dk2U1T7sIWXlKG5jx2RYKkeD5FGL6HNc4rl5lXvFOi3NL5k3/PWMMofhA8V4C/EB8fFsfKNuutmpDfg4SQ2TOYzY3kFMj3LxpYDGPP/burGqU7PnERygKCeFhQNk6C/IsO5Meg9WK5P5pbWtWWEjmO2gWQqfN2BpJ10yl7fDy7WYXZglSL12xqAep29SK49ctq90Gd+TY7XB7ti2Nqnahdx9WfMapGbeivDfNurQLGPCccsSQ/cSTQZvsi1nk7KAlHjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 28, 2025 at 08:37:51PM -0800, Hugh Dickins wrote: > On Tue, 28 Jan 2025, Qasim Ijaz wrote: > > > In shmem_xattr_handler_set() if simple_xattr_set() succeeds and the pointer > > returned is not an error pointer, then old_xattr will be set to NULL in > > the body of the following if statement: > > > > if (!IS_ERR(old_xattr)) > > > > Later on shmem_xattr_handler_set() calls: > > > > return PTR_ERR(old_xattr); > > > > The PTR_ERR macro is used to extract an error code from an error pointer > > and NULL is not an error pointer, PTR_ERR(NULL) simply results in 0. > > NULL pointer returns 0 for success: yes, that's what's wanted there. > > > > > To improve correctness and readability, > > Correctness? Please explain - I don't see any incorrectness. > > Readability? Perhaps - I should not be the judge of that. > > > refactor the error handling > > to have an explicit default return value of 0 (success) in "ret". > > If simple_xattr_set() returns an error pointer, store its > > error code in "ret". > > > > Signed-off-by: Qasim Ijaz > > --- > > mm/shmem.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > I prefer how it was written before. Hi Hugh, By correctness I mean that NULL is not an error pointer, here are some additional points: The code goes against the documentation of PTR_ERR() which mentions the argument to PTR_ERR() should be an error pointer. NULL is not an error pointer so I think it is inconsistent in that regard. Secondly the current code is hinging on a side effect of the PTR_ERR() API being passed NULL, sure it works but I think it would be better if the API was used clearly and consistently with how it is meant to be used. Also to add onto my points I decided to run the mm/shmem.c file through smatch (since one of its key features is detecting 0 being passed to PTR_ERR()) to see if it detects what I spotted and it brings up the following message: mm/shmem.c:4174 shmem_xattr_handler_set() warn: passing zero to 'PTR_ERR' Best regards, Qasim > > > > > diff --git a/mm/shmem.c b/mm/shmem.c > > index 532afd8e049c..3e97c7890aac 100644 > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -4143,6 +4143,7 @@ static int shmem_xattr_handler_set(const struct xattr_handler *handler, > > struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > > struct simple_xattr *old_xattr; > > size_t ispace = 0; > > + int ret = 0; > > > > name = xattr_full_name(handler, name); > > if (value && sbinfo->max_inodes) { > > @@ -4158,7 +4156,9 @@ static int shmem_xattr_handler_set(const struct xattr_handler *handler, > > } > > > > old_xattr = simple_xattr_set(&info->xattrs, name, value, size, flags); > > - if (!IS_ERR(old_xattr)) { > > + if (IS_ERR(old_xattr)) { > > + ret = PTR_ERR(old_xattr); > > + } else { > > ispace = 0; > > if (old_xattr && sbinfo->max_inodes) > > ispace = simple_xattr_space(old_xattr->name, > > @@ -4168,12 +4171,13 @@ static int shmem_xattr_handler_set(const struct xattr_handler *handler, > > inode_set_ctime_current(inode); > > inode_inc_iversion(inode); > > } > > + > > if (ispace) { > > raw_spin_lock(&sbinfo->stat_lock); > > sbinfo->free_ispace += ispace; > > raw_spin_unlock(&sbinfo->stat_lock); > > } > > - return PTR_ERR(old_xattr); > > + return ret; > > } > > > > static const struct xattr_handler shmem_security_xattr_handler = { > > -- > > 2.39.5