From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB230C02193 for ; Wed, 29 Jan 2025 06:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39797280031; Wed, 29 Jan 2025 01:03:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 347DF280029; Wed, 29 Jan 2025 01:03:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20F67280031; Wed, 29 Jan 2025 01:03:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03DFA280029 for ; Wed, 29 Jan 2025 01:03:12 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5F12A095D for ; Wed, 29 Jan 2025 06:03:12 +0000 (UTC) X-FDA: 83059446624.05.5830432 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 7A7A340008 for ; Wed, 29 Jan 2025 06:03:09 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mZ7y9Fk4; spf=none (imf11.hostedemail.com: domain of BATV+9fd617907e4c3385df14+7829+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9fd617907e4c3385df14+7829+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738130590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hiq1uScUML6Rsu2S+zgxlNvLPyp4iGtnsMkJjdwAtNQ=; b=pJsl6ve73EnqlKW8LU8Tsp8/hqS+cpp2E3NhDeW0vQTG4+b8IqX3ft9t57MWmyLBU90/pm j7UJeTx5t/VLFMgf6JsOsGd8zmxYVlrU1/CUt7qfeeVDicVdtr54RO59dsW90TSFevNsii u5VA9uIaMRaptJuEPQeNkTZDZgBN+Kg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mZ7y9Fk4; spf=none (imf11.hostedemail.com: domain of BATV+9fd617907e4c3385df14+7829+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9fd617907e4c3385df14+7829+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738130590; a=rsa-sha256; cv=none; b=ZF17vvq+BGLw4IgKb9MMvkvB4f/7eqs5Q486+S0Kv6rES4PfUeN5S9s3WbJGSdokWkzFa1 zEuukJlFYXDWIjO5tmCNv8/qAqeSMpgDZC2JrTiuSYigsLXU2lhvd/m10eyvln0qlQrS8y zltwHiGpab4P5KkMhD3iphGXHC5SR4I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hiq1uScUML6Rsu2S+zgxlNvLPyp4iGtnsMkJjdwAtNQ=; b=mZ7y9Fk4dGIXhI5NWhZA3+Aio+ o3LrzoIz+L+Kp1Q6445Ua0/YG78zDtSGdZ4XWofQ+taJODq42y1iQuspFwKsyPnOUUvhIwvtCOjmP IDXE+sJtD+4fme0fDjZHGRGX+4aeNrL76R+os4ZtF+GfVnsbFh4SiGyxC8ssmJNyqqfFlR5hzRDPV TwGXwCP+8IDfms3STsUnfrsdN5CsCvpk0fS+akdoR/ju79FK+rGEZ0xyw8oL0S63rAG5Aney917RA bNeQegGWl6bVULcQFBwNXaLNbDYrE6nw3j2Yf5LK43/WqCjz0JUgXrc1qYUvglVYRFhy23G/fYZAw V8BkieFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1td1AI-00000006Ngg-2eT6; Wed, 29 Jan 2025 06:03:06 +0000 Date: Tue, 28 Jan 2025 22:03:06 -0800 From: Christoph Hellwig To: David Hildenbrand Cc: Christoph Hellwig , Matthew Wilcox , linux-mm@kvack.org, linux-block@vger.kernel.org, Muchun Song , Jane Chu Subject: Re: Direct I/O performance problems with 1GB pages Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7A7A340008 X-Stat-Signature: 1nkcdcjg4jd39tey8kfwtcnz9a664wj7 X-Rspam-User: X-HE-Tag: 1738130589-418444 X-HE-Meta: U2FsdGVkX183flri6NuRiI/WdUavA/0eCsBMYWV8BJlCL7K4+vUePp4WFpTgpfkXeu91qg+2qIC/X2lCzsstnB+JMOY6UcJwHhfRHDzns+TP/ODbTce5iWvjbHWpTiYjM3GOsQqVFPUEcNz/gRkeDjcJ3wmQxJWcHgAxgKSTq1oBDhmOxu29z6axBhi61mGBgQA1pA0AGPnhtBlbB5x2zEZF+cmQdUSO9KJezMcYWwxtnVvwyKRvX3hb3o+3DziPneX/NfVIbdjXAI5Rg+LS1Q7DdfvIOXvorzQfSaddFKbwww8JoY+aOzTmzUqpgpE8Q2Y6fHezWBwR6fbycYeoP9ost5OyH/a3YeA2Uf2BM8c2dnCcBF21S4WEx8VM9gSZq2ivBR420Qmby8RH4i17C6Lb2VPJyOytyogfK03FbITzGLTVUejL5dVQu2C2NqLOQ1dciyBjJwDaLU47n4BE63Gqxi6u92fYjR5VeiitHzdjQlas1nG7fn3148pwqpV+w4iGEm2K/O9x2n00fY/0K+iBawGt2t49zJDNWLwp+3kjnJCiC4egWOw2WLVDZ4fkoezL8cvt4RWVu6EQekt62nwcozTCoZw5/8NSpEkZqC7Hzj2ut/0OE2REaDo46nibD1fmrwMX3I1Aslai0grwGmbLpHEnqpgn0kR2AOVg4SSegXeB7E+h/9vMFM2biByQ9tMwgttwlvCnLUz5Ub416IkXxlCxecXsBQ9z6JHBX06tPRv+We6xFg61oRAUrIo7Bj78oFqiuj4MV3oKkFt3H6FD543ZIlLED+jlwLW+IusIg30Pka9e9mjWcSnGTSH4rNSChy8ZUIp7y4QtzfzV0r+KdOrY3sJHNvugLnTF49t6FWDA02cdC7oXE2HWkjIUxQwzE9lI0kYSRyL0+Ro6ocvrvczLvJHm/0aJqx7Wt8UUgTVF7zbjcJvTaVqCditjJll9UvT7vDMF5MbIdfb OiAtMGmD tn9p19C/UzG0wL8UV1qiv86Bbqbl74jwJ1Bxn1ux5dpsmYcYkgDbJ2ZQTScUguOMHRsTR0KTxWu8BEtpwIUXiHt/8ZLvlYkBp7NTm2898Ee5l7uFQHPGIF8wHPH+8TUUMjOnRFA1wV/syuhoyAv6Me4Em/FYvm3KZwu6YeSKPyERbt6ojUpvmjl/jumZ3Tso04tQSLHL6Zv7sGGqux1s4hiyPjHwOCumy8I9fEJQNy22kLJFNXHH3EAvqDriI9FkxBRXQZQ6f6v3DBcJqwQ2ZSU3QP+fokqEwQTyRfIAyWAmPM9UlqwJ7JHp9OnsqHE1pWVBp7b/t473IEPKZ7Nvag4wUmF3okwG4N7yGlATicButUJagjihBmbPr3ugvJ7jNTNIKUiJiuwJXXqiWs2+Cn7QlAh5gLuwaSMXI5I6iQ50Kj+xVxfU/LwDONi0CbNGv2pucWt1Xf7JGwBNsJZFGs3zQRckaz3zb/5XU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 28, 2025 at 10:47:12AM +0100, David Hildenbrand wrote: > Yes, I did that renaming as part of that series after the name was suggested > during review. I got confused myself reading this report. > > internal_get_user_pages_fast() -> gup_fast_fallback() > > Was certainly an improvement. Naming is hard, we want to express "try fast, > but fallback to slow if it fails". > > Maybe "gup_fast_with_fallback" might be clearer, not sure. gup_common?