From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C4CC0218D for ; Tue, 28 Jan 2025 05:58:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 342BD280204; Tue, 28 Jan 2025 00:58:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F19E280202; Tue, 28 Jan 2025 00:58:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E06D280204; Tue, 28 Jan 2025 00:58:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 01674280202 for ; Tue, 28 Jan 2025 00:58:09 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 80DA11A0B43 for ; Tue, 28 Jan 2025 05:58:09 +0000 (UTC) X-FDA: 83055805098.10.9FD9D04 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id DD5C320010 for ; Tue, 28 Jan 2025 05:58:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Kb4PacBE; spf=none (imf13.hostedemail.com: domain of BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738043887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lhu4zGDd4xcVjurqw3pEZgdUvwfwUI8PbgF5I8pxXXI=; b=1aL0sRA70NBDsCBYWwAo0MOwiAA7Hn0UK9VLcOwtgfOtbGqvXn7JgWas8PExfuwMATFoW9 6ikmj/5hcM1axA8OgOwFe74qRdvMAqcOD3d/cF/jf+HoltJmIim1tH+HqGHK66fg4Zw1vY UJGBWrOyOoxKQsyQeuTqPM3FG+nj2xU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Kb4PacBE; spf=none (imf13.hostedemail.com: domain of BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738043887; a=rsa-sha256; cv=none; b=trV+65fBf93XZvVmlJbS6oEtTiC6cZHUr7ZCFP4difGWFJ1FwyCQEYCrp2LanGIsZfGsoR x9VV6IdhNzqOvkKdshGPuyc8ph0egsatPEk6Gb+Y3zRJxCg2mCzYjCeSJ9yM+ZXTSIAFuf EwN+ghfSONvvKtvXfe1SDFwufL3Tq6s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lhu4zGDd4xcVjurqw3pEZgdUvwfwUI8PbgF5I8pxXXI=; b=Kb4PacBEHapoUCCQu26lxil/n1 S58HQfGSICL1sGPjpCbdThVmEZT0aaePsta/lLI9RN4j8QtceGCTBOMg5x/heRmSxghef444rMhio Oaj5vYAMqrhS6uYUOp+3HXj8Y6LUdk0ll6aC2ZSP1RI54nb89CQqOviI1tiuDEqATu1vD89XzXw7h UWkvM3VMGkA1K+XaDRaebzED8OllJevw2agswa36riMUHLOvMrMWtGSVnMQTxCsn4q9oVPXc1Xo1z Am4gk/HEunIu7snaDFJp/ihlewz+u/pD/mLPzrssqv0uy9Xq/xpObbTMYD1v4K42hRBGpkLL0kjFa mI0qtOag==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tcebu-00000004BbM-34R2; Tue, 28 Jan 2025 05:58:06 +0000 Date: Mon, 27 Jan 2025 21:58:06 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Jens Axboe , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andres Freund Subject: Re: [PATCH] block: Skip the folio lock if the folio is already dirty Message-ID: References: <20250124225104.326613-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124225104.326613-1-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DD5C320010 X-Stat-Signature: 4b636k4hhaanpdofwm59fqyciee3yafs X-Rspam-User: X-HE-Tag: 1738043887-145668 X-HE-Meta: U2FsdGVkX19hj9ZOUaa4remOktIqFEotOUsb71dxI5VZAZy+NuSmxo/qQ7mzAg5dlL5BMkpRdw7HPryWRZTjNz0v23t8yZE6UlRuy9ezPzkBLpKt6PJX08Z7Q1i3/sKyM9Rii2X2BZXCUdSnk8waCweaJA1vFuQTGbjZM1wIXcnrF0+y5Pae6JVvZ3ZRRDbZWoHNN0cH26qCQE5t8+e0HP1csB/CqFUW8Slu2Vxdb3kh5vdlRaE7foh6E7qfXyM09UUnfOYoKpZiPLKmQ9cGJFlH/EOEwblVXXAMS7KTqYqQLzFRK3V/8xTSAFV7q6+kjJ7dW9OW0xhTguW4FJiQlEUV9sc5DvjSk5X7Hwhxnxanqc8WSFGSAPCNoHjC6Ib+9x4jljgyIvdGy/qkB1AGGJu3tcCgW6IfGegTwSXS3RFxi4v7dWYus3vBfYF28zMgP7QWEk0Xo4Nc1me4B6jGGsbo/tlY0XRWizIkZ5dvYUkfoCZq4BAecWrT96l2d0CAqZ5MA90GtrU6S/cDWC5amAJpIGQCS7moWHBrJxh+BhptR0tCCp+s65fJ7GB6v3Qm8Q+HhbMJ99WT2GjiVErMPrr9ndl2ZSXXdoY0BhknfgG9zrUy7YR5Xzxxevm6b3JUy1fprVp2xrAYMQ3Ys4hnGn2HKJo3TDGr+KPdjIijSi7NTLdAfXanS8t6+cD/4f2gQKO6FhS69yLcdVA/YJY9sI47aYDElRqD9yTHdIi/I+6B/LjxquJfh9KUHRi0085PyxU8CuZX3H9Fz1+sIgwgwGT9S1hHTOuYPoYThVhih+opvPJD8ffO34RgzCc4ISnehdCFz0pgbTbVA+kf/5gs/iWHF23XxP1byK98iVAIYv+ByfSAVG/o8ro1mVTusBO3AKWtqgzJqed2UXxRY7IyVkJVIdO3AHxLpGI8etQgvRc7qd0EDiFgZ0JKr5xmC2lcWbnVO4780n1twgrxrs4 +45nbLgm m1FgbV28DACgRWjveW3T0qZ5fA5YFceMNnbjr7Lt6hc5aUMn36JU/KhBBD/RJ+7tqsdSYuFyrmowKATcM7JUn/KrRXFrtqWhkeH3KKPaceNkn7KUJjdDzYgyc+z4zS8m/tXZQlTRJBx6vw5vwfyvBE/7/2BiPuX3WL3gyaVcG5trUajWXAq0DyGSNfTUwm3WJ1PiDDAPNamQzcN8KrzbZGcaV+P6FxXqQgF5UeF4wK0iv6OsHu0OGhg+RTkj3kiO8yWqfHXUUP5IZ13NyygrqMoRs+o4qLewycZOL49A/o5bXl2TKnnVma9wdjwc+oGl+c3qrFf0Np1hTf6n4xHTsmDIjzD6DokrNfHjwtkzA1cxqpSIqqAmwd1pIO3JEfFzOca0LuZAp3abbrp6+mNyjtZIyDn+KBRJ+2EYbsFjE6V87k/U366LHCkxEAc9Tytz/RjXhn1MOHjnwSs23um9eGhSy2tFSMLFyZsXcUPIh30pU6vdOPYXihz/g83hmRNMJtZUD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 10:51:02PM +0000, Matthew Wilcox (Oracle) wrote: > bio_for_each_folio_all(fi, bio) { > + if (folio_test_dirty(fi.folio)) > + continue; Can you add a comment why this is safe (the answer probably is "folio dirtying through direct I/O is racy as hell anyway and we don't care") and desirable? Otherwise this looks great.