From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Andres Freund <andres@anarazel.de>
Subject: Re: [PATCH] block: Skip the folio lock if the folio is already dirty
Date: Mon, 27 Jan 2025 21:58:06 -0800 [thread overview]
Message-ID: <Z5hx7kpk4UyF0NYN@infradead.org> (raw)
In-Reply-To: <20250124225104.326613-1-willy@infradead.org>
On Fri, Jan 24, 2025 at 10:51:02PM +0000, Matthew Wilcox (Oracle) wrote:
> bio_for_each_folio_all(fi, bio) {
> + if (folio_test_dirty(fi.folio))
> + continue;
Can you add a comment why this is safe (the answer probably is "folio
dirtying through direct I/O is racy as hell anyway and we don't care")
and desirable?
Otherwise this looks great.
next prev parent reply other threads:[~2025-01-28 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 22:51 Matthew Wilcox (Oracle)
2025-01-28 5:58 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-24 22:48 Matthew Wilcox (Oracle)
2025-01-24 22:49 ` Matthew Wilcox
2025-01-27 7:52 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5hx7kpk4UyF0NYN@infradead.org \
--to=hch@infradead.org \
--cc=andres@anarazel.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox