From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417A5C0218D for ; Tue, 28 Jan 2025 06:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF62280206; Tue, 28 Jan 2025 01:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F7A280202; Tue, 28 Jan 2025 01:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3737280206; Tue, 28 Jan 2025 01:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DF61280202 for ; Tue, 28 Jan 2025 01:12:19 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D138160CB0 for ; Tue, 28 Jan 2025 06:12:19 +0000 (UTC) X-FDA: 83055840798.25.A829E49 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id A18731A0007 for ; Tue, 28 Jan 2025 06:12:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=d46jtVwr; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738044737; a=rsa-sha256; cv=none; b=ImoGsuozg4uN2ZfekHDMeRKjO0Gbg2VYoJmEkQvKlPLMzq9Eq7X4I0xuZiHgNVHEzAW1jw 22Szn7OFUQWf/B38YAikgcDFEOSDH75BLgrC9gdxpd1FBf0H67FRNxIs/gvQtigKPXMEWZ 5r5EOFO0jP6AFxh/P7768EKlGxhZWtg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=d46jtVwr; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+cfbf9602f4832848a96b+7828+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738044737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xpq0EzznBsykUuruz4uXaOlJN+LKQNMON88eEeJONJ4=; b=btC8gvXICjzao0mH7Rcfz9fksXlZaBTwGhsMxN9MIQpTTc9PCgcakuni/bOB0tDTKzrOzh 9Am10FVkr3q2HHmHtorKGARC+KuuGzffBHhjeT7OesfqXNMjkbtkgJGgwkAb68CG6eUWQa 9IbXzcC4V5jdrsUlnbjcnga5ouA7URQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xpq0EzznBsykUuruz4uXaOlJN+LKQNMON88eEeJONJ4=; b=d46jtVwrm7L+V7m3wvZM2xQGAk Q0dEQl6ZBqvJMmVNqAx+clFFc7Xy4ECPalPCgl1U/8zlKjtTjpa76KWpmBr8ACOHvEJFewwxkvgbi CDEX75YTHfqOclu+9RQenq7sOQkAAKQoGb5ncTOC2LHKd3kaaelhet5ACjVrRrGYW18SAzU2hdu7y VOeKjRJkMVV6gq6lCSwsH5NKrWX4/dDBneQx0Q34rrgXB36SZNWSKJAhiIhu0laSCYgbCnfan4GQd phn5CjzqGSXl/dYGOE7lH2u/OmOPCWcJyjgrA/gm8klELE8eLoY3nmrdKFHeIMv6ymf9LO2Srz6a+ 4t7y5oKg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tcepU-00000004C7D-0hfc; Tue, 28 Jan 2025 06:12:08 +0000 Date: Mon, 27 Jan 2025 22:12:08 -0800 From: Christoph Hellwig To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, zhangkun09@huawei.com, liuyonglong@huawei.com, fanghaiqing@huawei.com, Robin Murphy , Alexander Duyck , IOMMU , Andrew Morton , Eric Dumazet , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC v8 3/5] page_pool: fix IOMMU crash when driver has already unbound Message-ID: References: <20250127025734.3406167-1-linyunsheng@huawei.com> <20250127025734.3406167-4-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127025734.3406167-4-linyunsheng@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A18731A0007 X-Stat-Signature: jdm698hcrtx6mws69rkmgdhha4q8ksgo X-HE-Tag: 1738044737-653613 X-HE-Meta: U2FsdGVkX18O396qDQchQfrSyyQGzU+GQdoOZjwCPT3ZZ6WUL8OlVtxt+damEzeUyfKuxS/+J1YvdD9BFcggTUo/f1OPIj0ofQk9ILH6oMcChYmBqQfviyu18NEU0ZVxvCAQnWlmzqUihu72sN2w/ZP/eJF7FgEsnn+uLtiEFWWGwcj5X5S+9V9etE2zj0EvoIUPK7dgheIpBxjmqb1RVkY85lm8mdxnq7/mTN/fy2GM61nvqGEBCi6Wxdi6D1a+IzMp/m04hnXh0J7AlH2IJRsSe+3rochTCs74vyqfvggdUNjz8/CKFdMY5q+a+Ii9dAe6o4w6wuJcZO0L2B06J04XYTiUrCjzZoUIPVO6NHM+B7JirVodm/pV0oaNjdfDGxHgRACtP3acTkV7NuSA7cP4IgE0XGR0mk0SDZj1AxfwhoKk49TXk5rnxaIk+x4lN27uomw9+3rgFe5HmeqG9h1W7a9HMa1D9o7nbGcToqtg5Ud1oRulYx/ra2TlXg6FlDrFdxfRIY650LJU0lZUUrKuf1e0zSCLuCK3rCq6y9b4fN8nzccSXaa9ELxVzar+1RSmqOrf+NnOwloq578YpHDPOWfgs1eUNuRab/U+XInLUJ2eqYtzwvDdaCbM2n9O49FySrNfiLrp5X+LHahwv4vDDCt+zvBlN5RlJfVs+L7/Ey8v4D6uwYj26I0Frxp5K0PR6XE9rm6qZt+qFh00fhrf3v0tX7QeO9ur6SlAt6FA+faSTv//5Ctc1Jb+WxGmwsOHE8i66syUfEAmHHWeEALPp+YcVjkFFUQjvcO5oitzFqczSkPS8ERbHy4LgBpSdAhYNoGz+Qwt/9OZ8MN+5Wcg5h4GvbZSxf7iKTGgZeJks8CnmQHbJo3/0ZJIxz7qht1PA7OBTv7isa4DS3DNl7qqRqecsElOfs5rT0ddkTiH8ftgWvmynCQFhSPppPpj1wpGYZtHyUcK89zM7Q1 KTPSruXJ T9PcUcQXcfLgspSBb/SDvbSkFP8saU7JUQRt5MmI1PnKtidSFousda6N0MS4Jcyco62RDm5K5l7IcLz96S+DmFZp9vRiPG0oLF/8Nijz0oF1G2OQZNkiFk0v10LIH4mUGTIuobmT7HQbnzmfHMyo3Gb6HYp8yM7NJOo3Am0UQl73HluQt7TyTx6h2dMqTC6asxhtaOpNcSeXFb8WA2t6FzM2aYoDjhbyPT09V/MICOrGAHp2SmNEO2uvKe+EydnDZzU8mW0GahHWy1CD/tqts4ld3BfBr7Drh8yGpaTpvK3n2CAMgL/FzwELDyN9WfbnTsgRPCu6yYR65fIUlvuPZ9PAlrXFR17zHu6nfy2Db9CzWi+Eq2Qu19O7TxegW0NvCat/kxX8S0RqX/bVVPL3yD4766UjmYkelDo5s6/vl29LrnmLIJXU5+qOnE3FZIPSoEAPZuceLwJVOFinHaDEtGHzqpuuTsIF8h1KgOUCSbAKR5w1lIG6Lkf1luQNIDbEobsgMDw8NyW0nq9XvCO9d5vh/icCqT9ESyD/CdBCEbW2iuoZADhQwOFSb49qsOZmNDkJXunQ42O/p7Pqb1C907Y5cQEpvBqI7ME6N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 10:57:32AM +0800, Yunsheng Lin wrote: > Note, the devmem patchset seems to make the bug harder to fix, > and may make backporting harder too. As there is no actual user > for the devmem and the fixing for devmem is unclear for now, > this patch does not consider fixing the case for devmem yet. Is there another outstanding patchet? Or do you mean the existing devmem code already merged? If that isn't actually used it should be removed, but otherwise you need to fix it.