From: Christoph Hellwig <hch@infradead.org>
To: yangge1116@126.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
21cnbao@gmail.com, david@redhat.com,
baolin.wang@linux.alibaba.com, aisheng.dong@nxp.com,
liuzixing@hygon.cn
Subject: Re: [PATCH] mm/cma: add an API to enable/disable concurrent memory allocation for the CMA
Date: Mon, 27 Jan 2025 22:11:06 -0800 [thread overview]
Message-ID: <Z5h0-qtjQvhhLH6j@infradead.org> (raw)
In-Reply-To: <1737717687-16744-1-git-send-email-yangge1116@126.com>
On Fri, Jan 24, 2025 at 07:21:27PM +0800, yangge1116@126.com wrote:
> From: yangge <yangge1116@126.com>
>
> Commit 60a60e32cf91 ("Revert "mm/cma.c: remove redundant cma_mutex lock"")
> simply reverts to the original method of using the cma_mutex to ensure
> that alloc_contig_range() runs sequentially. This change was made to avoid
> concurrency allocation failures. However, it can negatively impact
> performance when concurrent allocation of CMA memory is required.
>
> To address this issue, we could introduce an API for concurrency settings,
> allowing users to decide whether their CMA can perform concurrent memory
> allocations or not.
>
> Fixes: 60a60e32cf91 ("Revert "mm/cma.c: remove redundant cma_mutex lock"")
> Signed-off-by: yangge <yangge1116@126.com>
> Cc: <stable@vger.kernel.org>
Umm, you're adding new unused functions while not even reporting what
the problem is. This looks sketchy as hell and surely is not a stable
candidate.
next prev parent reply other threads:[~2025-01-28 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 11:21 yangge1116
2025-01-27 23:04 ` Andrew Morton
2025-02-08 8:19 ` Ge Yang
2025-01-28 6:11 ` Christoph Hellwig [this message]
2025-01-28 9:58 ` Barry Song
2025-02-08 8:50 ` Ge Yang
2025-02-08 21:34 ` Barry Song
2025-02-09 10:49 ` Ge Yang
2025-02-10 8:28 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5h0-qtjQvhhLH6j@infradead.org \
--to=hch@infradead.org \
--cc=21cnbao@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixing@hygon.cn \
--cc=stable@vger.kernel.org \
--cc=yangge1116@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox