From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E06CC0218A for ; Mon, 27 Jan 2025 13:28:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83F89280158; Mon, 27 Jan 2025 08:28:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C656280157; Mon, 27 Jan 2025 08:28:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68DF6280158; Mon, 27 Jan 2025 08:28:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4824E280157 for ; Mon, 27 Jan 2025 08:28:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C9F1512013E for ; Mon, 27 Jan 2025 13:28:22 +0000 (UTC) X-FDA: 83053310844.14.9695B39 Received: from minute.unseen.parts (minute.unseen.parts [139.162.151.61]) by imf23.hostedemail.com (Postfix) with ESMTP id D45D4140011 for ; Mon, 27 Jan 2025 13:28:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=unseen.parts header.s=sig header.b=vxMygNh9; spf=pass (imf23.hostedemail.com: domain of ink@unseen.parts designates 139.162.151.61 as permitted sender) smtp.mailfrom=ink@unseen.parts; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737984501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lP0T7f795wt9O6cEneFd8O1nW/DjYKsbv0oA6g5csSw=; b=i98bsa5jVZRlrqohHt66C+6mgFRapx1lLd7fa7CdRnMtEYDPWVaYf3sgp5xRbp2NkQQhe5 HxxEHmKMzQNXxL8CDiJXVTAVd2+h3N6Wz2r9q7BMxNRk6+B1dzoGQpymKq/RHbLXt/HHcZ SJXEkd+sNmrsHO3nBBi15uybCMiSp/Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=unseen.parts header.s=sig header.b=vxMygNh9; spf=pass (imf23.hostedemail.com: domain of ink@unseen.parts designates 139.162.151.61 as permitted sender) smtp.mailfrom=ink@unseen.parts; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737984501; a=rsa-sha256; cv=none; b=p/2jemOSZuMWo8AgfUtriqjTx7Ge8UKsEhFm4aINvgL4U3cd7QDpxj2V8zQyxc7HMspRny o6U/paMx5QCVmsoKoHLfn9VvU8zV7zc10mi3eXuymj5n/FZMxnKQEB+PG+ZMl5iXp7c/pN p1RsChfl8ScrDkyJVA0fNxIjXEjXH3E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=unseen.parts; s=sig; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lP0T7f795wt9O6cEneFd8O1nW/DjYKsbv0oA6g5csSw=; b=vxMygNh9DcqVgPttcu5rOL5rma mKNKBGDokTrpImq9eHVt5tE+Y6DerEZvh1fQvwX/9MYb/hUzjVdOs6dZAUwUV2qHE8fMoOo5rXtpY 92uLIk3/0e8YWHLU85jiQt/vZ8uHInePKoQ20rol8dIzRcrms7HJnbXazvx4bFYo12PzDtTAmTWo3 5CWufywRDqlMjoXh+d6zheKKnV9npvIlRNKATCmoW5DspZpIF25YF7L46olFS1uYzkz+w54XeoAgt aBb0qnMPzrKKRYXhRzIFKMwz4wgXG9dYhOhJEChsZkC2SJDZ0MGp3ayzaw1QGy2bSqCbKGq6OKB6A amktslmQ==; Received: from minute.unseen.parts ([139.162.151.61]:40488 helo=minute) by minute.unseen.parts with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1tcP9g-0003AM-1p; Mon, 27 Jan 2025 14:27:56 +0100 Date: Mon, 27 Jan 2025 14:27:54 +0100 From: Ivan Kokshaysky To: John Paul Adrian Glaubitz Cc: "Eric W. Biederman" , "Maciej W. Rozycki" , Arnd Bergmann , Richard Henderson , Matt Turner , Kees Cook , "Paul E. McKenney" , linux-alpha@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Cree , Sam James , Geert Uytterhoeven , Michael Karcher , Chris Hofstaedtler , util-linux@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH v2] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support Message-ID: References: <82d33a2d-dffe-4268-a175-4536b3f9c07f@app.fastmail.com> <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> <2758fa70d237ff972b0c8d7114777dc4a20c8f3b.camel@physik.fu-berlin.de> <78f3ae1f68842a9d1af62caaac3929834ce6ecfa.camel@physik.fu-berlin.de> <87y0zfs26i.fsf_-_@email.froward.int.ebiederm.org> <5cff63bf0fc9e62772fb24bc919c591acbd10d53.camel@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5cff63bf0fc9e62772fb24bc919c591acbd10d53.camel@physik.fu-berlin.de> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D45D4140011 X-Stat-Signature: czjbtoxqprwa9qsckt1bt9uhiu1zhiae X-HE-Tag: 1737984500-244830 X-HE-Meta: U2FsdGVkX19lA/r4ybxTYsNjTjKecFPWldO/9u4vn08h5HB4wIDWsbqseGMyA2EN30pQ7l2eX8OT//uFdsL8+6VJfeLzV5At3bGMxuu3VQoi5qVFedAIPqJbkmdLobved+XJXvcYNocI0XYAhJTE+s/w/sBfkA+S2YvE4Bpo1H0P8L+7KoFLZ43CrrYSAQ4fvjyX0xWOJye2Le3w07iLbhGMlcMoFX4AofjmntgupTcASagrBJL/4spZ5c/uTNwMbFuvl/Mu9WGJTiCEs5OzrTw0eMPOY9I2S5MsuqaYKS3m6xNEES5uOq9srUQ66ITxZcN8Z5XJbUWFRHinM2qSGgt0SAxvDAAu7WJ3rp8imbfCzltFXF+pGR1Xv6k7OfPwMqdtd7bNfn/yLZDYtlrF7FBiTpvfopybBoq6xR/NsRl1tQ/+IzJqhz7x4qib+x6DRkkHkNou0tAUTppAHJOPs1zw6gne2S3I2debM/jFybRCcJI5OtnNfKxh/2/6q69I1RJNY5k2VOPCvMx9LFyd/ej1VopwfFN16eEcyzPWaYG66fSIVzcfTrKFpgaUAAcHiI1OWZ7BcVRaXGwsh/BmossLvOm9RnmOAT1Y7TDJPtVpip5UHmGURt7OQYqrEEMdeoDtHcKiWiRhQG2CgLsg48mSD3yk/RedsscZGUAIo8rQ4bUrAa0sEXyzQLMOhNyGzd/Q1c8yh+gyQYxElhHljMW+JjSnPZw4k/cLtliBKGKLE+R7J/iktY11wDdc9Y776a71wIzeNE6qZk+UK1Nr1MJb1Ltai7x8bo3iqh0z9106YG35Sd8duOREXXqTWcTcD22eVYOATHI+wOaDvqhzZnRzuOtvjZwY5onsWM1EwsODtHLIUuTpB+hK/JmDFksHKEWsr6/SojwcK/VScMEKtrVd7VWDidOY1iInFuTey8uCkt6oFG/Omlb2YZF0ckkxsXJnMdDEvyjutpEXO0J +c5NlVzd B4Czln0eh/OlCPIWJEARXAPunrKyXH5+fUC2GaPKlqzZuRauLC2cyYbiXp15/2TjOB22j/3X6Sa9O4dgKqI+LyqtFTWSiyhZwZ78qqQ0qM8LQB1W3ePTcTiyIHJHSwuWlRevDHMyMCdgrOdcQ8iEiYeRL8qLcz3TMSpm2k5JbPo99YTD9tzLpoIjR6Kv1X4qJWar3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 26, 2025 at 06:15:43PM +0100, John Paul Adrian Glaubitz wrote: > Hi Eric, > > On Sat, 2025-01-18 at 11:35 +0100, Ivan Kokshaysky wrote: > > On Sun, Jan 12, 2025 at 11:39:01PM -0600, Eric W. Biederman wrote: > > ... > > > --- a/arch/alpha/include/asm/pgtable.h > > > +++ b/arch/alpha/include/asm/pgtable.h > > > @@ -360,7 +360,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) > > > > > > extern void paging_init(void); > > > > > > -/* We have our own get_unmapped_area to cope with ADDR_LIMIT_32BIT. */ > > > +/* We have our own get_unmapped_area */ > > > #define HAVE_ARCH_UNMAPPED_AREA > > > > Just remove the definition. As the comment suggests, the only reason > > it exists is ADDR_LIMIT_32BIT, which is gone. > > > > > --- a/arch/alpha/kernel/osf_sys.c > > > +++ b/arch/alpha/kernel/osf_sys.c > > > @@ -1210,8 +1210,7 @@ SYSCALL_DEFINE1(old_adjtimex, struct timex32 __user *, txc_p) > > > return ret; > > > } > > > > > > -/* Get an address range which is currently unmapped. Similar to the > > > - generic version except that we know how to honor ADDR_LIMIT_32BIT. */ > > > +/* Get an address range which is currently unmapped. */ > > > > > > static unsigned long > > > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > > > @@ -1230,13 +1229,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, > > > unsigned long len, unsigned long pgoff, > > > unsigned long flags, vm_flags_t vm_flags) > > > { > > > - unsigned long limit; > > > - > > > - /* "32 bit" actually means 31 bit, since pointers sign extend. */ > > > - if (current->personality & ADDR_LIMIT_32BIT) > > > - limit = 0x80000000; > > > - else > > > - limit = TASK_SIZE; > > > + unsigned long limit = TASK_SIZE; > > > > > > if (len > limit) > > > return -ENOMEM; > > > > Likewise, just remove these functions. The generic_get_unmapped_area() > > works fine, tested on up1500. > > Can you send a follow-up integrating those changes? It would be good if > SET_PERSONALITY() could be fixed on alpha for v6.14. Oh, the changes I proposed are mere cleanup suggestions. The original patch would do just fine. Ivan.