From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E2EC02188 for ; Mon, 27 Jan 2025 12:51:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4364028012C; Mon, 27 Jan 2025 07:51:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E6EE28011F; Mon, 27 Jan 2025 07:51:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 286C928012C; Mon, 27 Jan 2025 07:51:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 054F128011F for ; Mon, 27 Jan 2025 07:51:18 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A7C52121ACE for ; Mon, 27 Jan 2025 12:51:18 +0000 (UTC) X-FDA: 83053217436.18.C2043BE Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf06.hostedemail.com (Postfix) with ESMTP id ABA97180011 for ; Mon, 27 Jan 2025 12:51:16 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=X+IRiLK9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737982276; a=rsa-sha256; cv=none; b=DKKNfPtgooR6Tt+RnRRjPPWdL+0d2Ya8VDg6F5qA7xG05r28PX8XeVUe7HgSIELSTZvumd Djo7kFAuCYQoaBtZo43BsAmJSJ/Bhar2Pqsbp0fNfm/J7qmj1U2WBUgA71tpTa6FPsJJI0 SFKZRD4Zt2w+nUkubDIRBkRP1zY8wcw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=X+IRiLK9; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737982276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3XC/99dq1lrou2LS2ZJ3dffAO/aKZGhjh2SSsK0BHGo=; b=giBMxBL1UYg5hnsVvhcObp3rKNG19CDpyCB7zzPAGyZDOIzHuSdMYrWBiMg6Jbh7Dm74db yeM5Y4zH38ZvKP6jfse8mOppL61mp61uO6bkWyHBGFmRxdJuYZlgfM0sjaErm1SS5YG5vT ox04lKD9cb1RidwTaKzYDlKaoAbWk1k= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-436345cc17bso30906435e9.0 for ; Mon, 27 Jan 2025 04:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737982275; x=1738587075; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3XC/99dq1lrou2LS2ZJ3dffAO/aKZGhjh2SSsK0BHGo=; b=X+IRiLK9FZYYsoe/VPjtnMq3OkGgX0D+Ay7dZtxATIer364W8hEqy5YyO2YQg2Sces a7e5yUgGQX5rB50hzkrILLNL3oeA3V5NZeF5oMow0XSVuk3YaYg9mvdNe6VFADMAuOTn 7+yCpSk9CHKoehmJA4hPP9LhThUey2QdpvOyK5r9H6Ys2/+e5bd8SpO5KMPRBSXTA7zs +QDsacrdB9felOlRkDHC1vLDwkP8ZfBmLoURlRvVp6sjXXwJj78kwU/X+7j8BBUdz/j0 jjrGLn7gMOtsaduWrE52x04Edc3lo98azTKMGn1zfgTuWGx22uQqJbyEeJSHYd9AOB1D HPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737982275; x=1738587075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3XC/99dq1lrou2LS2ZJ3dffAO/aKZGhjh2SSsK0BHGo=; b=O0ykzPPdGSvAIkEQCfmFDAJPGv0EzeG8xxTRb4KBV91HE1YJ7c3TB+GV6uDhoK0oMw pD6sO6JOeSkcvJXQdYJr5tCaGJyoBoYreEZJNVsqquMVU7EDRpQr1ZH0c1v8B7oqj29g qHeCm9/kJSJl+SCsSlX+zc5ab4lnsJ2+sIuRBGnxL0mmuMAwqmR2qcDJaYIQpDyJyTLp IBTNFavF/EDd0LJ05sSMNR9XR4uv7xDfOxAu/tYK+z2JNJ9Te6djXotS1BzR8R8nvl7g uw0XYjoyfNjHFo0NX67YDvm6ddxpNTAoc/sVhb1mMBs7calJ2JX9KrARj/UTfZGTmOmF A4UQ== X-Forwarded-Encrypted: i=1; AJvYcCWOBwQbp9uFggkSNWl6A41qEquKIPXVKdsjJyNw5tid3CDnajzad+ZKNrmE420YY5k4rbfD26iJoA==@kvack.org X-Gm-Message-State: AOJu0YxCWFLc09WJgJP/KoBq41N7lMSPt2TEf6Bi8KtQlLNywh77rGq8 lN8YrcjrOYFCSd8EtTTHGbypmVKKU0D1vKgfOxpw45MjmH+K8AhmUa+H4iGN6qavcJiztWhPShG k X-Gm-Gg: ASbGncuoVB+sYVI7nzJyIudfJ+PtM41YSB2eNONaK8elplOzw88+SohL+/CaQiTAY0L pETE1fIvkOlXJRb9Bsc2A3CDn7KeyOxHFuAhDrzVZ/bJZlIHJhUt/KMSRtnKulYM8D6l0reVhyV uQBgCabqURe8fpILH0suQTKBmxmOLq5LShm97KPUzbUiW5gtvKU4BLyyx7/8mO0Znyxx1VLOi48 bipMNOEkGKl4PpWb00ZSiZvdJ1bwQFB0NkOxorU54euE/xn7azD8rE1sgSkF1mvDSaPfDdSyFpx 8ZUiViCj6irGZis= X-Google-Smtp-Source: AGHT+IF4Kt02Q/0kEbozaDJV0Lx8A5mxbL6EzlNqnxXWIcfSrEM3JTDfXIFJXqwKCG+uMK8hkQDu2Q== X-Received: by 2002:a05:600c:1c93:b0:434:fbda:1f36 with SMTP id 5b1f17b1804b1-438914299bdmr350861705e9.20.1737982272299; Mon, 27 Jan 2025 04:51:12 -0800 (PST) Received: from localhost (109-81-84-37.rct.o2.cz. [109.81.84.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd485695sm130149475e9.14.2025.01.27.04.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 04:51:12 -0800 (PST) Date: Mon, 27 Jan 2025 13:51:11 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Roman Gushchin , Shakeel Butt , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: memcontrol: move stray ratelimit bits to v1 Message-ID: References: <20250124043859.18808-1-hannes@cmpxchg.org> <20250124043859.18808-2-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124043859.18808-2-hannes@cmpxchg.org> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ABA97180011 X-Stat-Signature: 88kqgwyfigg98zkkjrjwt7kk7dyxwscp X-HE-Tag: 1737982276-361722 X-HE-Meta: U2FsdGVkX1+aHN5TJbzxZRhwenrATL0mny2OW3JQeQhvwQYLZcgBvVca6TOEhngnGHLCblkoO64e+j13ed6sWh31+y1KVRmvTL0eJm7s1dUBnsxVAT8kTWlcwGhHu/ATzCoE3TVg5Y/DhN/Teqv3VxJI/d5powm4cXAsKdzCsNZ9fHnZmya6Fcds7R+TLoJnPBqjg8hyYcYzKovsmNeM0l9e0T9fC7oz0UU60Y99s49mOchhNxw6uxpGUVNBMCilItLIbQln1TTq3g8b4NCXLG2r/RwAp+PFO/eIY9d3bKYtODndanFmOr1FEHVBQi6L8/PCjHZDuaZlbxDS27B7E0Xx12brz9jXe7d+p/PeqeauIY78bIOuFqwz7I2OMQ92gNMZChv+qXKvUXQh3nlZR0ztz8sFM4+cJAGBMiGdH362CTBIl+HsE2H2Z7dbuh/MfBI9RHXtDB9rPAVaTxBntmIdh6ILSHasBDf2tVIFDiQQqK7lZ9MIdqXKZw9i7uxMeZ18Yfks0xGjSJOFk8Wyc+XiEYHNHS7rpbp4xBcYy94a2VYRr/aHKBw3FO/is41aaowd7lXnB/9TWoL/cnPKG0WRJvdLo4GSBL602DwWW6xES4C13dg+mvHBdwqZ4hkNmwHF+hQS/j/1f95v+j+wYBCmRVuLI6SokEfHoLyP3skhP0f3BV0vOyWVk5p9ZyAmdLS5BjTB7BWPEXAXKPpeg3oH390vshC5/ykYZIQ+onUrS53jFmRGIS7ZXwniT5e/K5mzFAO4B8OLCSuyAQWt4+GTjzejm8v5fcRJ49lfNys4Iso/ddHCAEqKvFnuGfWYEGUUJUoVLRUKi0Ruu8xakeT5RVoZZxjOzapvLtA3Fh9AxAQfaihgwkDU8fwe/6KmR3OHv1KRTkugBBqEK4BNt6y+DIoBokwtmgH0iwB+M0oH7JnHe1vvtHeQa8bAcvTc7W958SeSR0ppMjb3q1l pezWbHdc SgBGS/3aEbWxKno9kjf8a7uPg9JGZLJ5pVgvnZa/ZgbtoBp8xT0PknkWO+1BbP9awslK2z7eTQOCqfBDJ5BjBQ5pxfnNQpaxpeoXLq4CclQaL/tyYZnrA9vkkHyTe44pDknUTZOQjvhqAXKWTfpzrRf+1YeiWQcAL9xfkJhw1ukOpeVwMFei1z++qlI2r2e8nwQNtCD0hbJ/Xm/e3qFgHZjvlvLTKrXs33kbYIXsL8fvjTo0sfRsoqc/fceLMknGs2STM9cBheKHAOPLAGpBKWzdX8yo9+Og411B443kNOWHhQj8scS/wpbKAVenatDqQOfu2PKFpomK8HgdDXLEtnvZU4oQGw7ukvdXrrcUH3jZlS3vm9/+K7pjpBa5TLOc2dvZoCXT/IMG9zscNeKGXme7SHRxxHZEuGJO/i3B/34zrTOppeflKRgKmB1O3kbCzWfZIPxdcYI0igAt0RfHRidmjz5Z+7ESly2jt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 23-01-25 23:38:59, Johannes Weiner wrote: > 41213dd0f816 ("memcg: move mem_cgroup_event_ratelimit to v1 code") > left this one behind. There are no v2 references. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol-v1.c | 13 +++++++++++++ > mm/memcontrol-v1.h | 12 ------------ > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 2be6b9112808..6d184fae0ad1 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -490,6 +490,19 @@ static void mem_cgroup_threshold(struct mem_cgroup *memcg) > } > > /* Cgroup1: threshold notifications & softlimit tree updates */ > + > +/* > + * Per memcg event counter is incremented at every pagein/pageout. With THP, > + * it will be incremented by the number of pages. This counter is used > + * to trigger some periodic events. This is straightforward and better > + * than using jiffies etc. to handle periodic memcg event. > + */ > +enum mem_cgroup_events_target { > + MEM_CGROUP_TARGET_THRESH, > + MEM_CGROUP_TARGET_SOFTLIMIT, > + MEM_CGROUP_NTARGETS, > +}; > + > struct memcg1_events_percpu { > unsigned long nr_page_events; > unsigned long targets[MEM_CGROUP_NTARGETS]; > diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h > index 6dd7eaf96856..4c8f36430fe9 100644 > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -28,18 +28,6 @@ static inline bool do_memsw_account(void) > return !cgroup_subsys_on_dfl(memory_cgrp_subsys); > } > > -/* > - * Per memcg event counter is incremented at every pagein/pageout. With THP, > - * it will be incremented by the number of pages. This counter is used > - * to trigger some periodic events. This is straightforward and better > - * than using jiffies etc. to handle periodic memcg event. > - */ > -enum mem_cgroup_events_target { > - MEM_CGROUP_TARGET_THRESH, > - MEM_CGROUP_TARGET_SOFTLIMIT, > - MEM_CGROUP_NTARGETS, > -}; > - > unsigned long mem_cgroup_usage(struct mem_cgroup *memcg, bool swap); > > void drain_all_stock(struct mem_cgroup *root_memcg); > -- > 2.48.1 -- Michal Hocko SUSE Labs