From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA908C02193 for ; Sun, 2 Feb 2025 22:06:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0961A6B007B; Sun, 2 Feb 2025 17:06:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E856B0083; Sun, 2 Feb 2025 17:06:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E017B6B0085; Sun, 2 Feb 2025 17:06:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C01306B007B for ; Sun, 2 Feb 2025 17:06:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 52C9C162118 for ; Sun, 2 Feb 2025 22:06:44 +0000 (UTC) X-FDA: 83076389928.01.F2A9926 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 31AEF20006 for ; Sun, 2 Feb 2025 22:06:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tAxAwQ7f; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738534002; a=rsa-sha256; cv=none; b=TLrGPdQoHtGK+Yf09SRw6ru3rsVbzGwXdj9oLPiwEKxeEC77lnc32pskR7uSGEQMaVeZfw OHXV6RaDy3hwg7ShXmlgsRIlaUlwIPNXljGiHPz1UBaLn0gjoHd5qxH4udAjKICrnw0Ktp oKQydrE3zKu2b4nfxqt85Oagfi8W+/w= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tAxAwQ7f; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738534002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28AmWbhIQ3UGJuXTTzNuIC9DDsHHl6ngoKmde+J/sY0=; b=WU1FzfGaasYWyXeWhmAX3tR6knpZJC2wlbb0E+61ULP9snQZaI9X0HaXlk/WJ4BVCscf8H TvtwFKFHUSmEJFg3fvBPC/gqW8EE02Lu6jBVWPMVzSvmpvQPACZZ9dxsXZi5RcIqDi7JYJ M5roypjdjeY5UdsXl1Pz4d4/tl5OUe4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=28AmWbhIQ3UGJuXTTzNuIC9DDsHHl6ngoKmde+J/sY0=; b=tAxAwQ7f+vB7h1Bd9xGVWNcHE4 W8KGQYhKgXx7ZTTwnU7DNiWIzbZw8e+Aam64jTGIl8n+2WkvRL2wv5hiC5Z005PzpU5T87oj7qLJ+ As8luIGAMRmuPdrCflDlfYrLlQ1cKHcTdx26gbuhpH7nz2qPEZtc744yWlN227Yr+Y8k9KB06kxBL BnDZg0eBxzcwnd3B9DQAT423S+83U2XdauN8px2QIzSnS50iI89Ki0LhyfmW94heo/112C9zn/pL3 ggp1Y5nB9cD18lN+DOTybb6up+D6RhAGZDOHkXOkBedjzyJifoGfBj533BIy/vplcp013Sd8NdHJG sVSCAj3w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tei6v-0000000HXSE-0btS; Sun, 02 Feb 2025 22:06:37 +0000 Date: Sun, 2 Feb 2025 22:06:36 +0000 From: Matthew Wilcox To: David Laight Cc: Mateusz Guzik , ebiederm@xmission.com, oleg@redhat.com, brauner@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 6/6] pid: drop irq disablement around pidmap_lock Message-ID: References: <20250201163106.28912-1-mjguzik@gmail.com> <20250201163106.28912-7-mjguzik@gmail.com> <20250201181933.07a3e7e2@pumpkin> <20250201215105.55c0319a@pumpkin> <20250202135503.4e377fb0@pumpkin> <20250202204449.77cab5e5@pumpkin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250202204449.77cab5e5@pumpkin> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 31AEF20006 X-Stat-Signature: 5cftkcbakn5a7h3q64fe8ock1xa5msic X-Rspam-User: X-HE-Tag: 1738534001-728572 X-HE-Meta: U2FsdGVkX184TwuHErUGWgZ4XlQLXO88lMDaZz2ylM/4nCzDDz12KyzWjjIs20b4YWfQT/d4e9zYkA8riyAUEEzzSUttdRVGPTr4rl+U+/FLCLSxXkfsvJrWer6jmwn+hnm1NR0xVau2r7DxuRVmWDKRKevx9Z52RtDtFSIQMzHV15fCbApKxWrUq7H8XqSpl88WCMoC/us6oTCghH6cTUs1IU31R/7A9sESCTGBscj+T7A8bN6sLcYk9I1/BTaK1wKadIgYzERi6qaoYeANH94l1iyL0j5ppVAEDeZp+NQAyXew690YFKh9nvWXXfo9vB+b/hDW15PyyWQPVdFTyqVcAqzdMr1vWcGr2JJ7TQj2sGqELpFkUm9PyBj1L6EKBiwoBsrTd0drC46mP/aefZY2i0aIZwLeQHSQI7hMcWL/6PCIjOomNaCyhtR/8cSl6yr8fetU1Uh/Ga0Hek9S6UfwY7+JzjcwRyrqjYg5jRTfIFWRn4MGpxGTu7Ov3Cdgl8rZXJcP2WjSTbDw/FLfrWn2qfQiTwR4PLFAqPNDjm+YGnnwPnT0K0nmgSSPAdY78vvtsXwf+kxkaAXfFcg4h79bcLfVDtZNDEfUWS8SOCIMrDN3RwKvj7yVf6csoJe0f/zosabhAeKWXFt4fWUQnWrn0y2uW2DCYoVkNSPwLEDL8E/3dXlXco4jOhRh0+u0SYnhIbY4YlfJtct3+tR+YO2dD6+G+P+raGzob5Da417CSkKlriktJ7hIynHsEDHv8L0lCtwLaPr/tHFtDwiSzUqn38iWhaUuGbwVPKQ4E8q4RVI5QvpDmndBglZ8K/zI/4mtvCkwWq3baIFA4aJR1QfT6VIU/xZa/Jsf9repkWTzIPBDN/JjOmf5+qv+2RGuLgB4q1astG3KBVZRFO5CqZ3Njk9gHqRPui2GPloSfIU4HrPBVJflYRj518oz1Taajsu+pgOKFvyGuURLMyh bUsXyDur 7xSWbBOmEMq+4B/a6MzDaKkw3Gi33HqVmTrGTukc19L30cZH1Nsg59mk5VTja8gwPYIlW6/GWtlaCWjFP5F7EZdAOudd+VKzj5pKHWYlj8YNyp1kwLbmEoZ5DLjlomXtfFduYHKNOEzZh6BridRPNhe3ZXX8bg4Dtxrd4pvIzmsHwaGNzP2DBPFWGnEL5Is2UJJzySxWLMsTPnZyiwmyzOOyMLVXSzfy+8cr7SXeHOe06qRYy2wtn+U10sPeDHt5Xfr/7ehbznMfHccqosuDnqjg6kNBKOiLxqWAUd6cLRuASKXW7+IBNsAsgaW8NJL3HtwhIZBKtT44Ufo6WDcpwMCOE3grws2y3umCF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 02, 2025 at 08:44:49PM +0000, David Laight wrote: > I really commented because you were changing one lock which could > easily be 'hot' enough for there to be side effects, without even > a comment about any pitfalls. No such comment is needed. This is standard practice. You're the one arguing for changing stuff. Have a different conversation separate from this patch.