From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3A8C02181 for ; Sat, 25 Jan 2025 01:34:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EE5F2800CD; Fri, 24 Jan 2025 20:34:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29F612800CA; Fri, 24 Jan 2025 20:34:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1654B2800CD; Fri, 24 Jan 2025 20:34:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED0712800CA for ; Fri, 24 Jan 2025 20:34:57 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9A66A1A60 for ; Sat, 25 Jan 2025 01:34:57 +0000 (UTC) X-FDA: 83044255434.05.780C03B Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf21.hostedemail.com (Postfix) with ESMTP id E00A51C0004 for ; Sat, 25 Jan 2025 01:34:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MGywh6KE; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737768896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tP0/o2PO7Vlf1ziXPu1JIk4Vi0ELHenKxZqooG+MQKc=; b=LEFxrwmSX0kG1AteCgTRLt5vEzPUKrqsAt2isOI1LchGkxAVKcNevOVHGAdmD90pWBdfnD 7sbuiQunbl9/IfgMRJOV6/OBulwPS06/a6+jKO1hiGJIaP3hOuS9uTG6lB+q5pIgdUL6Qb eiD0HHF/iUkZ1Vxx4W32KY7Rm9egKYo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=MGywh6KE; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737768896; a=rsa-sha256; cv=none; b=KjGCqqtf3PgERcPGtHnNPLllz1oPHWX6ennpp2gmK2lwdBkVSwjmAlk1tteTHSWzMBd1rZ aPqtVNKeMjo32PeptnCIGmqiptGdo+dhJvvpSHPblDf3PDgCzKvEUtobH4QyN+e08Rlj51 vcRnxRr2JC1PEA3la2X76C6K7kLPXgs= Date: Sat, 25 Jan 2025 01:34:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737768894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tP0/o2PO7Vlf1ziXPu1JIk4Vi0ELHenKxZqooG+MQKc=; b=MGywh6KEB/cvFLSpSvInQFwTVWPF+jnJvJVLpBXoKbePVMksitrAppoZFl/xuSQyw6Ee2Q ZlcUFkBVzug4O9Cg3RL0dHtDxwUdm5FK/jnYr5IOr+mmjF5NByE/oTfhtju5aDkA0Z8XVv RXwFX6rQNYpka+6OlwGzZ5qpxeaTYXY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH -v4 next 2/4] memcg: call the free function when allocation of pn fails Message-ID: References: <20250124073514.2375622-1-chenridong@huaweicloud.com> <20250124073514.2375622-3-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250124073514.2375622-3-chenridong@huaweicloud.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E00A51C0004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: m19d795g7oar1p9yb6fowk8sr1ia497h X-HE-Tag: 1737768895-113644 X-HE-Meta: U2FsdGVkX1999TkM52f96GWIxdkeYb28I1vsZZtQB41jj6ruVDARtNBwwfjL7kv5xm8ddgm3HU14qK1nBzQ1Xsl8swUGN0hKaBAwP2GrY0kSj241woUomIfMxvlM6rAcoa7/F2bFdCMQupwTTKrJwn4htiYbFosKEh2cxPabGujhJG+439hM/Z+74BBXE4qrbZlM+F9gYIanM25OAuekJ8ypEdKCIv9s2b73E5e3thNyXAjjShbWbSYxMzlV5IEL3Dezo8p86CwBM8A8MR3N8Vb68PebxJ/biQDB78NkTP/khvCZgpyuTOCpRqOSgswQfXyi7jqhmDGhQuKotk0YmzGr7lvAk+/2A4CG8+nLZyBu/SlCqzT3D9IkU8j/JjvDnteG8mFJNlOa6u+vakllsLNGdZJGc7ANgt8pAQYdyhhWHOENhfvB6gO2fPvyxq9OwxTvCd93r4A5BiSdiN18VdvNaIe/NHelVJa0t3UgM1vdoB9zrjCByH9YBci4rvCfRKW+EEdXK+gaxy7/5AEYPcfLFm5sEtTEdBO/RUxBZkdiEsKCkb9AQvXjriPKoGST6z/CNjmTJuD/VCpC9GVTlrRhyEupFQzE/SqPllnO2mGLTFydyI+RQXRTJz6r4XOd4lqTsUXeNdq/J3boeaepMDTtA4JeyhuKa+NpU9UWjnJCZ2QYae8nm0FgEiCaXapC/YTDux31CWYdinx8qCC2j+gtgDAGD3F3o+aH2n8Cb2Wz5zLmol9DJFYDw6MuEO59MWsEC2EVOVp+Rse8QrRTIY5Y/JR/EXfuRm/CyA6FoOqvlygBe7+VObe+Z3iR+KQSCxLLRo4yG2NK3Y8sqfM3sYZtN4SDlhpO/czDZpGH82FuGuqmp/tnvXifTECI5w2yQ1sgtBA+/uqux/QNpMvCOBHG4+cUTJDVGffrIuftqWSiA4NdszYktKNelflM0+UvLWh9wrIWN5cBES5iMjK QW4/HHOc JJ/j/ugUVWkcm9lyBrtxGzCSyX3Ap6RxPoOFtSU4K47HuvXujjYGVlWp79mUfdCOyoO1lXkWAIS81buvwrTGfGOA7Rw5E0wxg2ahl5zkXUArxJR+dZ+xDYrqo4ggC1DiG2Yz8p3naMQVGIg1i8fgVFrV8wzv666mGwTF4wiG6HCJSfhdSKcQNay9dFG0HE3cCcZPTUyIWiP3mpy+2QoiJ7f38cpAlNWY81r0QSjFDPqk+bD+9KOpY51YsU3ajyfqXmi35W0ZTo7t3bHHZKEd5ZQVF+QrFi2EvxOSrwEZRlDlMKFC3RDCCb8seMry2IXoMSxSAJfl/YHs41DSZ9uDcabDU1ykPr+xa4v5C3COTgQHEeR/MnLZ7CbAZlO9KL7wZB0u2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 07:35:12AM +0000, Chen Ridong wrote: > From: Chen Ridong > > The 'free_mem_cgroup_per_node_info' function is used to free > the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the > free_mem_cgroup_per_node_info function will be much clearer. > Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info' > fails, to free 'pn' as a whole, which makes the code more cohesive. > > Signed-off-by: Chen Ridong > Reviewed-by: Michal Koutný > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner Acked-by: Roman Gushchin