From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF960C02181 for ; Sat, 25 Jan 2025 01:34:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44CEF2800CB; Fri, 24 Jan 2025 20:34:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FD252800CA; Fri, 24 Jan 2025 20:34:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29D022800CB; Fri, 24 Jan 2025 20:34:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A2B32800CA for ; Fri, 24 Jan 2025 20:34:28 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D64D0120D1D for ; Sat, 25 Jan 2025 01:34:26 +0000 (UTC) X-FDA: 83044254132.15.8A97699 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf18.hostedemail.com (Postfix) with ESMTP id E53851C0004 for ; Sat, 25 Jan 2025 01:34:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kq2Svp4S; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737768865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HnQSr0YFLguPEep0vRgiXOdtVoxbHdXDfcgj+omvXAA=; b=PEmTUb7L0vulHx1zLHk0Co0FQ9h2IjfMv3Z3vdR+dottjOFj7RZNrE1emO4eOJ31+fVM/z mMTr13gfBC7nF9pGvBBGPH4AqscR9s6n+9yYMO5LDe9o6Fsmrmbgbr7A6WztcJhhO86j3i JXJHPQiVkc4XeRloEH/qySCQDWFwDYE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737768865; a=rsa-sha256; cv=none; b=tQjRnIB8aBEQQ6s+4+sKwU2DXk0lUnfyQB232DXcploCDNpxHLXf1un65GheLGbcj0B96k lRhjVuwr0uSfQPwxrivlVkSq0E8Psq7CrwpYh0LLRInKt7NCZAxPkNUf7SgeLKlDTqJiaO c487EZ+WH0hGFLr4v0OGYFQjMygZhVQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kq2Svp4S; spf=pass (imf18.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sat, 25 Jan 2025 01:34:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737768856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HnQSr0YFLguPEep0vRgiXOdtVoxbHdXDfcgj+omvXAA=; b=Kq2Svp4SkXjzU8DBW9FfS+o5j337+HvmCJvLUt8Ig7jzZhHD3AFxQ7UKte/t/7q2We0n3h QAhzicrFEusP/bGsqWYLGB6TU/FSzYVTwMELawCnkKFcelp6ABXTgsA1GZoOxTbJBU65zu E19W21tYYij1pUUyWrMBUdHDEJxqFlc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH -v4 next 1/4] memcg: use OFP_PEAK_UNSET instead of -1 Message-ID: References: <20250124073514.2375622-1-chenridong@huaweicloud.com> <20250124073514.2375622-2-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250124073514.2375622-2-chenridong@huaweicloud.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E53851C0004 X-Stat-Signature: 6a39cykob4ig835a83upjjbgwwe7s1xb X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737768864-988306 X-HE-Meta: U2FsdGVkX1/ttN285cdF3KCPMwgI0nriVUtRu7/y+/2ye6MPDGB7pKduXcILkywFLJWKPul1pGQ/CmJbvPjETGZ414NOLGv133oWrugESOec2P+P1GRB8jVAjS+RZ6IWZnNqhHaXilCIqmcuIflpDklH4iVrb4bozVgfrjKZzabaMA7BbuE0wbFT3HWf+R9w5HtxDR2ZEefy0W6axt/86nrR/zs/cDWUlJV0bxzVX+51PCYgsOhPE+PsAGZ7eggPGM3jbdQw+Bs0BXGwQB4OfE1equY+vc2FKwdRKUQqwBhq/g6ehbH+Mk92duzrh3sya7quc0OK0FgtdlU9L+lz+OZe7V6N1CfFGK4cj+3JcS8m7NAtg1CE4gFt/nHj9j7owrPfL2/d5MGiuK4NbyD4bo5/JXhqQ3VzlvZKFha2SY5Plrry5gUSltg2iNajh0UBk5ouH9owGp81MpHW4QzMceMY8tNHpe1T0Z0PW9a5HYBzZn2EOuXVeyThA79okhCw4ZiymtwLs4UAXDvN1XUk2ODutrbijZl6WNl3apSOnrwWXDud5JB1OYT0T7v49nSTcqM7inj+ev0YM25gjLCIpVqmCOiElnDC1CrHEC7Vwdpdr2vshF/vFSFoOYn/+kV5v/lAc5CnKquNUHWM+19BRaTL9I3k9bHNNKoge774g7AtFLcCjOFniSSTUN/l83ghRjXQ5ZpIWv5pClCIt93wLxwgZE0TZfLqBQ4feFgJXwcMxDZMRwofvn5zB1M6OyZLYjOPVfIXYlVP8lDllklGD9VNI+lcZhYfHpvwhYQ1BN5eHcLcg6oObkTtIlxQp8kidC9E0D0zeVJ6zDC8vcKCJd+gIQrdxiyVUufDbFP0oiJNMygLQPadcywaQ53AptOkVFvFeyosf/3X+EXTnaKrLSl4zbki63PVwVa9REHTxzgJD0MbKoXv6DoCLkIeqVkYjFyiXQSlx3JtIJIV4wa vpfAYe+e QwaeYFokg93UM82LrJDULhxopNi+AaURluTPHqpVciSdcZllSNGg20IeqCPh0vVHevOLjmLOWlJrq4Pd+zVm4rb4D8+DYgtcFoXRrzIdSjLCzAHJLkM5Fl0OwWif4Z0PRcqfvD4lW2/F3M4K9qpa0tDffVi5xgusWUtWO6D+eygTqUVKNZOD7hmetOjrI/BXnCMvBtoUOmurFRl/V4ZlcDXuk9BRgpU1v5wqOR28IMLPWB3MZJOhG/Kam8UDrYcvWCg1vX+wk8TVgjHcUZ40C7aASfLjki1V+OYidg78TfIwEabeWlGr1yhLL6hrZNpryG4An6AosMUFPIQ0UzOlJyUhH3mo2xHWlxfD7JikSiL415rPrLazNSCMwRTQ48pnUrJG2kt3FWmOnjv8bun4IkM+RHta1xz03pl7715ux4owTUBlAJuazfa57hqZX16XTd2xmNbxRouTPsvs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 07:35:11AM +0000, Chen Ridong wrote: > From: Chen Ridong > > The 'OFP_PEAK_UNSET' has been defined, use it instead of '-1'. > > Signed-off-by: Chen Ridong > Reviewed-by: Michal Koutný > Acked-by: David Finkel > Acked-by: Shakeel Butt > Acked-by: Johannes Weiner I think I acked it previously? Anyway, Acked-by: Roman Gushchin Thanks! > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 46f8b372d212..05a32c860554 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4004,7 +4004,7 @@ static ssize_t peak_write(struct kernfs_open_file *of, char *buf, size_t nbytes, > WRITE_ONCE(peer_ctx->value, usage); > > /* initial write, register watcher */ > - if (ofp->value == -1) > + if (ofp->value == OFP_PEAK_UNSET) > list_add(&ofp->list, watchers); > > WRITE_ONCE(ofp->value, usage); > -- > 2.34.1 >