From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E64C0218B for ; Sat, 25 Jan 2025 01:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 690CD28009F; Fri, 24 Jan 2025 20:25:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6415F280077; Fri, 24 Jan 2025 20:25:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B9D328009F; Fri, 24 Jan 2025 20:25:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2D798280077 for ; Fri, 24 Jan 2025 20:25:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8DC161219D2 for ; Sat, 25 Jan 2025 01:25:53 +0000 (UTC) X-FDA: 83044232586.21.9341B6E Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf16.hostedemail.com (Postfix) with ESMTP id AF0EB180009 for ; Sat, 25 Jan 2025 01:25:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sthD+b9q; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737768351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwT2PfcNm2ZOJaOk7v8Yc0w2B0zR2NQznrVcYeb0C6g=; b=Mipm/gEYYI37jirzsrCcn1n6tG+CC+4XG3/hBXcSLJbyKEtaLmEvITg4GnG+Q1V8XJb6l5 CDgIC7EqtxTCYeEl+pj0ZaRWROz77Udn0S/8Ms7DkRfO56VNWDtqJb0LQoo8q+rRt9Mt0y wpnWyaeyjZU8kW8AI4f1t3158S5KoI8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sthD+b9q; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737768351; a=rsa-sha256; cv=none; b=1uLdNbn9dokpiHvR8+06AzaFgKZZireefOs9UD/s9HkNcrt/Wu7eR1eKZbWEvgux6XEO7R euRFCiliPMAbIM3hc9r1gIDHglMXA2SUG21vrLmb4vKld0QYuAgWYM4+m5mXBlbMHFir4L XiJqK9Un+gpCq6GUR03oPpffG2hWODI= Date: Sat, 25 Jan 2025 01:25:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737768344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KwT2PfcNm2ZOJaOk7v8Yc0w2B0zR2NQznrVcYeb0C6g=; b=sthD+b9qbQ6ArrFYLQ9WBZDPk1WIZzbEZlS2Tg3mCmxwq/EzdaFCZSRr4ckQj6xT522qm6 ROl+XT3XwgQ842YGgTu0IG7Px4nMHBN7XPNpWgfr9jRcaONWKKhacX7HlL8lv1w1Vezvw1 RtJ2/bul6aGeiu0tXHNroqbqnBQkSh0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Shakeel Butt , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: move memsw charge callbacks to v1 Message-ID: References: <20250124054132.45643-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124054132.45643-1-hannes@cmpxchg.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AF0EB180009 X-Stat-Signature: p44emea7cdt7dw519xah5ixbdmbyde1h X-Rspam-User: X-HE-Tag: 1737768351-530642 X-HE-Meta: U2FsdGVkX19LF2LLnv4ykgPrKBOvpK+TPjn6vmekoZCCHG+dEzywXkAMY6ZpEi5B2eKCJEntnSDRbUzW/UhGhj8oDGylD24H4Cb/6f+Zw/4yiBbKj8tXT9CiZsMcBkyITYSX4AvQ/jXuQbZXjmG7AvGsjgb4EYDMe44csQp0+VgNOLhkjDEWFYSSyP9Iuk8aJh8HK6qm1RdFIVUmSgoZysUZBuGO6JzXEXhDCs0eu4yGNGbfoZ2u9W1NItImw0zDvXCr8/TsstyzuTNaRELvJGrbwvMGvNzNIM1C+/K6+PFnU95pA1K8pyV4Kw+BxrT24YTjGxgq4NLt8+LCoKTe5UWCWVPEGennc1tQmQetH06pimmG/4c4tOOSx9y0FR5YcXRoqLz8pLaGyC5aoBBFnNbXtWu1UiAAp9Em7HFj9BfmPz6nNjOkhivf6irMNIssCQO4Ut9ADv0JGasM11T0oKRaLMo0vcc0dXmxck7dDV9WURBMgdHVImnzmSBZgB30OaL++4ha4iR29sB2R6JaMivLLc7I452VGVwnYuEJcmL/eHdUJuGguV3+p+tjM3xA0x0ErDInOww6bMypfAHcrxQMuhAPDkIBr1fMwkFiLCdQmlu6Y76ifAYGmPL9Bu+t8uoBSbWPiBVVrl1awOukrqMpJ+qC9HwORbXSDzFNdLh+dtQjGAmo0AKxlT1qoYa3oJ83tNGMdV6OgnGln2xyHY5r4n77ON7k3TPWGnVIZxdNjnegfOJdiueKedqFGcJY3ButYf3NyRGEOpfddXrUym5624xylrVn9qTVyOaYWBojI6FlaJY/lfwjw1eQovBKIxR29Y7xg+J7L3DOumBoAgJOp9u3i5+FYpGP9cIY452nEYmUlPHndLLh6NABStYvD5CFgGYCzKpsFwPFcga0tSY2plmFARH+58WIREVEgYjbZUQW+l0h48vVZjeGdL1xSYnwbPgPGOQsUKo8+z1 43cl8n2P RG/kVoJ59IldKmpt1HQWHe6NX5T5W17lH9WyE9TVnOXt8iut1YJRZvbvRK6mhTzXJZl7c4fIWsaPfCmvw7OOCaByUzuOBnkZFZCBu0ggjjbzeN780gGVJP1GLIuiL3zw3sfOgiTC0q/OZdSnYtuFwKCoMdy13hJZGBRRB9VO0Ui64lg5JrkFU2ptujQC4dJUSx3O2rDHKgbeiBdqfedvCee+YHYfHBjoYI+IDKbglRzaqlzXXgBWYn42qOWITJMzCnXJAbtFWgH0Oh5nrSSFQWeH9btRzcpZnF283aBrQQCe3+Cw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 24, 2025 at 12:41:32AM -0500, Johannes Weiner wrote: > The interweaving of two entirely different swap accounting strategies > has been one of the more confusing parts of the memcg code. Split out > the v1 code to clarify the implementation and a handful of callsites, > and to avoid building the v1 bits when !CONFIG_MEMCG_V1. > > text data bss dec hex filename > 39253 6446 4160 49859 c2c3 mm/memcontrol.o.old > 38877 6382 4160 49419 c10b mm/memcontrol.o Nice! > > Signed-off-by: Johannes Weiner > --- > include/linux/memcontrol.h | 17 +++-- > include/linux/swap.h | 5 -- > mm/huge_memory.c | 2 +- > mm/memcontrol-v1.c | 89 ++++++++++++++++++++++++- > mm/memcontrol-v1.h | 6 +- > mm/memcontrol.c | 129 ++++++------------------------------- Acked-by: Roman Gushchin Thanks