From: Roman Gushchin <roman.gushchin@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: move memsw charge callbacks to v1
Date: Sat, 25 Jan 2025 01:25:40 +0000 [thread overview]
Message-ID: <Z5Q9lObsut0vgluc@google.com> (raw)
In-Reply-To: <20250124054132.45643-1-hannes@cmpxchg.org>
On Fri, Jan 24, 2025 at 12:41:32AM -0500, Johannes Weiner wrote:
> The interweaving of two entirely different swap accounting strategies
> has been one of the more confusing parts of the memcg code. Split out
> the v1 code to clarify the implementation and a handful of callsites,
> and to avoid building the v1 bits when !CONFIG_MEMCG_V1.
>
> text data bss dec hex filename
> 39253 6446 4160 49859 c2c3 mm/memcontrol.o.old
> 38877 6382 4160 49419 c10b mm/memcontrol.o
Nice!
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> include/linux/memcontrol.h | 17 +++--
> include/linux/swap.h | 5 --
> mm/huge_memory.c | 2 +-
> mm/memcontrol-v1.c | 89 ++++++++++++++++++++++++-
> mm/memcontrol-v1.h | 6 +-
> mm/memcontrol.c | 129 ++++++-------------------------------
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks
next prev parent reply other threads:[~2025-01-25 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 5:41 Johannes Weiner
2025-01-24 6:53 ` Hugh Dickins
2025-01-24 15:54 ` Johannes Weiner
2025-01-27 2:59 ` Hugh Dickins
2025-01-25 1:25 ` Roman Gushchin [this message]
2025-01-27 6:31 ` Shakeel Butt
2025-01-27 12:51 ` Michal Hocko
2025-01-28 21:26 ` Shakeel Butt
2025-01-28 22:36 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5Q9lObsut0vgluc@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox