From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A487AC02181 for ; Fri, 24 Jan 2025 14:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 063CA28006E; Fri, 24 Jan 2025 09:16:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0129D280069; Fri, 24 Jan 2025 09:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E43B328006E; Fri, 24 Jan 2025 09:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C3C61280069 for ; Fri, 24 Jan 2025 09:16:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F825C13D2 for ; Fri, 24 Jan 2025 14:16:42 +0000 (UTC) X-FDA: 83042546244.29.5350F1D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 2780CA0008 for ; Fri, 24 Jan 2025 14:16:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mCDzT1bX; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737728200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UeNtGGSFfj0bZDFmWGy23XwFx1PtMWKQH4oxaud+FZs=; b=6l+/p/aWTxO8zYqWBX3IFjr+/lL0N+WNZRVsNZIOw+m3NY4DVkA/I/+JRELBOoLGLbdo8I NfF68ohHj5KKQW3ZlQnHRKqrhPB9kSyu3HlkKeeQyEvrtLRYMLcqe/+LUTxHyEL9NBPQRA GLg+i6Tn+bsJpcKir9VMkWDXIPWDRYA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mCDzT1bX; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737728200; a=rsa-sha256; cv=none; b=jnzEnGVBqvKEAfmLfLmenIWrPx4J4UQCzzUCO5CfoRxmlkC9WhPJWyNmmdAtpdvmCNkxvU y9DkaxYEfid8VcL8Bq2USeAXmvNRmN/mMYYfdDiqjH85zver5J+EDc94v3YoVaoH4uN27+ ttWioRcYA9Rk/rj14jXdlfD68HkjqL8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UeNtGGSFfj0bZDFmWGy23XwFx1PtMWKQH4oxaud+FZs=; b=mCDzT1bXtXa0gN3cRpykLCgIQc 8GBM3nQd94xY+sse2sCYPhhdSx8tcG0CBNnO4e0icl5a5QaRFwLSR0SL2OCv9H0+ZMfeRxGI7rFWB /ajmmAVhWJRPWCEQwua2VgCFvPBzJFyKZy9PCcrw0G9UIrc6sNNUTy7yMw7fFMTP3o01m2GLCCdNh 45o8VpAkVhoRd5Feo0mokjstF/p+F+pJ7gA1dYPl2vjJCI87Q/vYdkY5eGu1R4RYDhrg4aPPfXp0+ eL4/eviJ5mbOB7N1JmFXyYi5FK3Kby1uqq5Fc+w/9r/A1uA5ZoVsGPQEjmYSPihgm5lm33aIqpCnJ f7aWorNg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tbKU1-0000000GAVQ-2Ax4; Fri, 24 Jan 2025 14:16:29 +0000 Date: Fri, 24 Jan 2025 14:16:29 +0000 From: Matthew Wilcox To: Alexei Starovoitov Cc: bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, mhocko@suse.com, tglx@linutronix.de, jannh@google.com, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next v6 0/6] bpf, mm: Introduce try_alloc_pages() Message-ID: References: <20250124035655.78899-1-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124035655.78899-1-alexei.starovoitov@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2780CA0008 X-Stat-Signature: xmkxk6safoztmj3gpg1aq57819td5p16 X-HE-Tag: 1737728199-80229 X-HE-Meta: U2FsdGVkX1/pL8dOiMx7h85ED++M1AHp9a3JYq7zSbuMxfB7/kRfO3bXz0vTnQ2FodLtR7TS+P200hkKHm+XIz0l/iLHOfGc0n0afqCH8NNRwpoArYOM5zdkVTVUSlnB5aPl+iIJ0sp/aQcoLex8oDjULuYiphoMoRaRFUSxI/SPcpFixTBUxzc7KuJDeovSOHhhHtB0JQaeJuMIGx/Duk1vhYzHWzfe0uvi+2h83XWDexkSM5Yq+aiKUnlgtwJqq3E4gjhG0OKh9/V7MlNrHNYGqrSSmXXtQcrpTLItz6/Mu/2asS9Kariz/zLbpRy6ajPuN1K72F5ehHIRVEB1ugAiwjIL2hGx032++8NNMyo5kwMJ8I0VFPtOELSE56oZZ9vMElUd/Bu+tFLlppDYjjEUp/eadvkQSbL8/ufYdSj1O1JYdD7jUSEDsfDK98hhwFu1tkWzQD/6IIWNUAekVTwXFnRrnskKMmh0g633Y1znNuEuxQHDR0ce2wfekiF+onOQy92SdrFQciJW/xhK05vtKz6Mysanmd8qdMqFV7C3oS8sLNtLlnCfc4jln4VPZtVDC/u9tg14P9+o3sDCipOjPKYmVgKbM+40pczttqJqprMlP0Y9POX8zKb54XplBGhmDd05wWrvvFFcFG9LW/PeQzH+Px2frIqR+HQJyOH9cBIwTJPLyCcDQWwcYF41w3WYPB8U8VriSlbcWJ6ES8o2rw305oPZl13oXegFHyKPQ6YoFtM+NaUFKms8W2ZgNVsIM8QmuIckQ6NpdSc8UgBPw2w9K5Y6zeMxHzCGYNL/pNyW2UeKH3++dH9Zd5/qyxtZqnXH6GS4FZN0az/bDYuRciGE9qixGbEKjDMEixLg+4pSzX0+Z6Q/OUVcAYHpCg/fhV8VlZMAtC8dPbDiLihX8yejvxT84G9f2Cwj8stSqvh5tTyeaCCFwV5+/9IEJM0qkHOQYfZPQcNt7hk Wa05XcGO Ne0py3LIKWwOz0FyrG3wD/5gJr2O//S173e6mmQ6+5VIJZLvosjvGcejdSSwMx37ypaiHzaNVjhBjp2GbHvAdqnRXtpsFtOSbGMXxPUUZicoHLj/N6NkjQMPslocQuS7zjo+5yaFFCA+DbdyrHil77DZ2qzvum4luU4PDsPX6iLVCK+A2wtgNXtoAwaMYwuFj5uaXKM0NA7eHY3VOtWlONOBysZTTQ3VlIFROAJjfpPyDpCbNUJ+KvW5CScu6HZcPVwpCjD3N9jxdrXHvie4M5iu9tqPjowIDlVYzfZGubv9NQOIHd8CCYtBCReArIKNJvXVAg+GvLXIyGNBkyJwmV9LwVSCHpSL2AnQBk9SxYWzIsEchvDOZ3jADXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 07:56:49PM -0800, Alexei Starovoitov wrote: > - Considered using __GFP_COMP in try_alloc_pages to simplify > free_pages_nolock a bit, but then decided to make it work > for all types of pages, since free_pages_nolock() is used by > stackdepot and currently it's using non-compound order 2. > I felt it's best to leave it as-is and make free_pages_nolock() > support all pages. We're trying to eliminate non-use of __GFP_COMP. Because people don't use __GFP_COMP, there's a security check that we can't turn on. Would you reconsider this change you made?