From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CFEC02182 for ; Thu, 23 Jan 2025 09:42:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D73D16B0083; Thu, 23 Jan 2025 04:42:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFC4F280002; Thu, 23 Jan 2025 04:42:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D4A280001; Thu, 23 Jan 2025 04:42:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 987386B0083 for ; Thu, 23 Jan 2025 04:42:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 197C9120E0C for ; Thu, 23 Jan 2025 09:42:31 +0000 (UTC) X-FDA: 83038226502.12.FE19F9D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id C836716000A for ; Thu, 23 Jan 2025 09:42:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="gFr0E/Tb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hWUFK2uB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=M8XGhp5q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wkoz+YfB; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737625349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oiMijr+WXmjA7NWesrEJYg/tJdD6ApuM+UeKC9rUR8M=; b=0wz2nlam38443xb2WknLt3S/Vng5c08jSU4zmaVMA+kZ8TmGJCm8AqMduSZGFzzR0e3L4X h6RUsB3TQYl/VG3Bw5BRjBmnRu4B9Qka0AotyrvMxMhOZzBk4jajyWtaJzkMtaUJo1nQz+ yLA8lMafwxckHHuWxvEdYyX9oSQajGk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="gFr0E/Tb"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hWUFK2uB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=M8XGhp5q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wkoz+YfB; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737625349; a=rsa-sha256; cv=none; b=cGWRYoct258l9uIYu0w2KWMgGe6Sw/IAKv/5Xigf+/dw1KIahj9vQep+/BxfLLaMnM3eJ+ rJKufF5U1Ntw2gxFyQ48feZfX3DHf1KIufmrlM/n6rAtIAcYvRct6z0VDaTcQ76yIX2dsz rxSgigzkwNStUq+bfd5PuyoaBBHd9eQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E606C21175; Thu, 23 Jan 2025 09:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737625347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oiMijr+WXmjA7NWesrEJYg/tJdD6ApuM+UeKC9rUR8M=; b=gFr0E/TbrLIH8telFHPniVV5+1zjjZ5H/OEUDijy6CBAH7/OVWl/DhyxqenIVwlkIVMweD E9EoCj/+Mdr0l7p988DYIFkJIM+2FcCrsErM74bpSlHvo1f5zFTsW3XW06bN5Imo+LxHJc ixER57rLnCpobAokHBm+zN7ZwK6Ra7g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737625347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oiMijr+WXmjA7NWesrEJYg/tJdD6ApuM+UeKC9rUR8M=; b=hWUFK2uBrgLKRFnvkNwPE5Q+6Yjnk6RSmIdUVH3Q7FPblwthUhprRES6Yn1/qXViCcFPCc gswsdDl4l71rApAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737625346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oiMijr+WXmjA7NWesrEJYg/tJdD6ApuM+UeKC9rUR8M=; b=M8XGhp5qzi3FzjEy2EYiEjHHs4WprImfFdWH8PK8SWuwSg32MWk5aft7drk5MT3xZCC2nQ W+i0weB4SNekFIuf/zY20AvEuNo90zhEw+qMXVu4NcSmwwE80bvyFOPE3xtBhLZNAb5V9y rTsIupIpDcTW4zV5K/Tqzxxs7bGlpUg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737625346; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oiMijr+WXmjA7NWesrEJYg/tJdD6ApuM+UeKC9rUR8M=; b=wkoz+YfBLerxnemLtg2Ijbgz2OlvZAAAvtRJ2IXTl0j+QnhAYlAmDGtTgKr0DahV85IwJy evlqe6fkQbdyeoAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 47C611351A; Thu, 23 Jan 2025 09:42:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id a1htDgIPkmcHaQAAD6G6ig (envelope-from ); Thu, 23 Jan 2025 09:42:26 +0000 Date: Thu, 23 Jan 2025 10:42:24 +0100 From: Oscar Salvador To: Liu Shixin Cc: Andrew Morton , Kefeng Wang , Kemeng Shi , Baolin Wang , Mel Gorman , David Hildenbrand , Matthew Wilcox , Nanyong Sun , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/compaction: fix UBSAN shift-out-of-bounds warning Message-ID: References: <20250123021029.2826736-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250123021029.2826736-1-liushixin2@huawei.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: C836716000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rfijguq9jsnctjyr4x993cnyxgeyskrd X-HE-Tag: 1737625348-475013 X-HE-Meta: U2FsdGVkX1/sBOEcvaVHxJEhJQ5ZXunHb3YlX0WJNEHA5MzuUdSCD2nwz4tLZhy9DMu5tzPzz0sW6aI2yAXkn5r23R2vA93n1lE8HXhA+0o1nXs5bC9lWWTCD4nfvHW4NJvL9Vz88VJr9rFXavFaHr1vJ8gihAfRizgPktEhRoxrkKAPAZSchvh39t8ZwzBob9tRIjlJVoplwfZX6wq+kpt5jRoCYsS89gf5aE4MzBz3EF4k/VpKqyjgTECUpKu1rnzeGQInOcOxAsYgc9XayoSrKuAbEvYM/XKjsFTFWfle5Di1zcbBJuepjg5OB1jLV26NBEhBda8Tli5iLFd+kZR2zhnySMchOHYCqcQ7v+TYHq37OwHN3R7VTRS2Bwcr1wr1APZEX6ner+iGj5BF1dOvVM21q86Vh/Y6BrgiajRbMdRzKKWNSW1P/veqgrPFZzXei6GronizUwj0OZioFcVStRNgN1WjIBMII8c94vWpoE+EzKQRgMYNNpTpJEQij9EiIhOPThhChly6sfm6zU8UWRv6dYgsqS1wy/t8uPHFVn2HUlHm+x7eZNgV9s4d/L77YFGjUaNnlXRwP5Tp3ruuFBLNsDhvJ1dLPHV2GIQbyy/3WrPXgChO/SV9d8mDJnNsAUKBI6YwrR+eAzeb6T2reHvMI7mygXxP+yxUW2OjVjALNkJe2vgbj5LJWTKS/cQ3l/fbq33bsFpQd4yZzZanFxk6WiTO1cOAMsExPpa0lcFOryzuCQce/62dNB0mwJNWid1vzcLt/sBpg+bRb2uAHW7H5F53lFo3J1EbujdwpLXBhagzMHNECkffCzaFBv12I5joIEl00zz8X4Brbybqyrz1QWN0ovO6gHaWXuC2coWgZxuQeZx0edyQDA6KW1nZp0HktI9AEJGpz7bC3UDoQNoTd4dQg8N5rHB9HUxLciTKC8AKiMedy0o6JmMAu51xMK6oxk8Rn6SfiHe WzoWYYqt KFrPQjnTvQ07jlD27+3G0QvCtlQ4LD7Vku9uxkFdfg0Axta13/bXyUaGPUY2pE9jiOPGBuCOBRirFfVNVjaxUuaTaW0xNC50c/GnrJBhLACoq2h8TQJO4lws6IgeDDiyLqGHdjNG5Dv8Jfvyvu1o14SvUgm2b5eKRiZUlJrKtTDH1dxohlwOXPqSn7M60ci41ARk+xuzEZHoaQjxKxKrEPa+fKbkLL0TM0gmATJHSoR4CyKaerATVMiUhCG1NtbhK5OwsCUlBcG99WWIysBjI/RcK7s1pKa0aFVz5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.006265, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 23, 2025 at 10:10:29AM +0800, Liu Shixin wrote: > syzkaller reported a UBSAN shift-out-of-bounds warning of (1UL << order) > in isolate_freepages_block(). The bogus compound_order can be any value > because it is union with flags. Add back the MAX_PAGE_ORDER check to fix > the warning. > > Fixes: 3da0272a4c7d ("mm/compaction: correctly return failure with bogus compound_order in strict mode") > Signed-off-by: Liu Shixin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs