From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67957C0218C for ; Wed, 22 Jan 2025 18:01:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE9F26B0082; Wed, 22 Jan 2025 13:01:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D98DE6B0088; Wed, 22 Jan 2025 13:01:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C393B6B0089; Wed, 22 Jan 2025 13:01:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A63016B0082 for ; Wed, 22 Jan 2025 13:01:49 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 32ADE45C48 for ; Wed, 22 Jan 2025 18:01:49 +0000 (UTC) X-FDA: 83035855938.26.31CD8C5 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf06.hostedemail.com (Postfix) with ESMTP id 4DEA6180037 for ; Wed, 22 Jan 2025 18:01:43 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=AAKTcRvS; dmarc=none; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737568904; a=rsa-sha256; cv=none; b=Tgwm0jRBy6ilRteAtzYaJOTXM8lzjbIVoH1AVhS1AVi7AqyyYIOxNf1Ktc0/3lkmc0iFjH tPfEPMLwqzEVdMhjpZT8iISOYfZvv5QpwrG9aJ0XDpU8/68nPtN7iokbiFLjsZAP+iaU8x cxs68U4KoRzTxAF6LAHjrcX1rlKZsKQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=AAKTcRvS; dmarc=none; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737568904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jmIlbgV3Hecq7oeRjm0yUIVGWs0+HJXd/BMQI5C4vVo=; b=PPTFQoklL1BBWQjqML1Bzzs2/y3XH92RxsUUao6LW9sTQ6gSfIr/xTSOjdUn4oyrvEZmfb AeTXy6KKOEzdBw7C4K9XKQ0gbFbiUi7BhqZ7zaDjzeJzfhPH5sXNMV/gghJvadbGWWbd3S cVPJ0KGzJo40h0bAuubM0++8M3+MFEE= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7be8efa231aso82327585a.2 for ; Wed, 22 Jan 2025 10:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1737568903; x=1738173703; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jmIlbgV3Hecq7oeRjm0yUIVGWs0+HJXd/BMQI5C4vVo=; b=AAKTcRvSLixsXQIk3fHvaMnjPXs9klYUNubuP/6QnJsX6vpnS0Loxkr5RhAc5nqLDN hS46Pkas9XhuX3eZtprh+vWt5HQ52K8nc25Y8LWuXbSXVXGCIsdhGjYqJgWNfaj0F17K jnxocvF2dmx0yOk/HxyRq1/aGwq/DNUfsZnDg0q+hH7M+q5XrxKN3DPs5dRCBF6Ff2yu tagCw1xrHiqcj1dT/+5b2VyBP/Qf2bs3CuEzN14CKpu2Nw+AF02/Lms206VHbhwFqbAP aq3uvn3uEl7K61jdbn29gLQ9fUWkRvbGhfOs1hqumo4bpTYPEQE6bvN/ICQ0Alzl3Fej L9XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737568903; x=1738173703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jmIlbgV3Hecq7oeRjm0yUIVGWs0+HJXd/BMQI5C4vVo=; b=BpQwzRGwc8PKfF2ABA1lSO88arNl29zwNlIeuhaY7ip9jsbOPRVN1+WgM/3ooFBXcK 4AS2u8TvykODW50+5zfX+fWj4R6wKcJljiGPTmZXxw/r6VWtwjDNrpJNPDLAFxAA2wR8 68BzgPd2wPrrC2zv3ljjnJjH5EikxGdiI3uyEbf4GaA9wvzlCNNAsIEyexRjjJUJs/TG 7Aopp0pEonJCGVmGynWn6DeNV9X6Nt+x9jwrTgLLuouAtd5PmcYhwSV7nQkA5H5RA7pk zQc3do0yRr/S9qP7rQovkwCtmXSWuiYdseKKIBw21/L/plfOMM5/8T+W9DCo5YsrKHzo Egvw== X-Forwarded-Encrypted: i=1; AJvYcCWr526qfmLVb+MxUUK2W2I6x8feS76FoKittwjBybAVD27L9YSEQNHgZluj6g56tNFXGJP7BAHnLA==@kvack.org X-Gm-Message-State: AOJu0YwR4p9UHykbZBIh7gxARD1/F+Y/vQSBJSqikn5uIo4+WxW7M6dO KEOkGAYKyj0jEtvQ2y3k8kxYuRNK6Zth92yELVwSDGPMW7RPp2g4FiJXAcNKnCY= X-Gm-Gg: ASbGncuQnoSZguehFZmJ/BnJDn7PDMNe40pnvo9UgLuHwNx//jWpa55BEZGpNNoudit 9WCJJAni7cbcVpVE+UpCRoHXpc0aZbR+s2DnQ7rOjZCuX6qFr+57QaLId0sIadq8NhYnS5iAGwq 1wDNVlaX9q5gfhHOL7fai+Bk0bCLIjdTCVvLng9mIUeMtx1xd7xNcEgjpyTo0o6d/V9o8B59dsy nTnIt1tm02BtWKJsqiXrBhiirv8uKGNAgdT8QvDCAK2uINeqSiVWiI3zbsWbVzc1fFUVMg45BzA BtdYUrFDg3mKMERhZtLZGEuo7vw5aOnZaTy21rgSfLZIKT0E59kW X-Google-Smtp-Source: AGHT+IHqa1xKG/AqmiY+AVDYMkRXO1guViKVB1zN+6qWK7JdtV6orWLAGz3awoN7Gr91E+h+yvFO0w== X-Received: by 2002:a05:620a:410a:b0:7b6:d870:ca2d with SMTP id af79cd13be357-7be6321be51mr4107036285a.13.1737568902893; Wed, 22 Jan 2025 10:01:42 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be6148054fsm685446285a.45.2025.01.22.10.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2025 10:01:42 -0800 (PST) Date: Wed, 22 Jan 2025 13:01:39 -0500 From: Gregory Price To: Bharata B Rao Cc: abhishekd@meta.com, akpm@linux-foundation.org, david@redhat.com, donettom@linux.ibm.com, feng.tang@intel.com, hannes@cmpxchg.org, kbusch@meta.com, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nehagholkar@meta.com, nphamcs@gmail.com, ying.huang@linux.alibaba.com Subject: Re: [PATCH v3 2/6] memory: move conditionally defined enums use inside ifdef tags Message-ID: References: <20250107000346.1338481-3-gourry@gourry.net> <20250121043355.177611-1-bharata@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250121043355.177611-1-bharata@amd.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4DEA6180037 X-Stat-Signature: h46cb4ogwbied1uetshin6xg8sigi38g X-HE-Tag: 1737568903-922710 X-HE-Meta: U2FsdGVkX18BaFrryXaR8jrAz8fk4t1s+AKBx+DHimIGC+olHlas/s0sxNwz6nwr7D+r5Xmww+RfS0TzBUl9XlR5jp33nQtKPBMNmvh+dDZd4n9yDbh9r60Mke35yVG9QIO/YAI6hGTO2IuJ4e0SqhUyY9IHLl+ntByNY7G2iRDodGoHGoEu5vVESDp3+zY91mHPC17WafhMhfbc2EB8VvEkpJjnNqN/nycA0hhQjlfIc7PQi7SIUPnXqaaa2ITk46+erLjuJJqBTXObSWZkoXwmBgO34WSV8BP4MJ6Fx0x4YAZOFnBD2KMyidaeZVQHIEAkvCFoq3+AMRS9z3ymGFG6cqG8pjvF6uR+4bNlwAnV9FFXBGwE5N+Kx/xmefR3FjsALZWGaLkEXwVK4yufUtomP4pZMKTvdFaGiwRY9iJknPZO30FQKTolOHFWSIWOcSsvvron07YkenO3FPl4YfmhbL/BTMrk1FYVpSQOss2akdLQxVicN9ipgbFMt8B9WqG444rRQgETltDBg638lxRfRO7HB1PcZrzZU6tPV77uuUcB7BPKgyoNJzPXm/EYW+InslgUsJb3FbOZAniR9tdGV0NlLcxq/QGyr153BhjIJPvLPJ8iWweGbQvuv5y3NU8xDURUymJ2LjIjXcXLUF+kuwHVJwPpUk//y+YYmjeNs1Zwr+31Yzly4CUSsRoKyNEi0T/zdEMv0cZafQ5ZNyVYKYTQQwxZZgydkr502y4D4SgPre/rE39nPdi2/d/ao3gVTGrvmJE86PuKonXFP1JpyNe5spCwZ8Xsmfb1TVoJNK/16DW/OWaK4BiadJRUE2UYU6qV0GzV/ZVbMdRFYrqARvA8uuVTlhmngSDplHHDvMLrKIxmwxfFeL6p1MhLngM7Hzo8aJZscqlgMwHNNqYJuiK0yffmOvZPayyT23Dy29PJkoiHiIc2PZLFfFdXD4YsWdb0stCddcUJowb n4DBntsj GLB625yvdRxWuUo29a5aq7ytzrN3Bu1BQEULk3FVGorktCEsfxRH97aIfUu4iCRvf/ogRS7eCOnkJh7HjLppeLiECFCpAoo9oUzgStdXII+7iMQ+uC47ysxCQRjeCKWPKC0HGhtPtmQ9Sf91zw/YHdwf6fULidQyvUR2/LjoK4ZOHfY9uTjYgiMFtntZ8u5h59MMDypPcq300Wse1nAj0txqGIoUzHPfWRuLrZTqntv6xmAhjmZQ4knvMyJFxJGmg26/y/oma42bnlLniCMLB9Xot9zpFxo66Wk16l+IiO/zi11iAwAoSmVQpYIPWHFpF8bhUUcAoW66gvrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.019981, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 21, 2025 at 10:03:55AM +0530, Bharata B Rao wrote: > I don't think moving count_vm_numa_event() to within > CONFIG_NUMA_BALANCING is necessary as it is defined separately as NOP > for !CONFIG_NUMA_BALANCING. > NUMA_HINT_FAULTS and NUMA_HINT_FAULTS_LOCAL are only defined if CONFIG_NUMA_BALANCING include/linux/vm_event_item.h #ifdef CONFIG_NUMA_BALANCING NUMA_PTE_UPDATES, NUMA_HUGE_PTE_UPDATES, NUMA_HINT_FAULTS, NUMA_HINT_FAULTS_LOCAL, NUMA_PAGE_MIGRATE, #endif > In fact numa_migrate_check() should be within CONFIG_NUMA_BALANCING as > it should ideally be called only if NUMA balancing is enabled. The same > could be said for the callers of numa_migrate_check() which are > do_numa_page() and do_huge_pmd_numa_page(). > Really what i'm reading is that these functions are in the wrong file, since ifdef spaghetti in *.c files is not encouraged. These functions should be moved somewhere else and given stubs if the build option is off. > Regards, > Bharata.