From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7700EC02182 for ; Wed, 22 Jan 2025 05:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5BDA6B0082; Wed, 22 Jan 2025 00:52:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0BE46B0083; Wed, 22 Jan 2025 00:52:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3436B0085; Wed, 22 Jan 2025 00:52:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D2596B0082 for ; Wed, 22 Jan 2025 00:52:47 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28E731613FB for ; Wed, 22 Jan 2025 05:52:47 +0000 (UTC) X-FDA: 83034018774.09.380E8A8 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 379C1C0004 for ; Wed, 22 Jan 2025 05:52:45 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iQvFCwit; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737525165; a=rsa-sha256; cv=none; b=yLLSw5Gi4sLbrkJ6rXIuGVE2wGsZwNL8koywpbKEzs1HhmnWiGjkcsuN8H60qRexynsVQo DqYVq7BXE+VmzPx7U7XJ+mwKbQVZigIwbckzkfznhFk19dfVGSSkMLikXseLYrWFHxu5nw 3PEKkRh9LzmgEhUZwhujVPVkHQnkOwU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iQvFCwit; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737525165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lIZ4JWBoERe85R1qokaI80YQhLGY5lo9dktYyry3040=; b=zzxFg54adTEPdpkGEZXc24lYiDRy+EvAT30RAPpAbxrjjMAW/k15dktj2JC5FvwWvH/lpY 9Iy7z9SxyfHfAmZpjOn7kXw+v0eiRjxy2QJg6Tgpue76NtKfxSHjsLQVFF1ze3htNtqEUL jP4BtPObNlSnXuu3hFWqSP1knWbBqGs= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2163b0c09afso117336185ad.0 for ; Tue, 21 Jan 2025 21:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737525164; x=1738129964; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=lIZ4JWBoERe85R1qokaI80YQhLGY5lo9dktYyry3040=; b=iQvFCwitH/5IQWO8iyeVnO8RpCmsvu6y12PlLY95sxdVXn9sqCI4HK8Ilos415bp/U z63O73bF2Q1ULHlADNop4nKyIbIo7jSjSYTAgT+td98RlH1oRDJNGuplac6jEbx2xzP/ MI8XUvkPSx5KMV65S8s+NQHnOeaaNe+OsG/Rlz+ldedmbFC5O8vXC7bz/2R1cM0jQz5C CmCgho8hguYQYG1xtV91cisu6gboOUDNRK9POoqdFS0KznT0sQnjpYLrzR5XZu89C9Rq nx7JNgU7JPDSFrKffGBpEyVBZQD2h09NqBxGgV3K8NVoFKvto5gxzFRewhSDFA3ytvme ka6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737525164; x=1738129964; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lIZ4JWBoERe85R1qokaI80YQhLGY5lo9dktYyry3040=; b=HBUsmLGC5sXjCp+YK1s6EPgl9b5CdJYVlAH5ytJndB4x3YAkAor+qx9NIRn4E03oGl D2tLIRFvH8WfpY78yY4OL5EeX0JET00RbWjJyCBEqKMyb+c9t4gwF0zgIkiWSkHys3TY moowlJsgbJc6haZfpiaaObjvTI3nUNzQAnf8gsRSw/7lFCuYk5eIOfgWeJOomrPbCWCw 4kqRElgfubMRJwlyprr65hbr/vJSUu6D/Msj9KnN6LoeAk+Rs0VSC2BNwYvK4qSiZaTB WTf20H8Z3jzDwJpExQyZQmd3yaTz1eGMcHnIrtMlBs05AAlzt6snUs05hFUYB/tGSC17 4kfA== X-Forwarded-Encrypted: i=1; AJvYcCVIVsVmmZsl6o2Q1HfKxF0OzzqYqjkX0ErajAACJpLLAlYnZIRoG8pzpUkK2AspQUnaWKTlEx/Flw==@kvack.org X-Gm-Message-State: AOJu0YwoTWIzuA5XzIh314DGTkfdZIoKLUUex0w3oq/t1G/PHMOdqFAR 7JS1NO5E7/+FCNUSKZ/DWe6ce6O0JnqIqbgqtw3sUt+2aNHlLbPzYlAcWA== X-Gm-Gg: ASbGncsMgk8dtoU3ENRjDHCke9KraIHT24sMfv1FnqIevgSl/H5aBcxP3CO36+oAkkM vkw4FYJwFNbL/blQIhS2MsRUK1JzAP/X7BQzkLku3RfCQqp9Ck92qw6OMiE0azNrr4wRyrs+NJA k9we/1moI4xWA0/MeCQL+E+7tBxfoUO4nf8vWCmi7BsdWCP5IsFa4sE9NgqKDpAzYTsmkL+YSrP EvYiXPZj++f1rs2SA/gZZFARDTRxxBc33oIivMOxAaRTbGUvdFL5MEYBu5O X-Google-Smtp-Source: AGHT+IEMERNf0CAbcXPzg/rzGFntCuPDmQzLA9ME8SZaMWHZjXR1p4ty85shv2aBuJWkttmh70Sf/A== X-Received: by 2002:a05:6a20:2591:b0:1e1:e2d9:3f31 with SMTP id adf61e73a8af0-1eb2148df72mr29099403637.16.1737525163660; Tue, 21 Jan 2025 21:52:43 -0800 (PST) Received: from gpd ([2601:646:8f03:9fee:1eca:6066:421d:7396]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9c8ed3sm10013391b3a.113.2025.01.21.21.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 21:52:43 -0800 (PST) From: Fan Ni X-Google-Original-From: Fan Ni Date: Tue, 21 Jan 2025 21:52:48 -0800 To: Nathan Fontenot Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, alison.schofield@intel.com, linux-mm@kvack.org, gourry@gourry.net Subject: Re: [PATCH v2 1/4] kernel/resource: Introduce managed SOFT RESERVED resources Message-ID: References: <1800b17449d1c231292c85f59b226aff39a81552.1737046620.git.nathan.fontenot@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1800b17449d1c231292c85f59b226aff39a81552.1737046620.git.nathan.fontenot@amd.com> X-Rspam-User: X-Rspamd-Queue-Id: 379C1C0004 X-Rspamd-Server: rspam10 X-Stat-Signature: zgihkuhssrt4xtq5ng45jsoadfu56jmb X-HE-Tag: 1737525165-100403 X-HE-Meta: U2FsdGVkX18qM3AHGME8N7Aq0DYRnIYThwFmKF8ZUPtTGpGeZFRHQ3k+VZO0soZRhMaRB4o9ExfOYSfUXd5rKdilffZdtyznARB/1ZGHRX2Msc54BxMnM+Zu/FmIwq2cA7y97rENZs6iAVpcqXI1g+IUkiH8a7I5a5+ie9PCk3hT3xaZ7BiPhsIcgMjqwUxf9USunB+FUoTpOh7GHSZP89SfWEsHscdEoOcmBTVl56to7hkWjC3JWUxwF+XXmyXNcx2JLnB2yaxvPhRZw2tMGGCIDqRrE2xGkMbBf1/JoWSp+Qty1TS3DhDKJxyJOH2nFEEqaa/CwJPbTaYICxYYqvAbhqktpBkpLzSUl43ThxTYdiv8w/NvOQW4AG67icMxaSHwOvappZRgB6zy4eZk8hbAKAJ7f4jSmsM6bGjA60CZshsUgP47TDrdn/XD12lkfI7LhdiJc8WPk/OnRWHmsV659P1QFWzNiSg4jAfoMAYmm4GTIbTleYvl4lrC7AfyBuLr8ngUKktG2HmKnRaXCg4AKdflAM7X0verFFtfb62LoX2P7ebd/ErM82xYvbeZgjq5ZBYWCn7C2ylWdZ7s6v4EJ4BwRf8DBBqGlSz41Z055/0Gkq7+syrTHz4m/FlZRLns/gGzYMIPCPdmqufSEFrWeV0ZiIXiILH58sddu5E1+xyVwFExdT/w35d2sec1qCPIhISr+RVFuO/gVN0sXgLuN+On7kVFcVPrtqpxY2N8p0wyrOWlQkRmlHP19DiI9JtwJFltn1SKTB22Olx9fSVgw/xKN0FeufBP4iyVEC1bmN/9SNjksl9mzV4J22Qf3th7vShGx0HpaiOl9BGmpr9o3FpCUTnAsjNFTvBok7sNdB3xo0qNPqi1qNXT9pdMMnWoTEZZdfdVl1obtAarMakkWa5SZdfkd5NonYZTIRWYIRMUb3ebmNJs0vvqJ3RYsocxltr7lfz19KTTblm Po6s6pMc eASVwAG8ysC5sa+xVyIf4uLwChVEqCtDbL2u9tl8V9AQqxkPbVjqoBdnU6t3cB5ef6DV/jl8J3JV9qcYvFwWjt959Ln49/5zhHPcvDyjuYU6W6n3+eW21x2/DxDjikYCj/vdyts12qS5Ngkh9Ac6+Y3PL4y9Ku0ue4CEDuVinCNarfHtYdTRnuNoHRaZL8YeOOOsyL1+o3OThfHZE3F8o/EBhkRDcCElnYVckcwwvcwLi5ALMPuK5V59eeLRKiEkxVR8JBuzROPQY4UV9CrEOiBPeAHneJhnTQVWjvFS/q2ukaxi2wWaY/r2hzUnOb7TWKovap839eIOgt7Bb2FiKijEQmS4SOSm3N3WnONy8QpJL6aB2C7r030Hw5HSEPdu2nnAYSs2AdBClgdaaKov5sAh/5ysWHUiWbEmiE81iDY5g7k+5l/EocxTsyL6DP2/BPEAUpT/FNUuI9XrXRXourEWp8d11+VWHJzi7GPVCS2QlVZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 16, 2025 at 11:42:05AM -0600, Nathan Fontenot wrote: > Introduce the ability to manage SOFT RESERVED kernel resources prior to > these resources being placed in the iomem resource tree. This provides > the ability for drivers to update SOFT RESERVED resources that intersect > with their memory resources. > > During boot, any resources marked as IORES_DESC_SOFT_RESERVED are placed > on the soft reserve resource tree. Once boot completes all resources > are placed on the iomem resource tree. This behavior is gated by a new > kernel option CONFIG_SOFT_RESERVED_MANAGED. > > As part of this update two new interfaces are added for management of > the SOFT RESERVED resources. The release_srmem_region_adjustable() > routine allows for removing pieces of SOFT RESERVED resources. The > the merge_srmem_resources() allows drivers to merge any remaining SOFT > RESERVED resources into the iomem resource tree once updatea are complete. > > Signed-off-by: Nathan Fontenot > --- > include/linux/ioport.h | 9 +++++ > kernel/resource.c | 79 +++++++++++++++++++++++++++++++++++++++--- > lib/Kconfig | 4 +++ > 3 files changed, 87 insertions(+), 5 deletions(-) > > diff --git a/include/linux/ioport.h b/include/linux/ioport.h > index 6e9fb667a1c5..2c95cf0be45e 100644 > --- a/include/linux/ioport.h > +++ b/include/linux/ioport.h > @@ -249,6 +249,15 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start); > int adjust_resource(struct resource *res, resource_size_t start, > resource_size_t size); > resource_size_t resource_alignment(struct resource *res); > + > +#ifdef CONFIG_SOFT_RESERVED_MANAGED > +void merge_srmem_resources(void); > +extern void release_srmem_region_adjustable(resource_size_t start, > + resource_size_t size); > +#else > +static inline void merge_srmem_resources(void) { } > +#endif > + > static inline resource_size_t resource_size(const struct resource *res) > { > return res->end - res->start + 1; > diff --git a/kernel/resource.c b/kernel/resource.c > index a83040fde236..9db420078a3f 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -48,6 +48,14 @@ struct resource iomem_resource = { > }; > EXPORT_SYMBOL(iomem_resource); > > +static struct resource srmem_resource = { > + .name = "Soft Reserved mem", > + .start = 0, > + .end = -1, > + .flags = IORESOURCE_MEM, > + .desc = IORES_DESC_SOFT_RESERVED, > +}; > + > static DEFINE_RWLOCK(resource_lock); > > static struct resource *next_resource(struct resource *p, bool skip_children) > @@ -818,6 +826,19 @@ static struct resource * __insert_resource(struct resource *parent, struct resou > { > struct resource *first, *next; > > + if (IS_ENABLED(CONFIG_SOFT_RESERVED_MANAGED)) { > + /* > + * During boot SOFT RESERVED resources are placed on the srmem > + * resource tree. These resources may be updated later in boot, > + * for example see the CXL driver, prior to being merged into > + * the iomem resource tree. > + */ > + if (system_state < SYSTEM_RUNNING && > + parent == &iomem_resource && > + new->desc == IORES_DESC_SOFT_RESERVED) > + parent = &srmem_resource; > + } > + > for (;; parent = first) { > first = __request_resource(parent, new); > if (!first) > @@ -1336,11 +1357,12 @@ void __release_region(struct resource *parent, resource_size_t start, > } > EXPORT_SYMBOL(__release_region); > > -#ifdef CONFIG_MEMORY_HOTREMOVE If CONFIG_MEMORY_HOTREMOVE not defined, it seems we do not have a user for release_region_adjustable as release_mem_region_adjustable() will not exist. Fan > /** > - * release_mem_region_adjustable - release a previously reserved memory region > + * release_region_adjustable - release a previously reserved memory region > + * @parent: resource tree to release resource from > * @start: resource start address > * @size: resource region size > + * @busy_check: check for IORESOURCE_BUSY > * > * This interface is intended for memory hot-delete. The requested region > * is released from a currently busy memory resource. The requested region > @@ -1356,9 +1378,11 @@ EXPORT_SYMBOL(__release_region); > * assumes that all children remain in the lower address entry for > * simplicity. Enhance this logic when necessary. > */ > -void release_mem_region_adjustable(resource_size_t start, resource_size_t size) > +static void release_region_adjustable(struct resource *parent, > + resource_size_t start, > + resource_size_t size, > + bool busy_check) > { > - struct resource *parent = &iomem_resource; > struct resource *new_res = NULL; > bool alloc_nofail = false; > struct resource **p; > @@ -1395,7 +1419,7 @@ void release_mem_region_adjustable(resource_size_t start, resource_size_t size) > if (!(res->flags & IORESOURCE_MEM)) > break; > > - if (!(res->flags & IORESOURCE_BUSY)) { > + if (busy_check && !(res->flags & IORESOURCE_BUSY)) { > p = &res->child; > continue; > } > @@ -1445,6 +1469,51 @@ void release_mem_region_adjustable(resource_size_t start, resource_size_t size) > write_unlock(&resource_lock); > free_resource(new_res); > } > + > +#ifdef CONFIG_SOFT_RESERVED_MANAGED > +/** > + * merge_srmem_resources - merge srmem resources into the iomem resource tree > + * > + * This is intended to allow kernel drivers that manage the SOFT RESERVED > + * resources to merge any remaining resources into the iomem resource tree > + * once any updates have been made. > + */ > +void merge_srmem_resources(void) > +{ > + struct resource *res, *next; > + int rc; > + > + for (res = srmem_resource.child; res; res = next) { > + next = next_resource(res, true); > + > + write_lock(&resource_lock); > + > + if (WARN_ON(__release_resource(res, true))) { > + write_unlock(&resource_lock); > + continue; > + } > + > + if (WARN_ON(__insert_resource(&iomem_resource, res))) > + __insert_resource(&srmem_resource, res); > + > + write_unlock(&resource_lock); > + } > +} > +EXPORT_SYMBOL_GPL(merge_srmem_resources); > + > +void release_srmem_region_adjustable(resource_size_t start, > + resource_size_t size) > +{ > + release_region_adjustable(&srmem_resource, start, size, false); > +} > +EXPORT_SYMBOL(release_srmem_region_adjustable); > +#endif > + > +#ifdef CONFIG_MEMORY_HOTREMOVE > +void release_mem_region_adjustable(resource_size_t start, resource_size_t size) > +{ > + release_region_adjustable(&iomem_resource, start, size, true); > +} > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > #ifdef CONFIG_MEMORY_HOTPLUG > diff --git a/lib/Kconfig b/lib/Kconfig > index b38849af6f13..4f4011334051 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -777,3 +777,7 @@ config POLYNOMIAL > > config FIRMWARE_TABLE > bool > + > +config SOFT_RESERVED_MANAGED > + bool > + default n > -- > 2.43.0 >