From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50940C02194 for ; Sat, 1 Feb 2025 16:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EFE16B0082; Sat, 1 Feb 2025 11:49:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 979106B0083; Sat, 1 Feb 2025 11:49:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8408A280001; Sat, 1 Feb 2025 11:49:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6420B6B0082 for ; Sat, 1 Feb 2025 11:49:39 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 12E84B166D for ; Sat, 1 Feb 2025 16:49:39 +0000 (UTC) X-FDA: 83071962078.13.96CC596 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 3A020140018 for ; Sat, 1 Feb 2025 16:49:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=aCRUY2GJ; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.51 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738428577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i5hZ7n+KMI2jYGZGNxK3D06MIX9VxNA2G3c9z3NYvRk=; b=LrOJZLzjVYCuiRYIs3nO6Kp8+/Vkjf0VYlehzIL2brTTXcWeQxLmcisPfhMFjNLkJ5Wbu4 HLPJplRk7m7jdkLYu9q0Gjo1Fdz+meaHyEnbMtl4TFduor3w2RaluYR+RrBJliNHKhNJP6 AIQfO/Qom5YhDCw7lUsHLtb3whj6Gkk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738428577; a=rsa-sha256; cv=none; b=7+6DEx8ytr64QVOkg5AAzYTYPHV+ijfXkfq0zUcdYMJcWIC0NoNu2YcX7ZPCNGD3/QAQds Qsiqmulo2LbyAgrp5zlPWSMRgv9QCfHrWS28ZJuu36K6IcGENdOlvoTtxr4WG9Jmjt0M/m 7CvQpL872aAcJlApY4OYaBMA6wQ7IM8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=aCRUY2GJ; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.51 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6dd1b895541so61264426d6.0 for ; Sat, 01 Feb 2025 08:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1738428576; x=1739033376; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i5hZ7n+KMI2jYGZGNxK3D06MIX9VxNA2G3c9z3NYvRk=; b=aCRUY2GJ50aSO86iqswZhy+MTIW6rogKuT7H4nGQnBJjcEzHoeU/HWBvGrS1zDCCOW nKi/RlbFTEBIKtYqJP4SFw4JBIDrnAW82Jg2ecah4y64Qqtcbavwo4T2Qxzb6perldWL gk/a8PVv5sFEf4iXu1vc3JJyuAd4k644d2kc9yz6fOfp3hv1e6bpWMn1wrKFDj5gfXSK NkQLq0GU2Bs8SIh5FyJfp0rq78w+oCi7sS2KMf6ScICvwY92NEmLgYKheI/UDXayEFTf aDdVyv+ljakRos701jQnPuR1MfCcFsEMbFJMrs8gVKSVlSBFluBXIw+nAGVuvcN4+MuY hnmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738428576; x=1739033376; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i5hZ7n+KMI2jYGZGNxK3D06MIX9VxNA2G3c9z3NYvRk=; b=EDBdwkfF23F+gIKlkSPRtG20cxYkS4g5g7vJtLbE7x7a/yaEKg024RqUyOov+6I6hQ z1iFNZwsJ27ZHChBuCGHp0EmJc95ZN1zDyE0beucDx/h/y/7D9PWqLQMnCw3uMNrwmAt DCWxDXNv9jWN3fhFP7fx/z0yrt/WJc7BMH4xHEhh1nZwUXSjHuSv6VAM4HTFjm9RMip0 W8llmLmdQfcVv5kloLd2Ltjz3IQixq0q0q8Z7drrl9qpI2buxzkzXPrW8Upp6X4Im/bF XvJ6/BGLjtPNt8loQ5GLvDb96MR2dcSzGfWfjJDvChndtLbNGaFSwZUha1l7xmPpiux4 wmBA== X-Forwarded-Encrypted: i=1; AJvYcCWICg9E4vEAAsGwW44092vnsHKmcX9JvIGKx/FkJcgMeXYzbyZiHDPiFndZNqfHYsX0YHP3c2DKjA==@kvack.org X-Gm-Message-State: AOJu0YwrdElEl4WFA7Y/P8rtuqvWxr/kcfoaFV6daT4WDxJpWyiPEe9B 76jHVZDNTW4X+CkAGvpgPvLULpKdZh2zUCIJwazV0DxebDW2v2GcRIsu9cMMvk8= X-Gm-Gg: ASbGncvLmjgIJcy/sr1pLY0H1njFmKDdzcnr6IO2V78pspHiUktT8IdLYIU6OWMmXNq z/ixA+BD2oFDzhmGYZOJknygAOSAcQ/ZF4vLKLxR7DMK15TXTCmgMxs0WelvIv/KFi2UHLPO/yN +UVONqcfZxPgkJhSkz8UTIk00UOCjkBNxcO+4KzNwK6h286K96EDymdSvp11RcCCzErhHQdWhmj MJ9tI+cblO+aigVhChlGjn//n7/vgSJ4pnMn2lUJnT5tvfuqGAsYotdvYry4qmzqCLlsGz+GA/l IUJdWU2ByWnW3UwnbOy+8nEJUNWhJeXw9G7Fi76mNfvLMIWD/ebmIgHc0t6OCCrbgDptjcbh9w= = X-Google-Smtp-Source: AGHT+IGQ1+NLg4YrZ+Gf9BL0Rh9NpBsRqQq8Sh+36quBm0Fy/vRbGBngIjmOrObiKxMdofyyvxBbfg== X-Received: by 2002:a05:6214:238f:b0:6dd:c594:27a2 with SMTP id 6a1803df08f44-6e243c07fc9mr257417916d6.27.1738428576442; Sat, 01 Feb 2025 08:49:36 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e25493ee7asm29729816d6.94.2025.02.01.08.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 08:49:36 -0800 (PST) Date: Sat, 1 Feb 2025 11:49:31 -0500 From: Gregory Price To: Honggyu Kim Cc: Joshua Hahn , ying.huang@linux.alibaba.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, kernel_team@skhynix.com, 42.hyeyoo@gmail.com Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning Message-ID: References: <20250128222332.3835931-1-joshua.hahnjy@gmail.com> <41ab5a11-f8d3-403c-9d68-33eb15aef8fa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41ab5a11-f8d3-403c-9d68-33eb15aef8fa@gmail.com> X-Stat-Signature: 6ngc8ia3xqnuwcfnkq7sx358eaz9qxsa X-Rspam-User: X-Rspamd-Queue-Id: 3A020140018 X-Rspamd-Server: rspam03 X-HE-Tag: 1738428577-804461 X-HE-Meta: U2FsdGVkX19cW+rjkuJ6uV53wBFfx5cx7uQcPKl/uXvH2bOqDm3668k911S5tgXhL+XO2y87pw7dKixXR3mQf2HQ8IAHQIxAogdeDiutJaFIybQS1TXedKefNPkGLpWM1WDaakYxqR9zbj1eCcYNFrsIVzowhU93dn8anP3164DCm17Asn9e8ziJciC8OQHZeUnapKJyIo4wmbr696UhkuryQmwLgSsBpfqpCJf7+k6qux1Sg4KZUtI5pxhjpLL4cdsHeRgQpW2J1iQuLLwjW/feGcfM6O5ugE3efK5uagsJ6MQh6xcnY0gtM7GmAgFx0jcTNY6A0mHsmBN1aEZ9iw4jhidXI052Yo3x6Tu3a4Ds/n0UI50v8eXpC1ED7jHWGe9rGcsD0qmN3uSV4/kHxdf7WGM/+hH7GuFrB6FQNdZDRQFvNtZYdmYY1T03o8t16lukmynWUXsUTUxlYf8myJJOEmKHmGg2JBFIBrK0J+pWqdxcCCgsLFO1jKXG8/4QdOQ/h1Onl+43aZ2lCZB+dq2TPUxtBv/k50YJ4FkEfyNow0dM5YW22Y7ZjQGZSfiw2mEt4BBwYcuw6Ow2jcr6MNfhWFECruy9YenztANYyB1CSZE/21cqDgnF5PqUv5wFUHyhnekhrIq6yYBBsK+/mGI5vsxyLsu3wXzOgVQdbT+9UNqNEs+e9JNFZABStSmG/Wqgp2ye96x2hef48ZruUYqYw7+YZ4m56tfrzutcz4hKkGmkiHxt9ImbhFESR5jnL3dsqHORL8F11XRQoZ4bGQMEqFviq/w/5RInsJrxvxHmElu6lqsZUH5ALrunrhkK02DouK+jY5ciddGjVIYs7ZlQzteyR6xsqP/PcVPLUfc43rGDLJjVkx91paouLGBfp0ZQYTbQjTlobW6LALPog2r87YABom59RSpppw22s22P1tR6aYdM0SNDomSNkX6cq5vsuwKf+Sx8xaDniGF cB/vyZIG 4rxFzLaXoh+cE3ndCwnnG5YX5Z/5dDLAjmO5X8Gjyz/PohU5qhgxTpT7EC/RUyUO7ZCk12mfEBgYHBJLFr75Q5EaLB1/SBbOwuvoAX3Dh+vZUF45sOIRQNpu3A3ULiTSSE9NVMNFNAO23ZDOhz3xsXtd3X8TwpmKFBAgEy47aeyQVTfewYS8UlppHFFwwmyiVzGqvuedrtmnK3ydXsxYE6G9895eHCspb832GY5ptFGmaWJh1dtPyFI1p2s0OVkqfTpPmYDjH7dWRZU6yuRMbiu/hrSqNeNL4AP2k1Bbn0heD/SaH7lR1hal6u54HQwcXzhkLHxZ/NEWrMcNh4/AyiW4i7mGQBDYG+IpdbRWmfWWjr6aV8NtCFrlmyviV5mIUNmJkW5pnWpWelVKJNM6coQ/FLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Honggyu, On Fri, Jan 31, 2025 at 11:23:34PM +0900, Honggyu Kim wrote: > Sorry for jumping into this discussion a bit late, but IMHO, setting a > newly onlined node's weight to 1 can possibly make the entire weight > ratio unbalanced. > This is only the default for either: a) Manual Mode b) Auto Mode - when HMAT/CDAT data is missing In manual mode, the node weight in /sys/kernel/.../nodeN is present regardless of the online/offline state of the node - so it can be set prior to that node being hotplugged. Since it's in manual mode, it's expected the administrator knows when things are coming online and offline, and they have a clear chance to change weights such that a 1 is never perceived. In auto mode, the node goes "online" after HMAT/CDAT data is reported so users will generally not perceive this default weight. > 1. the auto mode set the weights as 10:5:1 for node{0-2}. > 2. node2 is offlined, then recalculation makes it as 2:1 for node{0,1}. > 3. the auto sysfs interface is set to 0 to make it manual mode. If the user sets manual mode, they get manual mode. If they don't want to manually adjust weights, don't set manual mode. We can't stop users from doing silly things ~Gregory