From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C49EC02185 for ; Sat, 18 Jan 2025 10:36:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99E07280001; Sat, 18 Jan 2025 05:36:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94E1F6B0088; Sat, 18 Jan 2025 05:36:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 815DA280001; Sat, 18 Jan 2025 05:36:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 647916B0085 for ; Sat, 18 Jan 2025 05:36:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DC59DB18E2 for ; Sat, 18 Jan 2025 10:36:29 +0000 (UTC) X-FDA: 83020218498.01.44369EF Received: from minute.unseen.parts (minute.unseen.parts [139.162.151.61]) by imf23.hostedemail.com (Postfix) with ESMTP id 0CC52140010 for ; Sat, 18 Jan 2025 10:36:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=unseen.parts header.s=sig header.b=yX0E5LlK; spf=pass (imf23.hostedemail.com: domain of ink@unseen.parts designates 139.162.151.61 as permitted sender) smtp.mailfrom=ink@unseen.parts; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737196588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c9nSAqqWxyLaQqHtxXscYRgnpeMDtXLRxxYGRZPtQRA=; b=WMv8zAytUjR2aSbzxffkt7X1nioJvyqKj489So3oN56jjVQCT8YW3/Zo3cdL6uSztUk9bR /W95ulmdvyiXOG7lk0NxevoigBQvLIxuW0NYsZiEM1uuwQsd7gz7aGNrUUwQ5AJHmn2lAp qhpolQWpabPGaEEL797nvU/72LmwuTQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737196588; a=rsa-sha256; cv=none; b=XdxMRjE7cYmDp8CfMdXSpBnma3yZ2XVE4mvxaSHO6eDPjzYgD1f2MFEn79QIu99eQQD5ca MwOto9DmX/y67JGB2qMHAc3303m0ykLpnk+Ig4nEWrSPz+9bR3WBIaIXqKpACcuJc8MjVV /I9GXmJ1sqLk4IZeoo57ZivAnIvCc+o= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=unseen.parts header.s=sig header.b=yX0E5LlK; spf=pass (imf23.hostedemail.com: domain of ink@unseen.parts designates 139.162.151.61 as permitted sender) smtp.mailfrom=ink@unseen.parts; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=unseen.parts; s=sig; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c9nSAqqWxyLaQqHtxXscYRgnpeMDtXLRxxYGRZPtQRA=; b=yX0E5LlK9F2HN4W1Zv9JcuRMTX qqomh8v1zoxquNIyyvGByazKGWw7JHdNxdbnv2e8QxK2R1DvLGhgucUJfYOi66IEreurkcfZR81KR 5k7qoIGAVBT4Cs1Ptu6FuEiNXRo/VUlP4fwsCouDBR+JKfWepdPIx9hiIL12wyeo8ly32hQKvqAmg pATkNY4JwZVfVWSdLDXoKe+pN8Fg6sj/CTjoRk+I6X9F2WrmjkGQ2onLIz1DsLeIWNnGOw4jTMapW N6DJNCaaDE6clMZV1JZtc7Bhb/wjgbmByiIlVMBDph8awc6rE9tZG8+/bQ7i6Nq1PzpmWkNQ8DrxB WpxzQz8w==; Received: from minute.unseen.parts ([139.162.151.61]:46722 helo=minute) by minute.unseen.parts with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1tZ6BI-0006Jw-1V; Sat, 18 Jan 2025 11:35:56 +0100 Date: Sat, 18 Jan 2025 11:35:54 +0100 From: Ivan Kokshaysky To: "Eric W. Biederman" Cc: John Paul Adrian Glaubitz , "Maciej W. Rozycki" , Arnd Bergmann , Richard Henderson , Matt Turner , Kees Cook , "Paul E. McKenney" , linux-alpha@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Cree , Sam James , Geert Uytterhoeven , Michael Karcher , Chris Hofstaedtler , util-linux@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH v2] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support Message-ID: References: <24f03227-1b55-4e50-b6e9-7ac74fda2602@app.fastmail.com> <678ee681-12c3-4e79-a04b-495daf343846@app.fastmail.com> <82d33a2d-dffe-4268-a175-4536b3f9c07f@app.fastmail.com> <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> <2758fa70d237ff972b0c8d7114777dc4a20c8f3b.camel@physik.fu-berlin.de> <78f3ae1f68842a9d1af62caaac3929834ce6ecfa.camel@physik.fu-berlin.de> <87y0zfs26i.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y0zfs26i.fsf_-_@email.froward.int.ebiederm.org> X-Stat-Signature: qq74m5i3oydpxdjwzzesq6osyh5gcp43 X-Rspamd-Queue-Id: 0CC52140010 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737196587-674538 X-HE-Meta: U2FsdGVkX19bpj88hwBEPXeQ1oPZY9H/c1B8XC3OW95Jw3U0OM8UxjSRAkMstKZtrhJDboMN6OoWcs0hLU1Vgd0rUWZp86g7dEFFfp7gpP15+2kRoj8YUnf3Oo6NAIc3vAiJZUlYQ2Aexfmsx4uJlYs34ns01ueVWaAyVXN5Wg45kkw5iUCjsWaS3MOTF44y3aw4a2tJntm0H1A+9fPDSm8jQV7QQ7yLgvpIePC62nbuSEHHknri95iwEGhiWBwfyr3OXGeBUNXOgV0hFhpudfXM60UbYQyoE71fEScvb/3iSAdhiR26Znr+1ngmIE7ywt8OP3rMbMAT3+ANp1ByBY/S1xfJcJ8ZeUSzyBN7JpxQrXYcV8hx8J3obkvvy5Gt4vCN+LDIstlFzcaxHmiqoj3AkRWDkof04a/nhrrY8s5tUVvzxizxdW1EI7ms5K1drs+OsiFJyKw6kKYHUrcSlcOeJRPdflYk0vlDhn8znOLSx3Kp0WDPOtbSswrsObvDdVgNswzgIA9TvgK6PMLmFvw/1kSSmKLIBcIaaBpBg1JtpsZuebZblKsQaFaIShU+l3/C87NDa83u9jZ8JeqVQa8DuQ8sxYlDbfLlmkowZs1mXiqLeUwpxvMl8BfWNBQXNSG0MZc+lM/J+glfzq/oniXMwKv8eu2rRleVEz2apq13pcoT8Ji8OqZnTpKllT/REGhF2/hQqaWAiO4N/nt5bvsYe2561muiFYr5WZCWoC22UZBl8PKEC+sJ6CEMsa/OSYWNLilCK/asFGYxi2C+kI+SK7Q8H0iClQw9NA2m63u7CJ+8n9ihF1aUif2JAml0SgeQ1cH8rrAxDy1RBPVA7ivvugyA1W7mBbZ9YSESmLGhBNQOIfm++rVKS4KM3avZcjm7vCiU120QszmaEbQPAbB34l0UiDpJ6djdyFK2TNNN+NMa3z6bp0A5DS4Uk+NvuaSDozTVzzRRhDyEIGB 6LcfOHQ3 oOCf+5Z+h5KDxJBkxCF/RdCszzIYkaZzgqzSrpuxp4Kgy2GvAL9Nn1q80SM5NMzwQ6W5DuwBrSMq/EO7QhelGovmqVGBvxrim8p6jEu4JYKtDxpw0nnmevGTt7uYJKYueQ/IEtVSkmUwZduLUMVxC027kczv/bBoPesq8LFJniBaSXf7JTrUIbbLZ7QpRFlal7wfs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 11:39:01PM -0600, Eric W. Biederman wrote: ... > --- a/arch/alpha/include/asm/pgtable.h > +++ b/arch/alpha/include/asm/pgtable.h > @@ -360,7 +360,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) > > extern void paging_init(void); > > -/* We have our own get_unmapped_area to cope with ADDR_LIMIT_32BIT. */ > +/* We have our own get_unmapped_area */ > #define HAVE_ARCH_UNMAPPED_AREA Just remove the definition. As the comment suggests, the only reason it exists is ADDR_LIMIT_32BIT, which is gone. > --- a/arch/alpha/kernel/osf_sys.c > +++ b/arch/alpha/kernel/osf_sys.c > @@ -1210,8 +1210,7 @@ SYSCALL_DEFINE1(old_adjtimex, struct timex32 __user *, txc_p) > return ret; > } > > -/* Get an address range which is currently unmapped. Similar to the > - generic version except that we know how to honor ADDR_LIMIT_32BIT. */ > +/* Get an address range which is currently unmapped. */ > > static unsigned long > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > @@ -1230,13 +1229,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, > unsigned long len, unsigned long pgoff, > unsigned long flags, vm_flags_t vm_flags) > { > - unsigned long limit; > - > - /* "32 bit" actually means 31 bit, since pointers sign extend. */ > - if (current->personality & ADDR_LIMIT_32BIT) > - limit = 0x80000000; > - else > - limit = TASK_SIZE; > + unsigned long limit = TASK_SIZE; > > if (len > limit) > return -ENOMEM; Likewise, just remove these functions. The generic_get_unmapped_area() works fine, tested on up1500. Ivan.