From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10F5C02180 for ; Wed, 15 Jan 2025 22:43:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253DD6B007B; Wed, 15 Jan 2025 17:43:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2034C6B0082; Wed, 15 Jan 2025 17:43:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB6D6B0085; Wed, 15 Jan 2025 17:43:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E3D2F6B007B for ; Wed, 15 Jan 2025 17:43:07 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 64EBAA0138 for ; Wed, 15 Jan 2025 22:43:07 +0000 (UTC) X-FDA: 83011163214.03.6616482 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 6EA578000E for ; Wed, 15 Jan 2025 22:43:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=kBexITCe; dmarc=none; spf=pass (imf30.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736980985; a=rsa-sha256; cv=none; b=2YNZWsuEmUVa/h37wVbeiNFYwUFWOTgLTPeER36cDKzHUcm6liowKkXEyyJm6RbE40h2K2 Zig42Dm5u9nQ68YPXR4RF23LUpSv34eAY1+fS7AcJ7VA/A8A4pZIpPP5Wf+FFElTHcFyg1 ykTB/E9T3B+c5JzLwOIeS+uPKCTIFZ4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=kBexITCe; dmarc=none; spf=pass (imf30.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736980985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q1YubPgC/8eI2lbaVxtAtUgVaIXVapt21tVigfpGQfQ=; b=hf91hOJ148MJIehSACuDNtCbCmVQF0Pdmu7fQpU7JoSIW0QwWgN8L9A1ZCahdvJcVAJyrF herTz9v3H75u0lBmooY68nKv6SJIhMdu10xVLH7nsQm1EsCjFmwb16dgS/zvwhzTjufHdl /xqG363oWpF/zVVRqbKnXr7XVtO28zo= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2166f1e589cso4761005ad.3 for ; Wed, 15 Jan 2025 14:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1736980984; x=1737585784; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q1YubPgC/8eI2lbaVxtAtUgVaIXVapt21tVigfpGQfQ=; b=kBexITCetuPG4YMq/iCrQY+oL7qvR+OVNtuQbhJ2opDVQwdcdOqQTzLoBCoG/pC1XJ EqCPUxc7TQ4XZjQ7e533XScydy+nfXknITbv46knxPq4VW7sOxvXLXfxqZ58ty9ZXKdY YvMl2Fj+sCLTgdpSKoaY3gTqz1IFCkub3ahmDAA6nEwWYOZNkzQFhIAoVNU0RDH1nGWF 17XbYVqZx8HRZVntIj8hMhfuV8UBqMvxmbeEPaCyfXoKAF+SkiL5bMkeYjAF49ZUjItN +0v+b/pvWtV2kFvn+DiIRIPufiTE1d2P0BFXvdODjGSOACmkBe0uWfiSo8NNDBhRQ9rJ FtcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736980984; x=1737585784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q1YubPgC/8eI2lbaVxtAtUgVaIXVapt21tVigfpGQfQ=; b=r3WWoPKhylk7e+PGbRNcxxH2Kx8hlyXWLbksDisNkirScB3+awRBuvVFx76oh3+kpv POk2m8XCmnzGo+YorSu9K2hqktW/gJZybxEJVNv/bk6P/7L0l6eM9fCxh3bUkzvg3kJN QV9aVoHY/voKTtGgwEWyQoasBx5dh+ARUXIiLbATOeeICvH0liwkgFBxxwR+9DvLbTgo 09ctGCVQ1Fnwcj3DHnjAy5IbkwJvFFxNBqXdNQxTd015kpeKQycwhEV3hCX7nsIKs0No Y842loleb+WvLso0N5NlycAcuYPvOJopKAWX0k75tBOEF4yZ6gYDxU5RAvIuQ0c07AIO DOaw== X-Forwarded-Encrypted: i=1; AJvYcCXwoX/nzqi8+4bX65xvH58+fysbqdWcHlc1Uf0Ee6cAVudoWwuDHTsv4U4Luyt5OrR/SybYX7pe8g==@kvack.org X-Gm-Message-State: AOJu0Yz1bpBin/ny9qGUrLcCeoCP7NwF1KpfuvNbXKq8ydYqT/WWyBk2 Eu/Rk2IhdIRDG4h9SlckwT2cZYmMpmDAb53+H0DUvCXNRypZz+3DnGGr90U4pk4= X-Gm-Gg: ASbGncu7M1W784rgdlN556rEp9wEf66HvxPPUbgalOjl//w5sIbzN7HQ4MCvNbjsxWY EmZb6m22acDxgZt3aLPvwHGrHPxSpvwf/R9/JWt7CWCvZYJRuNFEt0l6Kr4+JY/Y1wSlq3HitTI ps3J9gf04JwdrhBxzIe6mzTD9DN9WNNSVysQjeKCr/bWyLxnZB+nIYmFlE32/kg2JItQ2dSTl1B 2ed7+RXWsWdXJwPuRDMDMYKtWHEWFScXz4fSPMYYYJac+s= X-Google-Smtp-Source: AGHT+IHvvdjAhB26TfABelCo2yezRGgIVCLHqbk75eU3TNKSL+BscHjkrJVVlUgyTbGeTyl7z8y3Mg== X-Received: by 2002:a05:6a00:1385:b0:72a:aa0f:c86e with SMTP id d2e1a72fcca58-72d21f17738mr44987044b3a.4.1736980984037; Wed, 15 Jan 2025 14:43:04 -0800 (PST) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d405942b0sm9709309b3a.74.2025.01.15.14.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 14:43:03 -0800 (PST) Date: Wed, 15 Jan 2025 14:43:00 -0800 From: Charlie Jenkins To: Celeste Liu Cc: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou , Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Thomas Gleixner , Ron Economos , Andrew Jones , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Subject: Re: [PATCH v6 0/3] riscv/ptrace: add new regset to access original a0 register Message-ID: References: <20250115-riscv-new-regset-v6-0-59bfddd33525@coelacanthus.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115-riscv-new-regset-v6-0-59bfddd33525@coelacanthus.name> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6EA578000E X-Stat-Signature: 9oem9qodfznmuoaocspnq3w4aowpsabq X-Rspam-User: X-HE-Tag: 1736980985-710745 X-HE-Meta: U2FsdGVkX1/AaM47tlLsVMwRIGK7AYdwChZ7pAfbfyOigZ2lBEvznUV4rWbvNj9kVFUakX+lxW1l7EPg/5/c41CmXaMEbYv0xR7TqlBpgFH9Aw5k3yUMfbHNJQpNRlSsQzpawg3vES+4FA/2dAFJ5f99Bx3C160/Kbk6/Mqe/mZ4fKZO8QBcu5gPJcNR6sOmUYbgNqnKEolH4ylXfxYYQNkHrPdp/dy0vlHNTwlIW2KDZJh9bOEh8sUb93zzaGBNKgzSm9cpqWG0VSoCzzp8nHq1sLEq5n6TnkkgjUyG2H7LBq61iIU2wyimfW1DyixnAjm6pP/vV0PdVA+AM+uwj3iDuwb3J6t7ZEOC5g8r/wqGNfT2H17wmbZkroZ5E1CgJLhiEE0F3VFa7ee/WPDGeDy7zAGsI2hHnWA3I5oEP7WZqvcIKIbxvRUHbayF4vqWSGSEWizi0zrGH4XvWlBqhHuyYvemMDyqk6X5Fl1A2QcYCfhyplni0oAByqTMIfXMZw5V4Nqtc5YQcueBCov9fyX2UPeyxwxytCgreNvpEJCo7cCVVXp48GkNn9D0FQQRpwXyKcgMrpU2i90wO6MiTHSnpJaKKIYrHTSdHP8/u26SwySgPhZG5dtQFyZ8feKEPpm6MX/hj4yyBc9bLCO+UC2/yECROkgf+GPFqFxUqo92l3N8UOR/hsiJiqqSJ7e56MUFDyt+V3mPSJ/omatzKbWwMubyg9Qp8rbklHm74JZ7wNegDI7d5ke62M7mldvovsDdv4ELrjOJXbjeDWFzbZNlAsG38wwJHA0EaTBLFTyVIVMxNleBlDLhzB1MA2iXhdHHTdyZAyfTjayHrwBy/8Jel/WnqKxmTozs0pQonLwG224nM9jYnHX8Ox014vjQ2CV1sNgMO1t/ZPfJntjR6/9JXiIponX2Izm0BU/CGYe3c+LPex99CJMl2IF5SNHVkA7AAK7RyFIxOIG+Mtw Ug9r93gy 59SJUw1fNnCnhyrOWe+IVT0apG9YvkJARco3NwweeVvdlJrlR5jd7YsISkqaLOdpGPuZP01kvYF2mT6801aOanb+hmLBFcNfaQ5zeF3jQY73XOVerX1HO/OaNzxkPjL17LA9cLWHNDOo5jYhMhgHdrRvjoa5XdKjL9hx8vZRWIGbG/YcjJKBBPArII1KGh3BENnhnkRiZN5WGZdubw55CZwUyb6kV/KKNhFuoFU+JfK/Y1fUKn6uuQ8rm2KqkjUP18zDIzND51nDrwmMNBlldGdPFE6vvjntmLtwvAHh9hovsodK7W6E0JatUDCoI1fViERJOJlWTDhNC1G7QxENKR0K1khA0cmKL9XiWzX+RL0saK+WS+R4xcgtp9An8QBSlwDjFVXIPZX9S5rloeSFvQGGVOU+rzhwGoJa2RoXwQ4uu+A7LMpn4YRpvntkDNjDtQK+HZYY24V/6JuEE1zbzu0mo6aUw3+O4os2r+5CDpkdt3r4yLMfyKBQ0hQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 07:13:26PM +0800, Celeste Liu wrote: > The orig_a0 is missing in struct user_regs_struct of riscv, and there is > no way to add it without breaking UAPI. (See Link tag below) > > Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to > access original a0 register from userspace via ptrace API. > > Link: https://lore.kernel.org/all/59505464-c84a-403d-972f-d4b2055eeaac@gmail.com/ > > Signed-off-by: Celeste Liu > --- > Changes in v6: > - Fix obsolute comment. > - Copy include/linux/stddef.h to tools/include to use offsetofend in > selftests. > - Link to v5: https://lore.kernel.org/r/20250115-riscv-new-regset-v5-0-d0e6ec031a23@coelacanthus.name > > Changes in v5: > - Fix wrong usage in selftests. > - Link to v4: https://lore.kernel.org/r/20241226-riscv-new-regset-v4-0-4496a29d0436@coelacanthus.name > > Changes in v4: > - Fix a copy paste error in selftest. (Forget to commit...) > - Link to v3: https://lore.kernel.org/r/20241226-riscv-new-regset-v3-0-f5b96465826b@coelacanthus.name > > Changes in v3: > - Use return 0 directly for readability. > - Fix test for modify a0. > - Add Fixes: tag > - Remove useless Cc: stable. > - Selftest will check both a0 and orig_a0, but depends on the > correctness of PTRACE_GET_SYSCALL_INFO. > - Link to v2: https://lore.kernel.org/r/20241203-riscv-new-regset-v2-0-d37da8c0cba6@coelacanthus.name > > Changes in v2: > - Fix integer width. > - Add selftest. > - Link to v1: https://lore.kernel.org/r/20241201-riscv-new-regset-v1-1-c83c58abcc7b@coelacanthus.name > > --- > Celeste Liu (3): > riscv/ptrace: add new regset to access original a0 register > tools: copy include/linux/stddef.h to tools/include > riscv: selftests: Add a ptrace test to verify a0 and orig_a0 access > > arch/riscv/kernel/ptrace.c | 32 +++++ > include/uapi/linux/elf.h | 1 + > tools/include/linux/stddef.h | 85 ++++++++++++ > tools/include/uapi/linux/stddef.h | 6 +- > tools/testing/selftests/riscv/abi/.gitignore | 1 + > tools/testing/selftests/riscv/abi/Makefile | 6 +- > tools/testing/selftests/riscv/abi/ptrace.c | 193 +++++++++++++++++++++++++++ > 7 files changed, 319 insertions(+), 5 deletions(-) > --- > base-commit: 0e287d31b62bb53ad81d5e59778384a40f8b6f56 > change-id: 20241201-riscv-new-regset-d529b952ad0d > > Best regards, > -- > Celeste Liu > There is also this series that looks like it will solve this problem by providing an architecture agnostic way of changing syscall args with PTRACE_SET_SYSCALL_INFO [1]. - Charlie [1] https://lore.kernel.org/lkml/20250113170925.GA392@altlinux.org/