From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DB4C02185 for ; Wed, 15 Jan 2025 17:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2966B007B; Wed, 15 Jan 2025 12:11:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 252E06B0082; Wed, 15 Jan 2025 12:11:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F35B6B0085; Wed, 15 Jan 2025 12:11:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E47366B007B for ; Wed, 15 Jan 2025 12:11:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 64A40B0322 for ; Wed, 15 Jan 2025 17:11:47 +0000 (UTC) X-FDA: 83010328254.16.3A9D72C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 8E5861C0008 for ; Wed, 15 Jan 2025 17:11:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736961105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQnotGj8O8dtIqdw3qds2F4aUxndTgIwthGYOjx9Xqw=; b=I+vskIFnOKCMdXiN0Z8KrpDII/ubn5FeIMjbrPwcNloGQmLE/KHrHSaOhjl1p35NaIrLsg XMLG4F/PT4+UV2OQwc/ULOcvzZ5w4ayUxlFoPwCq9UeEHqmLlAHuE7tEDGB8Ht9JrmlBXQ K8m8Ix0JWlb/kuDPizA98i7ajaXCFoA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736961105; a=rsa-sha256; cv=none; b=mWCb84PmaZCvpy/uomEGTtnIsq0t4b1aoF+fgeBe/3TaRd5V2w28exv+alsX59eAng2Nuj PAm0CGzLlryM5cSaNE6sLEoPLsTuBFxiSOQ1/28XRO9dmjh1d8L6yMFUqLyLvaZZr0orSY kTV9YFG1yRdMzIgpY6rooGCRm59BeYo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4E6611FB; Wed, 15 Jan 2025 09:12:12 -0800 (PST) Received: from e133380.arm.com (e133380.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A0F63F673; Wed, 15 Jan 2025 09:11:42 -0800 (PST) Date: Wed, 15 Jan 2025 17:11:34 +0000 From: Dave Martin To: Akihiko Odaki Cc: Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , LEROY Christophe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, binutils@sourceware.org, devel@daynix.com Subject: Re: [PATCH v5 1/6] elf: Define note name macros Message-ID: References: <20250115-elf-v5-0-0f9e55bbb2fc@daynix.com> <20250115-elf-v5-1-0f9e55bbb2fc@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115-elf-v5-1-0f9e55bbb2fc@daynix.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8E5861C0008 X-Rspam-User: X-Stat-Signature: kbkz9kto7aowm5354yftryqf6jisz55n X-HE-Tag: 1736961105-741448 X-HE-Meta: U2FsdGVkX1+z2f8cbDybss5T3Tta5H0LxgRMn4Ndr5eKjrHqDQZGbEPCK5JVwIQzjuwCyxcxO0wWhZT/ho9Pcff83pWPKEutgPRhef/L1z40QbjkEFM9mt/xEh6X4v7bbZcxV8Z4EzjiW59ZlTU85WCFMuQaq+UAR3tJgZ/605MzZ54enXADATKm9k4vu7rrvrwOrLohPjmOiZJKypt7+8VWy+ueg2qxBdIYEhSXMl0Np1VH003yu6qqlKeOIx8wyGebgqpADjnQ7En5sSUtrRbABE+OA6/UAkiXEXu3cQ5FzzDASvS1ECiWcGtD490pqpIb7Tu3ragPXvStY55HaBo+XMg9/aFQbX784ZQ2iQ0/hQlI+tW4OMlHRabSOQ74gwJgUwuGIRjso4S6DGpTb9pHV5WLZPiMzm4M1egOfNxdjPHEALF5QBUkv/eBKSbtQmyWwh598MQnefHtFn9B5vxwlgcMoPbSPTzjiKN/czi8486Tw1iOqGAfcCIBjoHYxPraDYLOTC7gDDtIGym41wlxUF/RrJCvXJWlR0pK0cVkoZ6iD1OsCHD7d3VQNSJTOsK2a17GxyJ6Ssx8NqpwWjKRsm1sJ8LuAypxOz4HJBj1TlioUmX46w9suCohlN3SD2vZ/L/tN4BxLRk/6x3h9uob5fGgiH5ex+MzT8eAZB5AcNI6xRVDz+t+oVt4SWZjly+HXnfdjRF12hmzMntJKMuYZgRCkMMVa4Y3q7VQbR7QNzVaEjFg32F/mI1oJCQYssIahxAJkbZnp3jYoItCVzD4IZeoaQiEwVoHoYsfBHlcKUs4iruOHcfiV/89Gewf/1pOMIA4yTT6V39A+hLfDh9C59Mt7W04+Q6QYO9SLdaZ4OPU73pNXr3dETJUNF7wGDSLZh6FjtBbRv8slL0VtuVKDs+GPaGbaZ5wPsF74JPCQdOwpiL7F6F0fcqeihxVRu1pl23hTQEew/QeuDL eoQjrzYS cCCICLqP+6UfAyhPVLHgtHfyrYGZeM453DPTek+Cat5x0X/1Apcc47G2ah3r7X0ZzGjfJsxG9jpG6q8H6dMk8sjCtwaSNalXbFOG7ICXmuZk3OvHPfF7/Io1NfC39n1sfSnuQ+L2k875eJShHppffw+LObt0gwXGCHgpDxL6aSSa+kidb4UcFGjOk4O6YAaaexOKAhvYp2Xb0Zsy7V/UIRcXoZ7f8Y5+bdd8UATgJdOwBunXn9rocO4XGiEQ4h4xY28tZOG6nZNtyrYxX6+mp5HgvTg2kFyLNdz1A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Jan 15, 2025 at 02:47:58PM +0900, Akihiko Odaki wrote: > elf.h had a comment saying: > > Notes used in ET_CORE. Architectures export some of the arch register > > sets using the corresponding note types via the PTRACE_GETREGSET and > > PTRACE_SETREGSET requests. > > The note name for these types is "LINUX", except NT_PRFPREG that is > > named "CORE". > > However, NT_PRSTATUS is also named "CORE". It is also unclear what > "these types" refers to. > > To fix these problems, define a name for each note type. The added > definitions are macros so the kernel and userspace can directly refer to > them to remove their duplicate definitions of note names. > > Signed-off-by: Akihiko Odaki > Acked-by: Baoquan He > --- > include/uapi/linux/elf.h | 89 +++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 84 insertions(+), 5 deletions(-) > > diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h > index b44069d29cec..592507aa9b3a 100644 > --- a/include/uapi/linux/elf.h > +++ b/include/uapi/linux/elf.h > @@ -368,101 +368,180 @@ typedef struct elf64_shdr { > #define ELF_OSABI ELFOSABI_NONE > #endif > > +/* Note definitions: NN_ defines names. NT_ defines types. */ > + > +#define NN_GNU_PROPERTY_TYPE_0 "GNU" > +#define NT_GNU_PROPERTY_TYPE_0 5 > + I guess this also works as a neutral way of saying that NT_GNU_PROPERTY_TYPE_0 isn't _specifically_ for coredumps. I would worry that moving this block is going to generate unwanted context noise with other patches that may be in flight and add new NT_ definitions. But (a) changing the comments will cause that anyway, and (b) if there are any new NT_ definitions in flight, we want people to notice the conflict and add the accompanying NN_ definition. So, perhaps context noise is not such a bad thing in this instance. [...] > +#define NN_LOONGARCH_HW_WATCH "LINUX" > #define NT_LOONGARCH_HW_WATCH 0xa06 /* LoongArch hardware watchpoint registers */ > > -/* Note types with note name "GNU" */ > -#define NT_GNU_PROPERTY_TYPE_0 5 > - > /* Note header in a PT_NOTE section */ > typedef struct elf32_note { > Elf32_Word n_namesz; /* Name size */ Reviewed-by: Dave Martin Cheers ---Dave