From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B269FC02183 for ; Wed, 15 Jan 2025 16:09:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3877C6B0085; Wed, 15 Jan 2025 11:09:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3378D6B0088; Wed, 15 Jan 2025 11:09:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D7A86B0089; Wed, 15 Jan 2025 11:09:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EE9A86B0085 for ; Wed, 15 Jan 2025 11:09:58 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B01781A15BD for ; Wed, 15 Jan 2025 16:09:58 +0000 (UTC) X-FDA: 83010172476.06.FDF95BA Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf23.hostedemail.com (Postfix) with ESMTP id 9717F140002 for ; Wed, 15 Jan 2025 16:09:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TGQWq2FV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.41 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736957396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwXAmYHSg1qu4nbweDde8nvocc74vDmSDCEfZLTyfxQ=; b=y+HVehy4k0/Y7ihv9v4ieT9MAoibQiXheov4fK6esVSmyUgFiGffFiA60RGNqKh7XW9wFH SYBPmQHxYbCOgpOVwveuLFqbfN3/mnp3rjfEMdaFPEYqAMYlu3Rylhax4orTtxKfDUtT1j 3wWKNPpWxRBcl2KCQbqscMnmRB3SJl4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736957396; a=rsa-sha256; cv=none; b=uTwYxO7yrKDgrLtRuCDAHsULQeXIp1qsXquD5PHUvgILTFZIg/a7ImjlSWUh2sPdTUZfy1 KOJxZ70rwT+30iSTNmE8cnjnkm6TvWPQCyN7ezJ3N6w8F3LbCZVeDSo47ua9IxiXT7o1m5 Z8U49+IvNwy3xhtQ4z86UfGIUVhurx8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=TGQWq2FV; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.41 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6d8fd060e27so55182776d6.1 for ; Wed, 15 Jan 2025 08:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736957395; x=1737562195; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GwXAmYHSg1qu4nbweDde8nvocc74vDmSDCEfZLTyfxQ=; b=TGQWq2FVQMSbzJvS8Ds4St/s1vLZsjgTFexgnioBRcA9HcHSYAfvj7bRk31CHUDIkp a/5CVr3A9Q2pBCci5WkR4y38zC4VNhxd7anEBY8YLdriEFgUP4JVe5oWIBN0m46h8dQb cWNND0t4l4p7xS7NO6SbCrGqQQadS/Z3B/e8DWvlYlX9I6f2m1N+z/9VaXIEmc82BG3g SdLNO2PZgsE8g9HXsyzcfsvt6hZpTOSazbs5KBqlsrx5z97aQDzXhktN/R4umAaPLujx w1WbqrpCE/2QUbM8m1Wk9a66RBT7SsBoGFGbmSwWQqK00pgCYG7gc7lf72K2VldyHp9q F9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736957395; x=1737562195; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GwXAmYHSg1qu4nbweDde8nvocc74vDmSDCEfZLTyfxQ=; b=G3MoaP3GtQswcjzAsQscNGxcK69ZPBIfnVq+LYvFWTcheZgbGUYC+7Rz/IoLN+nmPL Af0orRjG2TRru9DxO6ab6FQ4gX4SdiCA+xFoPK/x2kS6gtD3JzZva/6MN5nHV7qva0X1 L9nR+Ptk9cNSO4Thk9Yfkms5CS2rzxnE4Kc2HlR/3KT3PiZSYPMWdn+8XubLwWmMg/sE EznKAGYAcXQe7zxFBnaBHcGpw7RqGrLWDv9mGWQgl/2GhYfpTGIHY327JBuSuiGZMg05 /suPLyNhsKCSfntjdlHpLlmXakKkE3ex8QR1YsijV3gm1EFbF1sBUUzq85Cz8hCgR4Qk d/9Q== X-Forwarded-Encrypted: i=1; AJvYcCVH24FePqmBthwkAlPWPnnUE4/CLxuPtRNJj52Tkf+7ZhnkCaGKc2TxmQVfy1ygQK6gwzV4/+KQRg==@kvack.org X-Gm-Message-State: AOJu0YxNH24IHAU0Hu2Vo1vFgSZwyUV83D6WqEfZdCG2SXUl0WYuHeoP D7skvxd1Z4hX3cec+KL7Ss21pN3kYRvIJgi0nRVb07cRmaJVoRqa2mFEU5uGV8Y= X-Gm-Gg: ASbGnctGZVCpF3uNVfDH7wwnwTyITf+m1v03ixIMdI1BC/Kz5Ww0TD8rd7T1qgRqj95 jeJhLDYf0PLBjwgLXC0mBDMxHaS020R3QuR4m+wmtHETjYZxxdQmRC5IIk7UDij/LfbuTyAwz0E QvQpOG3X17Hkrqr1yxdpgkVUY9sxHXVwNDeIovC5TzIl5Fj1vqXoVwdyNCw7cbf36mG7Xad7AfD fEnTA6oN1yRRuple7eSeEuSEnxofbvnsr7PRXH/rKaAU6AqyqkaginXNMzBsJao5Ag97UChwgBV DhEKYFyJcXW9Dgk1vMFWCAeBJIf70lT5++kaFWI= X-Google-Smtp-Source: AGHT+IG9OqVqrYpVRdGHwnGk+9cS+X1XN6JWtAePm/v/LzF+n+jP+F1Lb8vLGGkBvMZXfzAloxBmeA== X-Received: by 2002:a05:6214:501a:b0:6df:9740:68a3 with SMTP id 6a1803df08f44-6df9b2b3231mr538329106d6.38.1736957395661; Wed, 15 Jan 2025 08:09:55 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46c873cc496sm65947181cf.62.2025.01.15.08.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 08:09:55 -0800 (PST) Date: Wed, 15 Jan 2025 11:09:53 -0500 From: Gregory Price To: Donet Tom Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yu Zhao , Ritesh Harjani , "Aneesh Kumar K . V" , Matthew Wilcox , David Hildenbrand , Huang Ying , Johannes Weiner Subject: Re: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages Message-ID: References: <20250115120625.3785-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250115120625.3785-1-donettom@linux.ibm.com> X-Stat-Signature: k3e9bp5arqttbns7wsm1hy9fushgy4jb X-Rspamd-Queue-Id: 9717F140002 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736957396-389707 X-HE-Meta: U2FsdGVkX1/cc/0Z/dSRyZ2DjvZyM3mV4Ur/Bu0bfGQC/yhUDGaF3XZTWL50BZtLRB9zIuRsDAVYmhu+hhixSG0/r1Z5U59fmfzKqaZIPGcWZw81Wq6k3B9H+5+8BlHSMt934EAU5gCb6DYH/+d4bHYdA2vktKWXe2aZ/tqkFe6e8AuxvSjsnf/+65s9MhqMerLvPE9mzBLZVkYnWUaaVWFs4vRxH6msd+LAqm1YzsgjDvJpY0DJrs6J6+KQiPXj9UH1LTjUERD+97001Myq8x6SPkxtP2O7IVE0vNziqejzLgxnmEzCqyk3y8S31tA7aZSe+B9tayRH8u3DL01Rp1GuNpzg3LEwQOb+v61inkgPrDk0i6TU9sitZdDzgRsVbFkfVJ4bY2bxfWTqQmoRwoa7Qz57HhMG7q9DYbpxzWqhNDk835m9NxdAvhsaWcXkaPDwu+ORJXrWx4PCzqkwBCqtm3Hu45gpTKlfYI4ma35wXn7CnffNipyJkMGiGBRpsRtPcskonz28TEigFszPJVTTB583eiuX8zp+nJU4FT5r7TU4zygdG0Q3sZ3Tm37HYrguB3kHOJZPElRCOBENHWEzQnOpSf9eLDeWuZfQ9i9L8sy4xg5aSQkcgHnY8QNJu9Q9Z/F718Cz+BcKWS8pEg/s23YJOH/IrwDfWYSmtXgojgKACvqra/Y+yPxLPg0OfsnDsOX7aEQbJkWb1CGRSPD+JbIA5GH6g7F7SCTrekas2tfzbh2LjsVePvlQ8EWsZUClXKGzOHSZyMc+twJHScHhu9v51+P8uZ44Ut6VtlHPLXaDGadzBODVC8LRm3R6THMRTJF2+f7hLkvRwZ258hEKIt0wzTm+A6gwZJc/DoLaXwvNOXFNiqX55pdoNaiHx/OjOboHRS58ykZcYg4RuhQ0KxZFxG29+FSihXl0L2r5HWaCgx0rdGrUNfA4fvPy5Wa0GnrEYMmiCeI+mQm WEKyagbk QwyqkTev9kZE2DdX+oX/voJYkBCEMXUPFvVDQ6GC10xst817J9kt44WPCqF3/IG3bwIHgw7HmlQ2+eNHz9HfDWZSZjYr8f3Zsb1SMbSViiFwBYrORa9sLh2ZX5VUyJVrflVhTGP4cTH3Y5oaRQadq4fexv1Gqtgrvq2gkXkiBH7wH2jM8Fnop/qCLu7YUm+UaG0mOdKS1KgMV4GnEi8WnXaboHkUVKTXDt2Dwbq6DaiLEPUn94Ay/hoFCgIOyR/x+2h388yb9juZ+RMiuUIhmsw2cOoOX5lglj3dmm+yO4wN33cHwDK8ifVtiMFG4MBZfTFh9pxk1qUzlu5MxtU5hETlCdxDCBd0A4opZH5Xyk21vZgQanat8l8q1RBFOZgNo8ZsS7majMo2DrUH3+EXSyPXtfWLdody1ATePlfn2XwCxiGo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 06:06:25AM -0600, Donet Tom wrote: ... snip ... Thank you for taking the time to do this, I don't have enough background with MGLRU to have done this quickly. I'll pull this onto my branch and carry it if you don't mind so we can keep things tracked. I'll send you an updated RFC before i send out v4 and add appropriate tags. > This difference also impacts read latency: > > For MGLRU, the first read shows higher latency due to the combined > overhead of accessing a lower tier and performing promotion. > > For LRU, the first 3–4 reads typically exhibit lower latency since > promotion does not occur immediately. > Do you have a thought on a good test we can use to compare these strategies? We decided against promotion on first-access because there are many easy-to-imagine scenarios where that will clearly harm performance. We're planning to do some workload testing soon so we can get actual benefit numbers. > +promo_candid: > + if (!folio_test_isolated(folio) && > + (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) && > + numa_pagecache_promotion_enabled) { I am considering putting this in some inline wrapper with some likely() tags to clean this up a bit and optimize the fall-through cases since i've seen some measurable differences when left as-is. Thoughts on this are welcome > + memcg = folio_memcg(folio); > + if (memcg) { Also curious, why only promote when the folio is a member of a memcg? ~Gregory