From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA25C02180 for ; Wed, 15 Jan 2025 13:25:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F4ED6B007B; Wed, 15 Jan 2025 08:25:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4B86B0082; Wed, 15 Jan 2025 08:25:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C916B0083; Wed, 15 Jan 2025 08:25:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26E206B007B for ; Wed, 15 Jan 2025 08:25:44 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9F8B1212B6 for ; Wed, 15 Jan 2025 13:25:43 +0000 (UTC) X-FDA: 83009758566.09.0312840 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 81F7718000C for ; Wed, 15 Jan 2025 13:25:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CuejnQPk; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736947542; a=rsa-sha256; cv=none; b=jG1JYwcqiMw9VdJ3TFjjKi0wtk2t9KGaeiumZACX/Bos+KAk0hRt687p0q4lnc1d/bjvbq sgVN2ABHc4QnJLSSW9GbSaP4xW64iQA9FMDTi9jS1W1CGXmbX5341jkvNeCZuSMV3v0sOA Nsv7aPzq7D9vKgNcwENFgOdyxYf0dHA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CuejnQPk; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736947542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7tqHsk32GRVJTPeir0cQQtTbXibFwL/D4IJQVM2F+Ag=; b=DMqFLK/yDergw0bJkem4QBI+GpXITOSLd1Ng5InK3Fi3OOQu1+/V9saX3wD2okX7/BVxji gTxI9IYjxaQZe2VJX6axt8ozn6/16DLoX+OI7JlAj5xXh2vQ2xo2Eook7yNoQf17a0zR/C hZUGasC8I3mmFJ3A4KRJiXgfHUNZ5vc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7tqHsk32GRVJTPeir0cQQtTbXibFwL/D4IJQVM2F+Ag=; b=CuejnQPkBCxpD2n5BHFW0Wqi9T Baj6MJJpjf+Ez7KvwUD5chJZJrrK/DYcR1rF14aVvETwE5o6fawbl/P3t/pTfDENqXbmm/i1KLX2+ lvmxar/x2TN5gPR6epLPhQ3En2YaPDvekBXVM9TQ3NYd9N8gYhIfr4w4dew3dG5G+ANC/HoBsOBxK FG1M64QrKHOXNabZ5lj5L/Eof0AzB4sitHgzaHuFnpRunOU0L6+BsbqWFd54ROpI+AsiIGltrviZ9 T58MgZEUTEw2ZvbKiVQ5hm7ZFX6dxOoLfO02XafLM0tp56n6Zhhli9je/xonfb5EaPrUF8CfWCnbk adAIyQGw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tY3Oo-0000000DrFJ-05jb; Wed, 15 Jan 2025 13:25:34 +0000 Date: Wed, 15 Jan 2025 13:25:33 +0000 From: Matthew Wilcox To: Donet Tom Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gregory Price , Yu Zhao , Ritesh Harjani , "Aneesh Kumar K . V" , David Hildenbrand , Huang Ying , Johannes Weiner Subject: Re: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages Message-ID: References: <20250115120625.3785-1-donettom@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115120625.3785-1-donettom@linux.ibm.com> X-Rspamd-Queue-Id: 81F7718000C X-Stat-Signature: 1ft6tbidba8fkfmbbywkh55wtijfwcwc X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736947541-71255 X-HE-Meta: U2FsdGVkX1/Gh18Qye2iOmI5e8dLKsg9Y6U0DM3dqWYAcKPqC2nnuJlxvq7Wusi2/fyo/HKJHjq1eq9J/sSu19KVarXOUC3SGoTDEbEoi5IvGd9kPjLmHV/Zr+oqhadoSngaFKO9Et3Sn3LCKKP90R9BUKbPY+8cvVynDsX+vrDtakCC2shoRWFhfIN/z0y4A7ERBQwAqat51MRPfPpvODhmTQEu3EnPI/jYnNpXmwFva0ursPHv4qHzQ610HKA+FBNP7nAPctZX2+dx3shTDe3kscqgKdcvvohC0RU3TD+faQohJF7VAPdL1ckYHfG05I8CqH/MMog3mVgLll6nbB1RP4l0gY8EcQYgV7YMAdrF9kILnl3JKYVHpd1jDYHfS+fVonm9MOTQUZdTnnLhpjzo7GftU7+euCj0YxYkZ//Rx6q7sQlrrB5HOUbm4R00B2/ad/cnlNXiZduUDBcCdI3NOQeVMYOBhdMYkt+jodEUDc9T4qiY5+z/Y4W3bvjCknLrGUMYDKxwC8f/bOvfYfqUSlpp+UeuaZhE9sQrQin/h7k3kvwC5MAH4oIBBkUWzM0BNX4EOnJadBjyBCYaMM/u3rXygP8qGsbMUv0wUa+ynWGh8js8eVZt5p85vm5f3cKIuZFCpJ0ng0JH4UvAGlu96HnZeSCHHNpYbq8J//W7Vh1HY+jBfdbrAWuqZl1/5ST9rG+DwedqDrnKDwYSofxpaaO9cvnREpZC/oxe1qqXE8WbfiKDn8zZkQ4SHv2VXvWqdqjTldo0vhE+EFqSz0W6YRdURtCMNon2HMzTcc0u2eYPP1V0C/HbkkTmEqUEo/WtNC703FPUjOhP69nqn3KdT1j+HT1fkfHQq1T78ZL4UfzPDaYhg8U9AHx2pLKhUwQvNUTEgQWqbWBQ3o0jUXRBMy/ojTwKySHY9U2mvN6rbxGFe2+TKrs2DELVPrM+56s5/ZIf/rS1KjSN+l4 4fCSCHrl YQ1G72pOmxef5aq+juJ+q6uVUVf9B8O5cVa7pNj6ENMEAz8qeUf1UvAyiZYmaXTyYMYfg5COj3GoNaLglRZe0lYDE4/F9GsYcKJJ3PId5Nfnm7h4ACzxJK70q9xl9pChJ52xLdopG98d60OxG8B02IXrsnlHVjespaybyobzn3JP17K2g1dvuRtgSGPHyD0WcMSKcyUpZtNt9SHkamM4JBKN5Ej3zkur8sOw/c1J0cV283guqa7GtcTYcIDQICMQhfizjlMTbs6Ca5NnpyW6aplP+psmlsUiJifYzQBKcMvOWoYQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 06:06:25AM -0600, Donet Tom wrote: > An MGLRU page cache page is eligible for promotion when: > > 1. Memory Tiering and pagecache_promotion_enabled are enabled > 2. It resides in a lower memory tier. > 3. It is referenced. > 4. It is part of the working set. > 5. It belongs to the active list. > For MGLRU, the youngest generation and the youngest generation - 1 > are treated as the active list. ... why do you only promote folios if they belong to a memcg? > +promo_candid: > + if (!folio_test_isolated(folio) && > + (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) && > + numa_pagecache_promotion_enabled) { > + memcg = folio_memcg(folio); > + if (memcg) { > + lruvec = mem_cgroup_lruvec(memcg, folio_pgdat(folio)); > + gen = folio_lru_gen(folio); > + > + if ((gen < MAX_NR_GENS) && lru_gen_is_active(lruvec, gen)) > + promotion_candidate(folio); > + } Should there be an 'else' clause here? Or should it be: lruvec = mem_cgroup_lruvec(memcg, folio_pgdat(folio)); gen = folio_lru_gen(folio); if ((gen < MAX_NR_GENS) && lru_gen_is_active(lruvec, gen)) promotion_candidate(folio);