From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EEEE77188 for ; Tue, 14 Jan 2025 21:24:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72CD86B0089; Tue, 14 Jan 2025 16:24:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B25B6B008A; Tue, 14 Jan 2025 16:24:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52DBD6B008C; Tue, 14 Jan 2025 16:24:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 30B706B0089 for ; Tue, 14 Jan 2025 16:24:26 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D18E6801C4 for ; Tue, 14 Jan 2025 21:24:25 +0000 (UTC) X-FDA: 83007336090.14.13153E9 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf27.hostedemail.com (Postfix) with ESMTP id E2E754000C for ; Tue, 14 Jan 2025 21:24:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TuzqdqaX; spf=pass (imf27.hostedemail.com: domain of 3BtaGZwYKCBE9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3BtaGZwYKCBE9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736889864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cSsXdzV+ZwQOEMikMUZ9KmnzJy+D1+up+g+W/Xr/ho=; b=0DmbqoDc9ecDZB1x0y5TLIIZ/iD4ulv9fHh697DR8AkV4MXTtEvF7hKLtt+iDFDKLODl/P tbnCiSW/KUBiSCWMpivB5mjmG4WXtKUxGgnvtmzRwkdAdN2zS15qNzbthH9ZclNS8haFyo J+M6vS8MwyZ/FlWglIa7GTgMy7HDGXY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TuzqdqaX; spf=pass (imf27.hostedemail.com: domain of 3BtaGZwYKCBE9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3BtaGZwYKCBE9vr40tx55x2v.t532z4BE-331Crt1.58x@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736889864; a=rsa-sha256; cv=none; b=2ZM5ah06d+3qdbMRas1v8m3QmfwsS/zYbJoggU+AjWDBD47RORSF++wzVldxF6DOgJ1rOr W4j/gAhdcvgxfxQh90sBjgQFiSssLgZmva6X83Rf9GWi3G+2y+N6UhbRBjkDhZk9/ENYy4 Vf2wswwOL9pYBikJSJ1ywuv0FI2ogzI= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2f129f7717fso10845993a91.0 for ; Tue, 14 Jan 2025 13:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736889862; x=1737494662; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8cSsXdzV+ZwQOEMikMUZ9KmnzJy+D1+up+g+W/Xr/ho=; b=TuzqdqaXKqouWL7jZ2RGt+4lVD7CCVA724S1a+xF4dyDjcXBC54kL/oZ0P7XWqTGsn w945NbLQ5mpAQBejQNqhCKzTiJfixOeDTJmKggXjhEVG+imCO3rmTJpzcNBas8sbPvCk RqFTPRNGfT0ua9FEbJQMAxMLXfEQg35ZQm1qTcreUJKtMMkT1X8QXBYDqsNgwWzanUnz FJdKHhnmpO+Pc1O6L3qIyhj/ETnSGE1gGmjz0IVb6/Mx6wu1TEmNS9K3AuLmBcnsCWCS kS7+AWToLP3Ig1smOfZVolra6u6jOXkotUtWM5OZNKUhPFfsmmFOraXmjye9SnCK8THU lkYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736889862; x=1737494662; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8cSsXdzV+ZwQOEMikMUZ9KmnzJy+D1+up+g+W/Xr/ho=; b=Lev6UAuZrULyAKsNm6JW56VaiPuGJTt1nJr1xPJSCFIJz53VbMDJgZqjzuAGP0C+tf PELN7sWLVeTQt3DQGHb3Oy1I7KcyQ1YJ517L0Lz2BvbuFuNA87R7/ypT74ltc7X0ieN6 W4upH4UAt2t+14IzZieh1CID9wMnB02kgdB43KJYGh3Ko3ksorXNctdftMvVqOEvqbff 7SDPxHMRXhrb49XIGWxJcfNnI+3YzfCHTAO3Wh+WOlgmmaNRFdr+irsjMxr1DJf1Cx5N WUP5QqFOhj43EgAWUQHDeBQHqlFxoiHtCest6fcROYiOeSuoHFBJ8HAUFPQZ44ifOGGK D+DA== X-Forwarded-Encrypted: i=1; AJvYcCXSxPpT2tqhXKCJvxnJQU08p+IyhM42ZwpIu+mcWRxI6B1bsiu/sKk0OxoGDv3yznKmHvKYjm+jfQ==@kvack.org X-Gm-Message-State: AOJu0YyLfNOpaxhwSdWowG2QK1oo9+kizOzMXGn9ESaOCNM0zgNt/sEc zJwuK6MusA28hXNR6VYbrxYKjqOI216n8/Czh28npwtC8l4tigtcdqfEgqbXacjQFRng5hK7e1D o+Q== X-Google-Smtp-Source: AGHT+IGaqEwoic7xvDyznY8cDg+F7K5+qe11MRhfXOt+1PBXtCG3HV5nSK8yv8Q3/q/HTXMyOsqLmKxvwkg= X-Received: from pjbtc8.prod.google.com ([2002:a17:90b:5408:b0:2ef:abba:8bfd]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2b87:b0:2ee:8031:cdbc with SMTP id 98e67ed59e1d1-2f548f1ec3fmr32208440a91.23.1736889862547; Tue, 14 Jan 2025 13:24:22 -0800 (PST) Date: Tue, 14 Jan 2025 13:24:21 -0800 In-Reply-To: <20250114175143.81438-28-vschneid@redhat.com> Mime-Version: 1.0 References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-28-vschneid@redhat.com> Message-ID: Subject: Re: [PATCH v4 27/30] x86/tlb: Make __flush_tlb_local() noinstr-compliant From: Sean Christopherson To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E2E754000C X-Rspam-User: X-Stat-Signature: qbwgdmjjiokebmo3ejqnxzhdmoqfrw83 X-HE-Tag: 1736889863-281359 X-HE-Meta: U2FsdGVkX1/qasMhZmbYqAFB9NbTXPXGc/uzje8GXSzOhgQaA2cNp+gTs9NYaN/ByOKy+fyb5uqdSgkKBDB0F4MutmZVQafVmUW+8sY9Q9fmLZaoDxHEy9+JG2DQpw5VL8oUDUlTbJt75YNxpBMFYzaCLJWJZghcj96c204/LI3ZzTxmJLVvfXMZuqcmmaugORJzUnSMv9kGCAJ3/IsX6Mih8QXfNMGBRycRd3I1J4I1XITA7475j+tPA6swxPpYwsD/qRenoULFgFWrJ6oz7LoKre7phLRqpPxmfdZpw6/51hz/8x0Ni09ib5hcEGyu453/W23h/EvWDOymkWtEfaxyGwBptfgCFpBgZKSNQr820huQBAdYXbPxbGqQpAUsbf4p2oU3BZi4woDndC0ppHWI/w9RltfIZv2TSZybXB1CKBbULr6r+pWsQBb9hhqhl46j2snb2WktTOTwvEz2RC1K9h8Sj92wG8fIl6wc56QF0qxTtWsfDhmp5OZxuEzGakjx73XJsXXb8gupjtm9IjoHvibmS+5zwTbi+ue7jIjwDulUi5RoQrT4keX6ws+nNXl4M9OD/tMLjsGL1HwhTG78ySXGzenxJeo1CWrF9jt3rEbb0lzJJ93ZiZdlySoVgeAtemSFxzoQoHISVBvE4op5v355t2ZY8rkw5SCYdA/9wszai6dyhUNJVhgiNfJc93eD8WshMAXdDNJgePK1ZgMnTEgmpKlcLt/Vslxw+QqIGM33Dg3WFNiux2aGITR/Jr0nHQXnyDTVONmjno/QpvfQ07JddM9/mqInhTuFSZ3ndxQIiniS0238PXfHCkULwSc3doOOzjroS0V670oJoRetkdsYveULZ5dX29puKgdooR/piZ+KaygmNi1zRtFTdz/Roge4c6Cx5at+Hlbz/Aa/4Sgqler9C4AqDNBJG8HUwFh+DLoxT6xTWvtI12nUtiA+XB9c9c9rEh8tus8 Vx3vyj+E XlbkubXVNrWdz5yMlWSomS74ykcFxX4VbSwU2i3OsK64sEYoUq+Lg4TZURW6f4q2t/l27fcJRLFwt+3DDb28gkgLyWVgzETeK/ePnPtS9Q9LR4nuCsqQBr3LILc6Bu4S+C+qoglXhKPgu38Ye4PGAzfdvXlwGTiXD9armD2QSnVy1nRB4Ac1zpTRtQ8xG7V3NS7NxXzko7jf5aQRqiHFnGlqqpS9VRTcnAaxDaR5uXEvQpmJXWKp3A961ZRCrfLmpyXcJhOhLy30gkt7YnMK9UbLvQ9oqCHqfBwKLoDhGisHIAL84nfy5tE+uju+hfVeicnDDZYXlmcHBhkgjO08TcPQPUGdvh5vWCmFiYC/EK8ZAIv/tI3txvQStmJQI5i0xa8MUE6+dML6UvOyJg3dSZq9n+jNmQZIBmZyTr2iNErUiAOXWZJqi70bYFHaEKPzfw8G1+ouk5nL33FMWG2QcI4X8DbaB7ElPrLr8ppMDpaG4CyMx0lxrpBbv0serv1MOOCn2pNlqoNJfCsmC2d7vHXu97t18FK3pOTO0yslNXprMghRa2zJtd7JPJd6k2fEXK9uV2sC69RFpAwwU4XD2Flqs8gjRuyXS+gc8cNLVE6KPlK/qLXgUzQdlVvo4wHF8TLBHCSeraZGsJGhkZrzzWNb3anucc69trHMSESKXUxhYcINE3hHcSlIyZ3P4y2pRD5CqFOeQ++FGrHn52rpk+sTsQmnhzwSHTbKn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025, Valentin Schneider wrote: > Later patches will require issuing a __flush_tlb_all() from noinstr code. > This requires making both __flush_tlb_local() and __flush_tlb_global() > noinstr-compliant. > > For __flush_tlb_local(), xen_flush_tlb() has already been made noinstr, so > it's just native_flush_tlb_global(), and simply __always_inline'ing > invalidate_user_asid() gets us there > > Signed-off-by: Valentin Schneider > --- ... > @@ -1206,7 +1206,7 @@ STATIC_NOPV noinstr void native_flush_tlb_global(void) > /* > * Flush the entire current user mapping > */ > -STATIC_NOPV void native_flush_tlb_local(void) > +STATIC_NOPV noinstr void native_flush_tlb_local(void) native_write_cr3() and __native_read_cr3() need to be __always_inline. vmlinux.o: warning: objtool: native_flush_tlb_local+0x8: call to __native_read_cr3() leaves .noinstr.text section