From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDD8E77188 for ; Tue, 14 Jan 2025 21:19:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD0C2280007; Tue, 14 Jan 2025 16:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5851280006; Tue, 14 Jan 2025 16:19:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D1EB280007; Tue, 14 Jan 2025 16:19:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B98C280006 for ; Tue, 14 Jan 2025 16:19:28 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EAC35160482 for ; Tue, 14 Jan 2025 21:19:27 +0000 (UTC) X-FDA: 83007323574.11.0288216 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf23.hostedemail.com (Postfix) with ESMTP id 38F7F140011 for ; Tue, 14 Jan 2025 21:19:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OLPTA3gD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 33NSGZwYKCOMXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=33NSGZwYKCOMXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736889566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XVbipT56M6kECF5Qh7elLUxboyXWurLrq3UYAkefsoQ=; b=ZPYc4ivjvWWfSxa5pw7l9VfWbVtwFWXeNPVMifl+8ZkSmQKWzsf4LHUewS1aYsXMvjXhOi Cmie+zt2812nLl30ySQe8G5hLqCwmOApg1J20eEr3NMEfumsCC00fjmxojP4TAwdcUzXGH ldmkAlTncryJIeJnxCqy3KCt7SarT2Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736889566; a=rsa-sha256; cv=none; b=aVZHsFVtX30i/ogvtJhKiBguix8fNPv12kpDhEAeKS9EfSrIPKjJ2kIdGEbWrGk2w+sC8S z8iQ5gfF9cmsKE1LasazUbo4LPrw7J8v2ScqSZ2DDungUEcJXdfevOGWpfhER5d57FaSZI wTH7HNOeY5AyQ9WxnmvSp448fZA1ltg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OLPTA3gD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 33NSGZwYKCOMXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=33NSGZwYKCOMXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-216717543b7so151099425ad.0 for ; Tue, 14 Jan 2025 13:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736889565; x=1737494365; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XVbipT56M6kECF5Qh7elLUxboyXWurLrq3UYAkefsoQ=; b=OLPTA3gDefk31mcaspy0Vtt5ukH73o9nqFFEKEPXe6aI8T2uuLyePSzZoTlnFEBvoj Ioghn9WPwmaXiYo0RIGFuLgAIcDB9waSikJyq6h2cxc7fXaFatdPF7ABs0JR/NOwtXkB ULnx03p8NxZGIddWRj8q7Ws5khV6GtqkpATRhzgxGiV+7RdonDC7bwpy+/XL2egv5uq5 05KQy2G5gEmWwfrdgcoGneRbqWmAiZ9AnAWBKnevmSzkE5VGUj9snn2Uz98zR5z45nlT Wy3hCLSk9Vzx+gfyf19sFbdoKqgmqjJgtFWlAQ+cu6qspQNVSGc2xKB4vg075z1UDoT0 QNGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736889565; x=1737494365; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XVbipT56M6kECF5Qh7elLUxboyXWurLrq3UYAkefsoQ=; b=tSvFOCRL4mFsQ53pISP/60MF5uLnzWjnq1cpDFYp1fOlxty1xeorH7PpoVjw0lFRw4 IfJ23ph+JXSiErKyAkpph8I1S7BUJVTKtIaVcQl2P2BKCXyUpUUYAbW7x5d+V+lwcvWr rs5/XctOjb3ToHCMg5N1/Q2H6IUCbr+IRcz3rlOJa3tESgB726h7GoJfcsUVxkbaLMGL uD6PGWj9sdxRnxZiIHOgJKFPB9hB3oZq6jlqy98hoZFEl7H7Qrw21e3em+AogbhOrFMP X5AGSKlqRe+g0aNe9HbplkwHs55MMB0Tp/D9i/IEoDLttYIlRuk7/B4CEPQAfHxv8/W0 PWew== X-Forwarded-Encrypted: i=1; AJvYcCXWrZ6174P3IjtXnOda42cXR1VzEKJc6aRt1E6pAOsSzzWDl661TvKCbyHdKo2Hjh6DQdcngULQQg==@kvack.org X-Gm-Message-State: AOJu0YzY/QaMy2qh57eVmTB4k6ResHi7ErYVhLBATH4F9DQIZeATuKUB rsnUejdvgTl9F/HMn3agr15pyb9YVl62mj+iu4MbGUhUqm8uOqlYIgy2N4PzgzB+GPPGn7f3Ybr K3Q== X-Google-Smtp-Source: AGHT+IGTMIc2Hr+w/ebVVGGlbFAB7WFV7TbQJLIjfH34Jlhrw+YYPMlrag1B602JmLWOQ4sU4fLE9W3Pz50= X-Received: from plap13.prod.google.com ([2002:a17:902:f08d:b0:217:8109:e87]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:cec1:b0:216:3dc5:1230 with SMTP id d9443c01a7336-21a83ffc1dbmr401799985ad.42.1736889564696; Tue, 14 Jan 2025 13:19:24 -0800 (PST) Date: Tue, 14 Jan 2025 13:19:23 -0800 In-Reply-To: <20250114175143.81438-19-vschneid@redhat.com> Mime-Version: 1.0 References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-19-vschneid@redhat.com> Message-ID: Subject: Re: [PATCH v4 18/30] x86/kvm/vmx: Mark vmx_l1d_should flush and vmx_l1d_flush_cond keys as allowed in .noinstr From: Sean Christopherson To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Josh Poimboeuf , Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Boris Ostrovsky , Pawan Gupta , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: b6fok46987ytgig8j6hrw38qrrhphbka X-Rspamd-Queue-Id: 38F7F140011 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736889565-361479 X-HE-Meta: U2FsdGVkX1/OY8qjIVC30TSsMXYNoqwGQzQLp2oyrX+Y4pYwXWSJk5q/I7yADLfJVLttaXDWv+czj8APY+CDAjR4gBiEZBKugcpAIGz+D+e0GFpdjlbgzsaaigWZ5G6J02ormm5n+nx0FJMIwmfylhtzQY8g5y0TUg4M7YeQqMrz/7/SJq9r8aCcsjB+uJlED2wle7/6D5sm9fFS7ctpp8ssUi00wLuU6yXsgyWwzquOFznCTZruWgXfSH25puc37qCunXHuEp80S5jvjUSbOr6gkw7+Dm3x6pGOY139Uu7jVy9W5JqYNqZu2ovKiTFXg0jRq+9YSweKJX4xUiB9/zDGQmBVPadSCjI5rlbkYYKWbNWz2UQV87t6jfeq8oWK/jKgnUD9vPiz/12eOLfozTfRKtVp9eE8hGqGbjCEUpk0qWS1nwgBhuYRh3zTbuQ4ZnpIJnK4PjNCU9KEihvlIXvTmxs9EZnHWXVdY+U3V7S8Gt6+G91f3qOHFUG3/BNKOt6JjmYs81zBzr4QWwnWvogZRnW3xvXIBU5Gq4M3YQVJFnej21ANzfib4XtAenLQTI/f5wl5Rfgj2hppfzPKvlG5ZbtfUmCRDRXTmut6a13xObfZiZmDVtxvyuD5XxSk6CvUastF0qltmRhuEnSzlL21t5YUrDi4J/uLh4Pz1DC0wo57H6lwS566BgD9LffGuU/pvfjEQVOeXH6UeDvPmgH532tWonapf05BI+QeU9su1l/fIdRzgRdSuAQKipAQYtl8BxbRHgVFyOgwZEhTBbC3DNaiAvFZwxvFDkebYRbmJzZiwUO+VDyD+DsO3jwFS5xYKBjH9R2A0qbO1W1BYAOLnibya+pWbuvFLrgXr6E/hyyzJr2RKxslgnp606LNPUZt8Xd+39mj9X0RSA9W0p4krCoCq/Wg6r51BubW51Yk+c5mo/wqvyYz5ePzefNpyXuTUXNxCMw61bwDcmh hnPgVj7d pRp6TjoTWoR6HQavykfSq8k12I9Sgb8IM9ZCLRQGK88fYKH02JI9zASRRTbHpzj90ZFHcdYL+DCUOpZ2dq2kemkxXvt/hldQN3qf/RMGkdZnISYHF00Xm3rK9A1Hq+2JBrqzG7UgM1viIvqYAYkG68rulDApLDYPzwROMJSxoACndSSBq2fk/1YBkBt4V/5QTCUi5d+lVcZGbFpHhNhS/JY+nRQX9rqmbuvUa77hVN6Q55isQCmogmCaZJ++qjAiu6xKH8v0i0HnMGKqUzMf0n4MmnCO3vaJZPlFb9AX2JtZtiC0Vt1uTgmeh+cFuKctPD85labHpqJD073IrEVWwyXjzrlKmgHO3ya6dcaEA3xCI9RkkrHLHoAUF4D60M9jsmMno6DiTML8Loe76Ltnoz8PTen3yML/25ax2N7/uIyVJmXmyj6xbe4avaTC/gI8yx/sIslU9W5rxozNUsjTCn6U60NMF6cP/7R6BR5Q69QMrzAgs/WtC5v3aVGHlBuxkamz9o9R55flpCtTjKz+oLtfpotKT7t6TEEAH1B645o17bOoOGE1OCMCubOmq6VU01WYzRA5/rCRlD//p954i0yvRCV7YCdE/Tmgw9FcQxAG+wL7U0EyjA0WbPCR++Po6EPAjRtqWDpttRv4H0uETt4RLzDYUS0xR2QisgI+nUsCLKqi2tV6GZ3UQzsE4WmmSGR1qIxPBW0Dd4XQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Please use "KVM: VMX:" for the scope. On Tue, Jan 14, 2025, Valentin Schneider wrote: > Later commits will cause objtool to warn about static keys being used in > .noinstr sections in order to safely defer instruction patching IPIs > targeted at NOHZ_FULL CPUs. > > These keys are used in .noinstr code, and can be modified at runtime > (/proc/kernel/vmx* write). However it is not expected that they will be > flipped during latency-sensitive operations, and thus shouldn't be a source > of interference wrt the text patching IPI. This misses KVM's static key that's buried behind CONFIG_HYPERV=m|y. vmlinux.o: warning: objtool: vmx_vcpu_enter_exit+0x241: __kvm_is_using_evmcs: non-RO static key usage in noinstr vmlinux.o: warning: objtool: vmx_update_host_rsp+0x13: __kvm_is_using_evmcs: non-RO static key usage in noinstr Side topic, it's super annoying that "objtool --noinstr" only runs on vmlinux.o. I realize objtool doesn't have the visilibity to validate cross-object calls, but couldn't objtool validates calls and static key/branch usage so long as the target or key/branch is defined in the same object?