From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FAEE77188 for ; Tue, 14 Jan 2025 18:37:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39EA128001D; Tue, 14 Jan 2025 13:37:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E6228000F; Tue, 14 Jan 2025 13:37:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23E0828001D; Tue, 14 Jan 2025 13:37:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0605628000F for ; Tue, 14 Jan 2025 13:37:11 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 606F344AE5 for ; Tue, 14 Jan 2025 18:37:10 +0000 (UTC) X-FDA: 83006914620.15.81F50B5 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf08.hostedemail.com (Postfix) with ESMTP id 80278160016 for ; Tue, 14 Jan 2025 18:37:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Hq7CGt64; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736879827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uci2CxDdUTcor4Mocplroy6VPU/3I3PJ+VGlYKC6Dl8=; b=IrFtx7JsWQOz2NNWUYE8TARwot55vOcodeoXNiX3R6P2sN/d33FOJ3zWet4ZF7nPPijCta xI4WBqcpk69MdxVW8mmEy5A/nqyvyaok9zd8nXVPmpG9GAj5kdoZUIRpIgNBeJpkfM3Qsc NFkOuomaxacIJm+kLdctppEyauy2nKQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Hq7CGt64; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736879827; a=rsa-sha256; cv=none; b=heIWClRDCU6xAHYdOiWldku6u0QA+MLqLyDVV+FZHLB9FN1osRtnD0GhW4CwT39/6g8ajd FckXFO+deWbwC8FVjeNzv2iVdROC4TQshq1ug2MCW/8Cjb08g+NjCuftfIvHJ5sEUl/NQH AOYalWDqrA/VCvZ76+/rW9Q3DUjL16A= Date: Tue, 14 Jan 2025 18:36:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736879821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uci2CxDdUTcor4Mocplroy6VPU/3I3PJ+VGlYKC6Dl8=; b=Hq7CGt64ZlG4Zrwq3yMhjDi/VU/rIvX+OxVuxjc0cFOU/SHhb3nDqLzoA2d2IpWy/HP6UP U0dBGsFY4I0IJSRQAmvojnWjTjqxK5qi71/kgLNnB7hJPbTYcvS2hKQ6DyJL7nKk4gfDIM 0dQDP+4yS6fk4MC31yJfkaIKWVj6qrs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH -v2 next 2/4] memcg: call the free function when allocation of pn fails Message-ID: References: <20250114122519.1404275-1-chenridong@huaweicloud.com> <20250114122519.1404275-3-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250114122519.1404275-3-chenridong@huaweicloud.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 80278160016 X-Rspamd-Server: rspam12 X-Stat-Signature: 991fgiekyt1hiajtdeiyw6da1fapq7u7 X-Rspam-User: X-HE-Tag: 1736879827-203287 X-HE-Meta: U2FsdGVkX19ozuWYmptRPxYUPNOrPxV73m6zyF4bNOABbLxUhSRhe7n1vgAzzYo+gtE+VurRmC0lOSMYK2Hv7zMES3/pQAoWmt91PbSR+BnZmenOSBpyh07TA/KgCqM1tYucFMTjZSyDWbQ4xmheSe23UCbdyWtO/ghHo06AUWq7PrWAZ1wc3OCqO2c1nY2b4xGOTMdMx3z6JV38d+HJgt7xLvnWt2O7jRNE1rqFaIYq8kk6egPukTeCDSWOj9Tgw4YzX523ZFUW547PsR8SabHZqQcvEJmT+NoJi6Ba8S1vRRssASW/QVnkzF/krR7r+PtwHv/e3cOiItrW+zRv4In6FTHLPHDTuLvGL1Qvw8g7YVNCK+mZXDYc+X2zY/sSSBZcg9ydaZdiKfEhgmnsiVCrjOz+5oQDrcRLxqiLY6Ro8/rIUPb/SkuQabzlyC4ZObP7e0oqhPKEe/x6RSv1299yOZtj5Yp5z6yklf72O9Jvs+vfsSOeAIs4nALSCEhMNjAepFPZxRVFrKl5JYiIuK9UAlt5OJSoaYLIJWNbPj70X0FUlYesdli9ZV/RsXxAPAqxAUdlKxTOi/ThwpTSXpH92cv+QbfqUgCZU+rvYfkcAlDB9cDSi1BfJLSzInn+HAU41AP3PJRPPlRJAFe9YyTo7uX4KZ+bA0D4c0VN5w5ScLJX361TPYCqBHQtH2/5Pf3P7RKIy/4WFyvQxLhQWaznnIowvWDVYyYmmzB2Vm0UxglVN+IvSsPeqS/jOqP/Gp458f99yP6QsXSI/G5GunlFrgf80uE17nAqQmSc1r0ctK7EffLG0IF7IRLr1GCtWgPZuyP2hM1TKSBu68eFbCm9V8Kqf9YhVWEllg8rcCpyD9g2regUCNo5NCzp42w2c9guB0PMggCfcjNQpyGOwR1HiG6VaZXY3a3QkEMS2uk/fyF7R+ogXuFGeFGaRmnhXCnvvmKf3fMUl0nahel pkX+V8Wp d8ISWWDTJwT9cT0kEPme6iV4zR2YWcY6n65RcFcaV7lSpzCL3na9Jzadcpayj+Dv9n9yLfLROPZcIMy+1vkpCjeCnTybwc2eavvcH09s6vo5dg5yZt21G2nznhRzX8ZTD1JQL2erLk1biy3QzXIz+bxYaM9ud87701qvQH0RLgRV1oRqL/WHVLLqQ2WBlNq4Sftyewb6qyzRwEXEYRQJlIv+j7H9hQMSF+vnf0/1mblKvx7KRlcms3FVMiyy7oYBS3GZIr4ZJrc5o0aEKcO0dla0nlCNOAZtb7tZN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 12:25:17PM +0000, Chen Ridong wrote: > From: Chen Ridong > > The 'free_mem_cgroup_per_node_info' function is used to free > the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the > free_mem_cgroup_per_node_info function will be much clearer. > Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info' > fails, to free 'pn' as a whole, which makes the code more cohesive. > > Signed-off-by: Chen Ridong > Reviewed-by: Michal Koutný > Acked-by: Shakeel Butt Reviewed-by: Roman Gushchin