From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0570E77188 for ; Tue, 14 Jan 2025 18:22:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3430E28001D; Tue, 14 Jan 2025 13:22:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2D428000F; Tue, 14 Jan 2025 13:22:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BB6B28001D; Tue, 14 Jan 2025 13:22:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EBB1F28000F for ; Tue, 14 Jan 2025 13:22:25 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9FAB3120C20 for ; Tue, 14 Jan 2025 18:22:25 +0000 (UTC) X-FDA: 83006877450.15.53719F7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id EBC921C0023 for ; Tue, 14 Jan 2025 18:22:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N6H2aQfN; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736878944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QgCH66yBKmgIEQvZDPtutVD/4L/gLHteQN6pUfMZWLA=; b=k/WT6ugeJ9FiTFI5JpWN4zeJzNbL867xKnn2VgkrydW1cS/xU2n+1jFuITYoAtp3ZLwCeY GLHkvkxyt4w3MDHdK9+p51fP1hETkDfR8GnB/f1ahkCSch28T0P4SJMrft1xBqrR5fpM+P as5/7J4MXVLxBiW7vIs9VqN2jMQffzc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736878944; a=rsa-sha256; cv=none; b=JwclsxEY3E4iy8Ps+sP1G52z69nPJ1yWecKc+39znDgKM7b3Pu/7N7xD+5Bljx6+QmzUnU xDz0GN+IYudco9TpBFvwT5IWLz3WWqEbMC3IJ+SZLqLDfdnzlhy53Ocb6ybFwCf8/wZguk eLOULdz4PS4ytUDj5EIAQU5cAwD5t0Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N6H2aQfN; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QgCH66yBKmgIEQvZDPtutVD/4L/gLHteQN6pUfMZWLA=; b=N6H2aQfNiTui/l1jOMm6NNU7Os n+RoUgxE30I3kNCg9yG7lRZpS2UmJMCGgxosRDJWBZXHhJMvVcTNfC7eKD3BRNc7cs8bUsXs7pOOt zu5WBt6iE1rbdk2gnsxcCnbr0Z+75BpO8E9ixQx/Sdwif+oo61VkxlTDTA/22H1FmambpMcdly82E rgW/blsb9qkO/XWzB3+obxgLbj/2r+kEoRF0rgprhwfKpNpa+FzkJJ3fPKnCiKakjowKrvFibmSae 0T/ToTcoOb4YkYQZRsy4Z1FSlKzIu6u/RAiJIZKT/oH7R2zwUmd9zpqNT3LcM3jkA/ziLt71s4lrZ cg2+MgtA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tXlYM-00000001v5O-0gP6; Tue, 14 Jan 2025 18:22:14 +0000 Date: Tue, 14 Jan 2025 18:22:14 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Yang Shi , arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, liushixin2@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping Message-ID: References: <20250113223033.4054534-1-yang@os.amperecomputing.com> <2dda50aa-e4a1-4664-b8fa-56ba975db329@lucifer.local> <65691afc-615a-4716-8a2e-1f43bc65111c@os.amperecomputing.com> <3fdcd6a5-27fe-411b-923c-b7410e4cbda9@lucifer.local> <10f5cb31-e9fa-4574-b36d-0e685fec5cda@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10f5cb31-e9fa-4574-b36d-0e685fec5cda@lucifer.local> X-Rspamd-Queue-Id: EBC921C0023 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: rghq9k7ai3gnwf3ps4ts1mesndjt37yy X-HE-Tag: 1736878941-545893 X-HE-Meta: U2FsdGVkX1/OB/eAOSeYBcgS55WfAtcz4AUEs0to1fAf7r4zthHvaqaOkzrvdjlj/2gG5+FAsai0MNoOvT5elCp0AJXnvBvSElgJm3qYaLNyqE3ME8iZQ+TLXhcxtzpHQ3kRpSeTApu0W8ejxLKAFpjT0xwNPUpxgZYh7gKfU5X81CTmA0YqOz6/kYsL1Goah+HIw9F2I7cxkn/BMvUKZ09Oxho21Ba7i+0UrAacnLnpS/cnSqUmZ6S1ITIA/kXAW86NsRdfvhT/CelhL8PvQHurqkboCbkNiI2MSf3RjTxi0kEFZ0PqAKmLAGpu/fZrWhZom7elSqnR5lB+NDK4eujUEj4lwJ3npeBE2IFOawrdAQk0fLwVsUrltg/Xy2nfd9dtyblEOd6VI+gJ+T1QA7WVHojrAtkAcwE7maiMI6Mw1zxCo3uGHBsfCCMaEtSecgS/RzbIYG7VELppKvB/7gUgcIc3xSxRSfji3Jd/fJWG2JNbo74hwFwQgLm7LWVOVHdi/xeeBs6YAW+8FFXXWKl+oOOV73etcsg7mC3aOWcgdzL3ctkIL4JrhbdFwiEx4M6M4jVvOqCMpEsRSiZ5s2IwmM2uKBNEQ9aOD8VNz60lfnIDaKjpCH+R2zm5yyWzF+sdmVEOWTmiQ31p0ML6+BqNOBlER+B5UQxDOXcvYhwqcE1wJ3uddZkopm/rvuhUO0bEyySG2uBcpZ7JWD3bJTyzy8j/LceHpqTzNhgIfErjZ60Pe7/qS2WmkANqJNqjGFAzJuujV4Xcl96g8QJsgNVFzyA3KNKcmZTTJDM6tk2hcZP5sj4KrKRpqQSw0QaV6erEYeAX/YdtloCtSpmvFl4/hLhcfsw68GGBSBY/srCQd9X5O1nMG/J0Tp6njNTSPC5j3mb18XI7YhmPnYHqoh4+hCMG7j37CW+g7JzADLeojTabWa2vLcJy9Pzn3dj8xrm077dncX0iBTBE14A 7T4mJWMU LWRJlwbjVpwjp1q8idM62owZtmM3SYCMGDtloYL+Jmp/j9WHZ31mvqxBUApg2EtutKjnj5C/ZP7F8EhZgmDQJNJ2hfCXJbEYfINQqE2w/03HUQSNErBA7rWSOqIlXx9uUSj2UvEFv2eQ04F9+c5RGn/ERbgt72+S323VQYfdWASBiNc13IsQu8ANL8kjlr7fGNnGD9kEqWmGpH1mbGIyjwo7DyFizy6hB13DuwJ4A2z2ocz8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000096, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 06:19:32PM +0000, Lorenzo Stoakes wrote: > I see shmem_zero_page() does change vma->vm_page, this is broken... ugh. I I think you mean shmem_zero_setup() and vma->vm_file, right?