From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01AFAC02182 for ; Tue, 21 Jan 2025 20:02:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56D1E6B0082; Tue, 21 Jan 2025 15:02:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51CA36B0083; Tue, 21 Jan 2025 15:02:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C6C6B0085; Tue, 21 Jan 2025 15:02:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1DC136B0082 for ; Tue, 21 Jan 2025 15:02:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 953ECB04F8 for ; Tue, 21 Jan 2025 20:02:52 +0000 (UTC) X-FDA: 83032532184.14.030376F Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf01.hostedemail.com (Postfix) with ESMTP id 9560E40010 for ; Tue, 21 Jan 2025 20:02:50 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=NIJnU3N1; dmarc=none; spf=pass (imf01.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.170 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737489770; a=rsa-sha256; cv=none; b=FWWYuj/2BY06INp8ynUaW2tb6qyuLam5ECC0fks6rapAdP8qN2aVPw6DIf5oPrdkUfix1P 5z7gsDXlCjJwY2hIDJoEzZmPkp3J/K74zW4FXxNj5VDSSmclroytdhXf327y0dAihtqeQx yM2C14Ge6R6t7BvzxfB25pmWcKAK/6c= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=NIJnU3N1; dmarc=none; spf=pass (imf01.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.170 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737489770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y3OIVWfkgtUAiX31YkBMTeL/DLtPiayo47VWYrPFfqg=; b=MufyZn2OQhrAd87pzztpuBZWd34wQvDU6X4wzISldZ4UHYBn8ek1XFdE0c+Sm2MVJceRIw jHI6zZ3w5s3VQlYUHp0nFOVT1N1nAlIqzydUzmucMF/rkx+MXBRL9lI6CwPU1dynE8n+tN YfioogH1z4JIn3fZRK6wJxNQLW9jn08= Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7b6ed9ed5b9so259667985a.2 for ; Tue, 21 Jan 2025 12:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1737489769; x=1738094569; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y3OIVWfkgtUAiX31YkBMTeL/DLtPiayo47VWYrPFfqg=; b=NIJnU3N1xbuKDX9xWdUfqPDt63HLQgr+8Yupo29RQvUUdW5yXiTP6CW/G3pJvSWrKo LJ/5i561/yo+0bW46wdLogyf3RA9vcYuv7IhOWJJ2D22Ud3O7hwNPxzXuxmJUjMLYcTI 5JYU5xwG6K7QywO7EJdKvjk0Q1GN4ALs08s+QOL8nGvqSXpI3NbWaTYzk+kW2iA4lwME anJxi522KDXEP8hfOG66bhE81KfU7q73HrY5jB1iWJywLvQVO+chUXm74NOcRfGlEKYS 5L0o4w0nznqvCiyZNVz4LUY18JL1BhAjmASkDeV0PUhjKhPzp9gHzClN1Djcqn9zwpNp wYzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737489769; x=1738094569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y3OIVWfkgtUAiX31YkBMTeL/DLtPiayo47VWYrPFfqg=; b=cjrWcsPrqpzaTmjsGfCsbhjxavYVDTtwbArtYWGf/GED9kuwOdviNiVmNy9P+G3/Iw W5hLBrUOdK6WV8XB6W4oSm3lE8/WbNpdlHXsC1MFkic5UOVGptUBeUee180293bjLWl8 pW4Gy916niOuQRpqBlgUJqWNapZUJq2CUEKRlnxzYo0UJol8HA8llVCVyLSRmivTwByt 1IxmHkYgaHoIxXlxjk52ExdiFPG9Hzr+G52m3j3eEkS7Tsj5+3dPwxnmCCAkzsoadPJz n2rX6bcw6ePJtP/FrDOeLcDDuM2DY1I/NZernE34XJC3SUN9reciFbPs27peB63Dlm5B +N6g== X-Forwarded-Encrypted: i=1; AJvYcCX8arZU9XLjnxD0evWjLvvgUyeF3A0XuEILv9+gAN+YhLkAy/a7X/egxtoF8C6SjucbFe7KrBMNuA==@kvack.org X-Gm-Message-State: AOJu0YwaSgM171TCGP5dbC904y3A3yIn8brFNu8H57I0C3/mDzsxbgwb JlniBkyyI3w4UNtb3tr6vcsHy/ADfI/7IN/NoHR5jTd0LvsB/eHJ+kDBuv1Sf+w= X-Gm-Gg: ASbGncvpXvvbuDc8Xaa2C4v7qEF/IEtU8JXgVI37T2n43HW3y65SJKNwl/1qmMOmmP6 ydpa40ij6s7Vhp6GPXn3bCyQH5FpzC9WIjuhUs4X0IaocOsenYQXHZ/kgHfoz7St4yKTXx0gt3o DtWKabQrfV5de3dtWKLd1hwQqd4zgdMyqLJp6bR+NpwgbhmaVMXiRBGypGCu7W58BZ1ZB9T7/t8 i+XC5g8Qc1YvJATq9svttNhPKi7MIJuGHu1WU8S94KmorxnhWNwP5qiMk0rGs7XcbnrxtefJNhD Pci7j+W21c41m4AGJlt7o/YRJXSHcByDkFTn8sNI6z6/cH7ivnTi X-Google-Smtp-Source: AGHT+IHXwpvIHPv5sKnU+umZ7vn4igy4P4XDOftH8A6JMGTfJEfhQhF1hHFvJs4VCsRttlDk7ECwqA== X-Received: by 2002:a05:620a:2894:b0:7b6:e47a:8e14 with SMTP id af79cd13be357-7be6324fb5cmr2839107185a.35.1737489769284; Tue, 21 Jan 2025 12:02:49 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be61480996sm585370585a.41.2025.01.21.12.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 12:02:48 -0800 (PST) Date: Tue, 21 Jan 2025 15:02:47 -0500 From: Gregory Price To: Honggyu Kim Cc: "Huang, Ying" , Joshua Hahn , kernel_team@skhynix.com, hyeonggon.yoo@sk.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v3] Weighted interleave auto-tuning Message-ID: References: <20250115185854.1991771-1-joshua.hahnjy@gmail.com> <87ikq8h0w4.fsf@DESKTOP-5N7EMDA> <147aba6e-7e23-4ad1-9bd2-1ceac0f3d55b@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147aba6e-7e23-4ad1-9bd2-1ceac0f3d55b@sk.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9560E40010 X-Stat-Signature: o3647q6criqys8ia7h7jq8dhijimpet3 X-Rspam-User: X-HE-Tag: 1737489770-221478 X-HE-Meta: U2FsdGVkX1+Qm7QcuOk4UqvspYpVxbSJjaQFQ/NQiKkgK0IoyuJsjQ/2Fb0w5+tFDm1mOsvne6kwEAnygTflgwslWXEZnsMM4bwSsTONj/KiXzxKUgJ8YVl4vqaemu6sG6tEit1Ggsvd042WEZNpiPavjL7jzgwjhchM6Y534ANvjy72imUze858buAIDpiJ4tuveS5bXS9BEZJDzRjGF/4Ry0MIKqy7uddj9wOXAoUsa0Dma9s9Q36Ej4zAfFJPPmzp58UbtSNUlFQ2HCcYwR38sFJqitUqOAOdoEVTwQiy+vwbtx1M3V9AzP0rMENkkONVZgamdRC/gs5kBWEynfsp9GXZYyY5pOtBODhAjJsW6PBH1Ix0vARESbwRqT7hjpeVaRCf1KeX2KHdIpQejQObpko/fHEaSIMQLqZU3watnw67n49AtIacZV/VFE3PmUXOVfVxqu8L7BXCEiZOGvKtuWIGPn0r5D3S0qMylDesf85k8Qo+oiPx6g8ykt0aHQFjme16jRCPK2eC2Oi54SEjtmA1ifVv9qqy/6zJgjPY3oQ2nhN2cduuHS0BhazeKOe56juxqsfQJPJl/B+oJCcmOBfPX/Og0EiYZegA9xHHS9067EBvluVgdxzIxYdCgIcXe+wnDPmb74nZ9aq9656uKZ0PfexR1NgtZdQR6D0GCBSrYr2ovQAp2biwCZXDxH5v2rHTj79shhZwsZrt+2hmvfSe09xYQcDYcjjo80rl1OtaFtt++tMSEb3uyq3mJOsnQDoJveS24y7EUl4y3xyO1ilK4cBU1cKu4BWtJ5UAiadbBPVq2ROToL+E8PhrDoFyqaSr7B3J8Ylv3FPB7ZakMg6t4j6C5NCVh5ahdiVJIgErkTAgfflkI2sohlO9NOtDYJdJxl2RbihAEiQCuKXfOl+/lflwJ3vaZ025vmnOL+lMdiyG09BZERgh2zWZso9KFo7F9gtsVw6LgW3 O5RVHBzG oqA6yGWFk7+v3R5NklvRWd3+2RD+7F9TwXEM6kPmGQVu68m6QeL56coZ3Quu5GephTyQwtov9DL9MeZewohZEcEoe+pIwhEYpfk57ETbQHGDNPcZn4GByTCSsjZZaU2XrOV5viENym7GUZ2RdZXcnN/PecX5Vd2UYeHjfjOC1ZmAOnvZbXvNGpjyZeks7TRsIdzs9xaXa9UQDrnsEkn5LzyN6A71tL7vULDSHArrvh3+HhCRzleMAr3iqa8Guikc2lfCWqdLxxmkLHhR4qaTx1lnTMhYiV8/dvJfo8TNOQ1NUvZLe6moLQsMaU1MGZRAE1mUY2CrgtMqqS32C+lj9O+WOD8YnEgAYHl1D9Xr6aURTAPW7JhDh096GmNWSyZs5ClNtOmVww5bqKLE5fHyHtT2FYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 21, 2025 at 08:27:17PM +0900, Honggyu Kim wrote: > Hi Ying and Joshua, > > IMHO, this interface is somewhat hard to be used. Users need to know > > which value is legal. So, this will become something like, > > > > $ cat mode > > auto [manual] > > $ echo auto > mode > > $ cat mode > > [auto] manual > > This is exactly I internally proposed to Hyeonggon, but couldn't share > the idea directly here. > > That also makes sense, but I feel like somewhat vague what "auto" false > means. The "auto" might be better to be "use_hmat" instead and this > makes "use_hmat" false more meaningful. "use_hmat_weight" or > "use_hmat_info" might be another candidates. > I don't think we want to encode hmat-ism into the uapi. In fact, mempolicy doesn't even know about hmat. It just gets source information from *somewhere* and applies it accordingly. I think what you might be asking for is auto -> [true, false] if auto=true mode -> [default, read_bw, write_bw, combined_bw, read_ltc, write_ltc, combined_ltc] if auto=false mode -> [disabled] Where default mode is the kernel selection of whatever combination of read/write bw/ltc data, and user could switch the attribute. HOWEVER, such `mode` would require us to cache the attribute structure per-node, and maybe some thought on what's reasonable, so that I would prefer that to be a completely different feature / discussion. ~Gregory