From: Gregory Price <gourry@gourry.net>
To: Honggyu Kim <honggyu.kim@sk.com>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
kernel_team@skhynix.com, hyeonggon.yoo@sk.com, rafael@kernel.org,
lenb@kernel.org, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, rakie.kim@sk.com,
dan.j.williams@intel.com, Jonathan.Cameron@huawei.com,
dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-mm@kvack.org, kernel-team@meta.com
Subject: Re: [PATCH v3] Weighted interleave auto-tuning
Date: Tue, 21 Jan 2025 15:02:47 -0500 [thread overview]
Message-ID: <Z4_9Z_TfVY3VOMHg@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <147aba6e-7e23-4ad1-9bd2-1ceac0f3d55b@sk.com>
On Tue, Jan 21, 2025 at 08:27:17PM +0900, Honggyu Kim wrote:
> Hi Ying and Joshua,
> > IMHO, this interface is somewhat hard to be used. Users need to know
> > which value is legal. So, this will become something like,
> >
> > $ cat mode
> > auto [manual]
> > $ echo auto > mode
> > $ cat mode
> > [auto] manual
>
> This is exactly I internally proposed to Hyeonggon, but couldn't share
> the idea directly here.
>
> That also makes sense, but I feel like somewhat vague what "auto" false
> means. The "auto" might be better to be "use_hmat" instead and this
> makes "use_hmat" false more meaningful. "use_hmat_weight" or
> "use_hmat_info" might be another candidates.
>
I don't think we want to encode hmat-ism into the uapi. In fact,
mempolicy doesn't even know about hmat. It just gets source information
from *somewhere* and applies it accordingly.
I think what you might be asking for is
auto -> [true, false]
if auto=true
mode -> [default,
read_bw, write_bw, combined_bw,
read_ltc, write_ltc, combined_ltc]
if auto=false
mode -> [disabled]
Where default mode is the kernel selection of whatever combination of
read/write bw/ltc data, and user could switch the attribute.
HOWEVER, such `mode` would require us to cache the attribute structure
per-node, and maybe some thought on what's reasonable, so that I would
prefer that to be a completely different feature / discussion.
~Gregory
next prev parent reply other threads:[~2025-01-21 20:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 18:58 Joshua Hahn
2025-01-20 4:47 ` Hyeonggon Yoo
2025-01-21 21:24 ` Joshua Hahn
2025-01-21 11:17 ` Huang, Ying
2025-01-21 11:27 ` Honggyu Kim
2025-01-21 20:02 ` Gregory Price [this message]
2025-01-22 1:24 ` Huang, Ying
2025-02-05 5:34 ` Honggyu Kim
2025-01-21 19:56 ` Gregory Price
2025-01-22 1:37 ` Huang, Ying
2025-01-22 15:59 ` Joshua Hahn
2025-01-22 16:53 ` Gregory Price
2025-01-23 3:32 ` Huang, Ying
2025-01-24 5:58 ` Matthew Wilcox
2025-01-24 15:48 ` Gregory Price
2025-01-24 15:53 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4_9Z_TfVY3VOMHg@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=honggyu.kim@sk.com \
--cc=horen.chuang@linux.dev \
--cc=hyeonggon.yoo@sk.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=kernel_team@skhynix.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox