From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ECE0E77188 for ; Tue, 14 Jan 2025 12:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD3F96B0085; Tue, 14 Jan 2025 07:23:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D843B6B0088; Tue, 14 Jan 2025 07:23:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4AFD6B0089; Tue, 14 Jan 2025 07:23:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A8A886B0085 for ; Tue, 14 Jan 2025 07:23:07 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 66AF81C727C for ; Tue, 14 Jan 2025 12:23:07 +0000 (UTC) X-FDA: 83005972014.04.4E10B3D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id BDE6520003 for ; Tue, 14 Jan 2025 12:23:05 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736857385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hqxZT9ozmvZjLWkTsq08CYG4jN1j/R696/vPQZFpMxM=; b=qvtnw8+occVxH+zd9Qm7jrPduDRIKeOXYD81KwgrgcZC6Ff645nwCI1RfL7DUdlrLH0Icc ad/OMbKn6zPYVl8pu1V+Fgv4HfD1XbCCInEuI8apLUR+lwwxgsMhzZqvnphcxLSFsrgKnb 4nBdFShXsnOfm25Coynk5+yEOpDqJPw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of Dave.Martin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=Dave.Martin@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736857385; a=rsa-sha256; cv=none; b=KhSsaGHLsfi+Ls3GLlkBS1sH0palIFv3x3nS6d2BTM/0GcYVcBBx3vI38Xiv59D3QSz26l MUchRyhtaGpO+W6r9/UrCTjWGXmk140xXB+77iF5cTurXSv4UEb0lKpqtWtVz96UYkXbil xZehAQ5TeQX78Gu2F6ZPt1FcfGwfEw4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 607DC1424; Tue, 14 Jan 2025 04:23:33 -0800 (PST) Received: from e133380.arm.com (e133380.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C2EDF3F66E; Tue, 14 Jan 2025 04:23:02 -0800 (PST) Date: Tue, 14 Jan 2025 12:23:00 +0000 From: Dave Martin To: Akihiko Odaki Cc: Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , LEROY Christophe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, binutils@sourceware.org, devel@daynix.com Subject: Re: [PATCH v4 3/6] powerpc: Use note name macros Message-ID: References: <20250111-elf-v4-0-b3841fa0dcd9@daynix.com> <20250111-elf-v4-3-b3841fa0dcd9@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111-elf-v4-3-b3841fa0dcd9@daynix.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BDE6520003 X-Rspam-User: X-Stat-Signature: o1ew98qkif8mhd3btgioqcdk31c8yshq X-HE-Tag: 1736857385-246112 X-HE-Meta: U2FsdGVkX18DYclu9QhzhL1w7Yxc+rUYf25aklmG+J8e7TdavQCyVyo9SO18Dn99bnKmIrBqmAIP/zjV8epfvksyncHE3FpW1LHz6pOjMaruRAhXqJA0ne6DqF0ab/BuoOWy9UaaqJrqS5RqFd+aIgXATR9KOAQ5CvUWD6bvz3/Nx9rTn6UFdcvSXvkkVnvF9O8+6XLSVNkE4M8fvL1zqunngIFvxrmG6BYzSOoa8RDL02PRJayNXFZ5FtfYZFOwRujipftERHPjmEWuPi+zO90QKwuIvGKBARhlH4yD5dUrDfNtnKERb5ess5MOSmq6L+2HOFBwptU0PxC+wHyEJ9Itykstiionujys1SecSPdwcEQuqcEdOAudlgOpfbVbbr/4UBL/41rGpq83qbS12W7N6ZSuvMY6ABnKBaMx+Iz9SuHt6Tf+ecQs1EVWL7QcweQIGZ51rHjOvTXknQrKCQg4avlD1cFI4toUk7sHXFEmr0u6nIwYGmbJXI22OQ+m9HrDOPLtkeh7DZk1RGGLKbV/qxyUfb/PUrJ2J3MHjJcS1Lo0/FpaWpLzg53fg1EHfuK4h1HTrsJPRUsye98ANQT/ol5iP7norhSJyOHkKLZZu/YTMGfNsG+wH536wbyI+lOrtybwSg961+oqMmpsbIe5Ari5ZYVgZ/cEXt6I+rXvqyp7NcqoarMSogLWH2mDfvYE4P/xJ7BGh/IMJBVu3dhOpCLrfW0Az4VmnpxDCy1oy7LMqzItFOb0OMaX2n/wvU0M7GJEMiHZBqUGOG0bPyELUmEgtfQxE8jPMmqe8dXiRVfGjczEEwi7YRjoMzpRkL2z08HgqcO+s1OEt6QKpbLVmVpEI3tYtKH/laLkMiaeaEmhp+ERCywkTVahTaVj/0yG7+6WfmbEE/8mUjYuYYkCZYD5KLCRwFZkPEhSoW9Qmd0IOButWBkXK5XnzvRZGsTREUamR4fCeYZCc0F aFn5tqS4 rvaKvXsSYjWrr7R3FnwlHl5v9SItCKx1bWNYZnkWNtxCLOMxMhsVloQYQ/CcpKTsVBw24K8PMaBQtG9gvDyxVEP6kOA4zgebHyOyi1onb8OoEgvd1oPIdfn7yI+DvyO+LCAB0f8UpbeQhicohPvRk7X3A7T51fsqeQzSJvdMgSg4Uf0MvknXtWnJIGN4oYvfhI1TloWu8XFuN94FJXszzW1YUaEvfbtdZQxJIIBIDcU1Mr8004WP5ZtrhZ68Kmt+Q2YPucqbDTiXb+PlR8wEAT29Us1InNEWUESY9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Sat, Jan 11, 2025 at 02:48:46PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. Note, there seems to be some manual encoding of some arch-specific notes in arch/powerpc/boot/addnote.c, but since this is all hard-coded and the note types are not taken from elf.h anyway, I think this is probably out of scope for this series. I haven't tried to understand fully what that code is doing. Anyway: Reviewed-by: Dave Martin > > Acked-by: Baoquan He > Signed-off-by: Akihiko Odaki > --- > arch/powerpc/kernel/fadump.c | 2 +- > arch/powerpc/platforms/powernv/opal-core.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 4b371c738213..d44349fe8e2b 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -751,7 +751,7 @@ u32 *__init fadump_regs_to_elf_notes(u32 *buf, struct pt_regs *regs) > * prstatus.pr_pid = ???? > */ > elf_core_copy_regs(&prstatus.pr_reg, regs); > - buf = append_elf_note(buf, CRASH_CORE_NOTE_NAME, NT_PRSTATUS, > + buf = append_elf_note(buf, NN_PRSTATUS, NT_PRSTATUS, > &prstatus, sizeof(prstatus)); > return buf; > } > diff --git a/arch/powerpc/platforms/powernv/opal-core.c b/arch/powerpc/platforms/powernv/opal-core.c > index c9a9b759cc92..a379ff86c120 100644 > --- a/arch/powerpc/platforms/powernv/opal-core.c > +++ b/arch/powerpc/platforms/powernv/opal-core.c > @@ -149,7 +149,7 @@ static Elf64_Word *__init auxv_to_elf64_notes(Elf64_Word *buf, > /* end of vector */ > bufp[idx++] = cpu_to_be64(AT_NULL); > > - buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME, NT_AUXV, > + buf = append_elf64_note(buf, NN_AUXV, NT_AUXV, > oc_conf->auxv_buf, AUXV_DESC_SZ); > return buf; > } > @@ -252,7 +252,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf) > * crashing CPU's prstatus. > */ > first_cpu_note = buf; > - buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME, NT_PRSTATUS, > + buf = append_elf64_note(buf, NN_PRSTATUS, NT_PRSTATUS, > &prstatus, sizeof(prstatus)); > > for (i = 0; i < oc_conf->num_cpus; i++, bufp += size_per_thread) { > @@ -279,7 +279,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf) > fill_prstatus(&prstatus, thread_pir, ®s); > > if (thread_pir != oc_conf->crashing_cpu) { > - buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME, > + buf = append_elf64_note(buf, NN_PRSTATUS, > NT_PRSTATUS, &prstatus, > sizeof(prstatus)); > } else { > @@ -287,7 +287,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf) > * Add crashing CPU as the first NT_PRSTATUS note for > * GDB to process the core file appropriately. > */ > - append_elf64_note(first_cpu_note, CRASH_CORE_NOTE_NAME, > + append_elf64_note(first_cpu_note, NN_PRSTATUS, > NT_PRSTATUS, &prstatus, > sizeof(prstatus)); > } > > -- > 2.47.1 > >