From: Michal Hocko <mhocko@suse.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Chen Ridong <chenridong@huaweicloud.com>,
hannes@cmpxchg.org, yosryahmed@google.com,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, davidf@vimeo.com, handai.szj@taobao.com,
rientjes@google.com, kamezawa.hiroyu@jp.fujitsu.com,
RCU <rcu@vger.kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, chenridong@huawei.com,
wangweiyang2@huawei.com
Subject: Re: [PATCH v3] memcg: fix soft lockup in the OOM process
Date: Tue, 14 Jan 2025 10:30:05 +0100 [thread overview]
Message-ID: <Z4YunYyj6oqmdrUt@tiehlicka> (raw)
In-Reply-To: <aaa26dbb-e3b5-42a3-aac0-1cb594a272b6@suse.cz>
On Tue 14-01-25 10:20:28, Vlastimil Babka wrote:
> On 1/14/25 09:40, Michal Hocko wrote:
> > On Mon 13-01-25 19:45:46, Andrew Morton wrote:
[...]
> >> > For global OOM, system is likely to struggle, do we have to do some
> >> > works to suppress RCU detete?
> >>
> >> rcu_cpu_stall_reset()?
> >
> > Do we really care about those? The code to iterate over all processes
> > under RCU is there (basically) since ever and yet we do not seem to have
> > many reports of stalls? Chen's situation is specific to memcg OOM and
> > touching the global case was mostly for consistency reasons.
>
> Then I'd rather not touch the global case then if it's theoretical?
No strong opinion on this on my side. The only actual reason
touch_softlockup_watchdog is there is becuase it originally had
incorrectly cond_resched there. If half silencing (soft lock up
detector only) disturbs people then let's just drop that hunk.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2025-01-14 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 2:52 Chen Ridong
2024-12-24 23:06 ` David Rientjes
2025-01-03 16:18 ` Michal Koutný
2025-01-04 0:52 ` Chen Ridong
2025-01-06 8:45 ` Vlastimil Babka
2025-01-13 6:51 ` Chen Ridong
2025-01-14 3:45 ` Andrew Morton
2025-01-14 8:40 ` Michal Hocko
2025-01-14 9:20 ` Vlastimil Babka
2025-01-14 9:30 ` Michal Hocko [this message]
2025-01-14 12:19 ` Chen Ridong
2025-01-14 12:13 ` Chen Ridong
2025-01-14 18:42 ` Paul E. McKenney
2025-01-17 6:59 ` chenridong
2025-01-06 9:29 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4YunYyj6oqmdrUt@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=chenridong@huaweicloud.com \
--cc=davidf@vimeo.com \
--cc=handai.szj@taobao.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vbabka@suse.cz \
--cc=wangweiyang2@huawei.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox