From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BE4C02180 for ; Mon, 13 Jan 2025 21:06:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 507B86B007B; Mon, 13 Jan 2025 16:06:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 469D96B0099; Mon, 13 Jan 2025 16:06:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BC716B009A; Mon, 13 Jan 2025 16:06:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0AE6E6B0099 for ; Mon, 13 Jan 2025 16:06:38 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 82734A0346 for ; Mon, 13 Jan 2025 21:06:37 +0000 (UTC) X-FDA: 83003662434.12.D5EB005 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 8E6ADA000F for ; Mon, 13 Jan 2025 21:06:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=ZIHW5GEd; dmarc=none; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736802395; a=rsa-sha256; cv=none; b=bWnxWEreyx6YXLujMo7eWzlUZ9XN5jUWoeen6l+BYJJ69DLdubtJurtpN2H2jPJrKsREhw w1qQdow1/NBixzwV4P5SmBoMm6x/bX5LOsW0FiHoSAxcqo0Mkwfz72Na1AuN+pND6H4APU KKmVWwluHnQd+chyP8SpDF6uX5vTYV0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=ZIHW5GEd; dmarc=none; spf=pass (imf15.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736802395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fL4j/w8tq5R6XuIWQMpvaEYTyys0cTNStMM/2ZIjtF0=; b=KWpIqwZrnzZhd4nvrk1ocRJsA4CrXpRDdonnX9H4c0jKnjTz3AtktIZaTeFnpvEXBCz7M0 oOseIbJeRC2EXb0j2PXmRCskGvrSRK8sDOyCkmfPyLtiqzDkjuFTTVJqG/BPM1ORU9CUsL 6S/XXwDSQ+cDEp2FLt8xYP17/k72oJM= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b6e5c74cb7so350089685a.2 for ; Mon, 13 Jan 2025 13:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1736802394; x=1737407194; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fL4j/w8tq5R6XuIWQMpvaEYTyys0cTNStMM/2ZIjtF0=; b=ZIHW5GEdhBBwYQ+C7ENGW7AjbqlgzLsFxojpFDLIzbQ3lsOS0nWqYjZHPxYrOzVZ45 WrfDDMqaShOQUlpKq1s6qo/Y/cyfV6/WhCouvM4jsmWUUEO1dCc/pgOnvY4nkzgss33a EJY5QjjKEPFlJBd2lKd0R1L56ytsz5VLd1qL4nLru+TG6eTmesc2MKKAFQmw3CJpfEre 1wHzzwImHrJuqTypIFSdoKnu8H6D+HwJJ3dfeiXI+cwNFZXcHDsB6n0V0UHXhoaKYYX3 swhK+Rubt9LpQy6Nssxf50I6g2qwSgTfmF0gk+CgLiP0iA5bXl9Jkg1LIz5dedR+bJep cY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736802394; x=1737407194; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fL4j/w8tq5R6XuIWQMpvaEYTyys0cTNStMM/2ZIjtF0=; b=vgSZVtUMTMzMXY7caqGxjjABJk1pQUwziKtjr3ZIwXCeYDgdtDmOckZ1FbjvHmhfKp vm9mLQkjtMpA0F2hF+2RXMV/59+pG7vm/27GE9BWc5YWceuIm805MC42ZrR9099GXblR ZGvDbBlncD4Yq4jBZ2s+pcJussKHjV+TOhopkRiS66voeHYXkPHFTuxpHTh/Im7ZPQX2 NqdlVdzbDU6eNnqTWeQnfR2/MqBB3/+ePWk/8PMtYPnwvGdk49UaozKoEIo6fUgJ7eRq Lg4/sRI23xhQLedrMxisnQLrN3xTq9RkhSrHjW0f5ON0L3nuUI3FvnMxAiL4g4psY+z2 GRQQ== X-Gm-Message-State: AOJu0YyDr9c9OBvui3Kz6IEWrWSALApdyLtL6CMd8VvXzbqsmT7KDPvj 3g6ZrxgselvMriK6X1fMoeT5bYk4WSYZ1vVF5yjwi21+miPq5nYUfOF3FIBLxnw= X-Gm-Gg: ASbGncs1T8UviRxu2uxgKVU9ej1ECtWflkuEYJHuntAffqfMX5I/7jTcZ3h5YycFhBE n0/zQPDFxk7s1KKhDH5Vei+qfmrmqdVq0fmMpOQcLBhS937aV4b7yOTxEfCMjWvWZjDsJGXDU8j u0ZEQpM9yQtOnzejGMlHS7KWZa8f15cxQA8tOI8A0+HKISkpO+uav9R9jZINbCeTO2MJFU+sRUr TuhoC0nDIJDOEOML2chgXN+fBxDxIJwj20NcBteL1XU6+f6eBN8m08zHfrV6lG1UIqqM5ebKLNC hppCA9EgtNJazveEIIe8EOoUQvHxqDBGYR67CYQ= X-Google-Smtp-Source: AGHT+IFvDKtyW7pef1s60emcEMo90F4I6tm7a6BiLDHui2qCMT1+1I2lQj7uSal1dcn+B7K4i/d7Dg== X-Received: by 2002:a05:620a:404b:b0:7b6:d65a:d6ea with SMTP id af79cd13be357-7bcd97c3447mr3631054685a.46.1736802394709; Mon, 13 Jan 2025 13:06:34 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3516004sm530440085a.101.2025.01.13.13.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 13:06:34 -0800 (PST) Date: Mon, 13 Jan 2025 16:06:31 -0500 From: Gregory Price To: Ira Weiny Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org, kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni Subject: Re: [RESEND v7 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Message-ID: References: <20250113174439.1965168-1-gourry@gourry.net> <20250113174439.1965168-4-gourry@gourry.net> <67857eaa6e284_1863f329487@iweiny-mobl.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67857eaa6e284_1863f329487@iweiny-mobl.notmuch> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8E6ADA000F X-Stat-Signature: fxeb6uxnh35xk859u1kde9dd4th5for9 X-Rspam-User: X-HE-Tag: 1736802395-851792 X-HE-Meta: U2FsdGVkX1+SsGuFfwp0Ehfo8/4hsIiMDXhQpSOcmFZWVIjAOUKzKOVSwT6Dl7ieyFCOM55lJzMiSRG1GnmkItswII2hvYZ4K3Vs0X8vpcSDAccuHYg6lqdKBF2AHZBHGOF1c5naH2rgglWh4W7XFZaqNMH7eeWSdkgDLH7MWJBHX66SJ6TLk52oWRQquYR6oP0CjU92hWN5LrptuAZCpVNuOAJIu+U6tHWR3cKwoyWJ+QEa7qmWx5komKEGsk6ZLi8f4pEwdk9x0tfRNHDhG9qCyx+g6yMYjBqYb0cClMcE1pIPaX8CH6Rfb9Ht2LOdJYbga1UPfbrTclRYg9dkjIvfW9Z6Ht5QvUSt3/V0SqC1xV9fzapSmX/f6Zp5nICKILkCBH5L5Wb92qGKzPeewtB9rbhgZZUwuC8or+ZdmiF+FuCmuTn6ntXd1Ek53gI0dtBxw0qLSZbDWbhzY5wJYftO/zb4Xvj+Jr1a6NuTvSpM+7lxVWJDVsLks9EAPoQk/WiZynrABnHYwNl9tZCTiM875xtTKoghx5fuIhMEbSSmdku/WV/KOy2adj73kHY6LFvLyP/AaQNDNxtSM6Sc1V1Pp/Ye6fLjPoPS4F+nv2d9/4BlL1vXmwzGr6YSfln3VEqg/4nYxu6WdZzU/FzixvK6CQ7bRhEkiIJ3xhb/iu8rfCGB77QN5y48qMZBXW3D36r4YQgCHCKeaNtENANKyyYXwkU/MALwtXaMbU+7gWn53YJKLs+CvlulWrBULpXBvscpu4T/XsYkkuWmihnyLs9D2HosWAujqCmv0iTxwW4B5oKGeDIcuEMAYSiMXO0biLF5sgVDAaobzkpo9L2u/lZTvsBoreT6vVrTtHyygyu4StZxBR2R8SuM6d6lurnuuvp40nsJmDzeoJ+87WgMtbBF5yq6zyWHtqP9bDtqlGFx48eFSa3gBEe6MQQ3IrWfI+Nysot+X5dzNjb5usq ZUmMYqvA VXtz/AtZfkPreiLzla0X6wTTjrlp7IDt7Gryrafc4NvXpdL0O/d5862dG2ZZhVD6l6lOH+Kon+K7Ffd8QZv8dYyGROETo1NomordbUoh/z3e8396NCr+7G4z0IqDg5tTH+iVfbaB9gpCXucw2Rqiv11TFtsq0RTlFPVXAzNMdJwnxOsfcUBd5YU71DxtHT+1WjXk5pVglwdGdn+zZV/nWTDzkvDh6p1OHvpRuLCkuZtALWqRgfMxWFBaPfY9sLPhIp7FHxSLwfY+bomTpRLiv17jF73eakmBUyUhHpa7LsHFwA8vDlQ40+D0GQ7M75QsN3Kle0kgqYySNObld+BlkNX2l705K1lbT1fn0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 02:59:22PM -0600, Ira Weiny wrote: > Gregory Price wrote: > > + /* Align memblock size to CFMW regions if possible */ > > + align = 1UL << __ffs(start | end); > > + if (align >= SZ_256M) { > > + if (memory_block_advise_max_size(align) < 0) > > + pr_warn("CFMWS: memblock size advise failed\n"); > > I wonder if it would be good to print the return value here so the user > knows why this failed? > As someone who is often annoyed by this exact pattern, I am apparently just as guilty at producing it *facepalm* I'll pick this up and push it tomorrow. > But either way. > > Reviewed-by: Ira Weiny > > > + } else { > > + pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n"); > > + } > > + > > /* > > * The SRAT may have already described NUMA details for all, > > * or a portion of, this CFMWS HPA range. Extend the memblks > > -- > > 2.47.1 > > > > > >