Re: [RESEND v7 3/3] acpi,srat: give memory block size advice based on CFMWS alignment

[Gregory Price <gourry@gourry.net>]

On Mon, Jan 13, 2025 at 02:59:22PM -0600, Ira Weiny wrote:
> Gregory Price wrote:
> > +	/* Align memblock size to CFMW regions if possible */
> > +	align = 1UL << __ffs(start | end);
> > +	if (align >= SZ_256M) {
> > +		if (memory_block_advise_max_size(align) < 0)
> > +			pr_warn("CFMWS: memblock size advise failed\n");
> 
> I wonder if it would be good to print the return value here so the user
> knows why this failed?
> 

As someone who is often annoyed by this exact pattern, I am apparently
just as guilty at producing it *facepalm*

I'll pick this up and push it tomorrow.

> But either way.
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> 
> > +	} else {
> > +		pr_err("CFMWS: [BIOS BUG] base/size alignment violates spec\n");
> > +	}
> > +
> >  	/*
> >  	 * The SRAT may have already described NUMA details for all,
> >  	 * or a portion of, this CFMWS HPA range. Extend the memblks
> > -- 
> > 2.47.1
> > 
> > 
> 
>