From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15679C02180 for ; Mon, 13 Jan 2025 19:14:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0FAF6B009A; Mon, 13 Jan 2025 14:14:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BF9A6B009C; Mon, 13 Jan 2025 14:14:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AE856B00A1; Mon, 13 Jan 2025 14:14:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6ECD06B009A for ; Mon, 13 Jan 2025 14:14:44 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFFE28027D for ; Mon, 13 Jan 2025 19:14:43 +0000 (UTC) X-FDA: 83003380446.26.05CEC38 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 5ECC918000A for ; Mon, 13 Jan 2025 19:14:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PSnfPpqB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736795682; a=rsa-sha256; cv=none; b=BYt246ZbU8vO4fYCFjDzQS9yn6SFrFIaHihQFjQDV3XdgoDVmbvmEkWMubjWED7lNwFAKQ 7Q4HHX+1juoCcvthbwQJSp8Odn64LR6FjrRgkyu1BXG1oTtXWCeWHgaOvix7cZymIeyVql jH+rWWqxjnQAFW1FZxsgcYl0p9HC3X0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PSnfPpqB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736795682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=66/uiMxixRuznnLyJ23h3wKleTmuSZs+nI0CmsdZxIw=; b=eb/Xobr2Gr8qA0Sh1tttRuJr4GvpJ79IXex+whc53RFZ+//CDRk0kJ/msUjpL46IYn7n27 dFzShXvTFR90gDr3P7jTlJaRxnQzUpkhTLAAIiu67EsWYi5DTx0ZlvB8sq02m7DBQstsx7 2VobaHK53ksVR2srX7m80kN/rAamxW8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B544C5C57B6; Mon, 13 Jan 2025 19:14:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D374C4CED6; Mon, 13 Jan 2025 19:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736795681; bh=ZDz8xhoJDEcV/pEbTojpQdt7SMjp1CBNyqmLnqAfk5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PSnfPpqBBEN3rEN1A/+yC3d5ItDgnfSuZGeOMifBO4t9J2fCQJutiFXnDn+DwNG5y jQPsP3kXGhKVGKXUPHdLP1BlMqcOeHXoNQJeiUSTjK9Iz7VFoIJfYJOOTXIl6MhoPc 3CMlrK+tLpiBFlgaGaAaRLSpllZp0PzE63p2Q1e7g54Vp3q8UDIPobbLrAspYvf7qo lLdyDKHyb/relZPz1oQW1vgliJvqA6ybbun9Hpp6MnrYUF+YQwBHs+3aFQRoexZGI4 EGsJfxNIwIKBFmDD9x3rjENyyVlbbN25BDOI6vCdy2yVlDQRXEs0xeA78EmHSVn8Cd jATq15a1EAtLA== Date: Mon, 13 Jan 2025 09:14:40 -1000 From: Tejun Heo To: Shakeel Butt Cc: JP Kobryn , mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 0/9 v2] cgroup: separate per-subsystem rstat trees Message-ID: References: <20250103015020.78547-1-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5ECC918000A X-Stat-Signature: s59jm31c3gr1osjdz9afpjkp6bwq8gsf X-Rspam-User: X-HE-Tag: 1736795682-241723 X-HE-Meta: U2FsdGVkX18V8sEBiTururUkc7mIxfO5LNtVJAAAl9HyPps5TH2kuZaiGOOEj9cxJxfAKB/L5x/+A+qgmvlgvXChdAMN+wxTZveWRP1bfsqpsOMjDRHR4jAEtv9loPFkEbzlyjkjybK7oximVIAPgpCum0GYorznJcxVLbhnSnNBeK5/JETGuuUuZPZxQm9+2849tAHUA1vP9LnRKPQjvnwL0QjgN9Tjuuq7lOA97AsoyTXt00NzFmlEs1x7zK9Z/7QmiY5XK6+UL9qhggBEYPsbzFPdy7fTsEmjRN/LR512DzmqGsic0wGrzuDUmsW9/LQS626J/wgejE785w+rjG5vFnZQ3FpxhcMm8gN+cGP1iftdl+GeZz+Os/GIv4dQ9a9oPMtY/0jheOFLYtZWGtQNcWdFvTxGOdbAew0NSUPGYkxIqw1E7qqtxV0fzTSjcGuvXawS9cUGsmm0muaHZihd12/O90r38W0tEZUoCzCNdo/CX+dpnZgBjssLtFtOCN7hG8WZs4hnvYmcDHE/xB9MjrE+q7jrC3eAkT8wkuuA3OHRg2P0AF+8mMYUBBxUQtE2auLXOm8/emMEUWcKTmGxjp9vtFdbM3d5r0sQJ4NbHbZ4zBjO2FiEcjPXNNpl94gNo/yKdnoReIEKWdKU3jROHG9AuOb6/PY482kxkHOE5qQvyBTsFN1CCshMwsbtPIc/BoYv+lJNImoWrflCRPW/RmB6+1809ql6Hso8sKnCGobjM9yCgpKOW9wNs8BZYaE8gm1M6rHx40SzQ2VyCA0+09uZWosUA0KKR9IHOobR06L3GdGLRvU4+KtZyJqsZPZQbEFpS0biTsncRLXRBCQPuvGThkcmfhjAgdtZfSveRuLF6kttp8kP9+cR9mdPn2FDWyK7UtrAxDsqwfLtEMS09bFaSejwHRReEbmjWxvnmqgLkxVd6U0u7Ock2k62Rv9n7uiEhI7vRR1lkXl 9fw1zOGG XDC4u3Pgco1D3c4Z87tqKK/mbSHQZ1Aq9v8lpAJM55Z9BanZJbF85q4uiHEAL+LbiyB0l6HsIVEBuJ76cF8kAOGuszcebMPSoZJo/xG/bEq5Q1INJ2o2drJh0LdKAULxQv+2Hedr0sbxw9/wnJRG9I9FonQTmDGE1F2bCe1GJ9nVF398fFyGV/p44UnXDeEckd2tFCFLohrESPWs8Sf5LWwWmeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Mon, Jan 13, 2025 at 10:39:02AM -0800, Shakeel Butt wrote: ... > Here I think the supportive data we can show is the (1) non-memory stats > readers not needing to spend time on memory stats flushing and (2) with > per-subsystem update tree, have we increased the cost of update tree > insertion in general? > > Anything else you think will be needed? Anything that shows: 1. It doesn't cause noticeable regressions for generic use cases. 2. It has noticeable benefits in the targeted use cases. The above is a bit willy-nilly but 2 should be fairly straightforward. For 1, the main worry would be whether high(er) frequency monitoring using something like systemd-cgtop or below becomes noticeably more expensive on a large and busy system. Thanks. -- tejun