From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BE5C02180 for ; Mon, 13 Jan 2025 15:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08BD76B008C; Mon, 13 Jan 2025 10:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0142F6B0092; Mon, 13 Jan 2025 10:29:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1D306B0093; Mon, 13 Jan 2025 10:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BE7C46B008C for ; Mon, 13 Jan 2025 10:29:09 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8140F1C705A for ; Mon, 13 Jan 2025 15:29:09 +0000 (UTC) X-FDA: 83002812018.19.DD698F1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 4D78DC000A for ; Mon, 13 Jan 2025 15:29:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CdjcRBsR; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736782148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9VqsxP5RvX30QYR7yuJXPx1d9hNGDEzEGpTQhe2nivM=; b=xesuIgxLK4svexDFcgGstoKMRQzsXBIxKbseVeY2s2sY9KmZYU7H0EaYSB1+QA2VgYAkNs hFI2U/QNoPuN7dyrCBtZAnL8fBdwuwiA7oC6TvWKOUq1vt3b7kHQuwN5RqoeW0nK8poiAr HL7EhCnrUpClImUKKwgJEpqQDeMr7c8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736782148; a=rsa-sha256; cv=none; b=5jLDcQLY3ItArZhDBqZhvLg5slFgdmFeac1xJV7jEFr/9H8Ve4h/2YiUbIFj1jbXirMVPa sUVgy+fdQRltBZks8uljlGgSETN9fj45Lhmesyw0c0y6xwLPy+5cdSehgMKy3p2UrfWMHs RswD1iCZUTKC39KXU1JDOix/hCfgM2c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CdjcRBsR; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9VqsxP5RvX30QYR7yuJXPx1d9hNGDEzEGpTQhe2nivM=; b=CdjcRBsRqWXwULJgsV1wbho1ct 7bTBs6L7iQzmzycFuSKc3xawEIdDX6neDB+BsFao8dw/hNdqvsbqz16LmPfb6KE9Mcb0Dpn99jDPU SEpzMg53tgwVFDsj8XeyPgFhGYX9YNh13TaZrHq+5FGvlZ6odcMzl7yyIGXswughRIwhc83j7oaUm 6IDxxbc+Slmv5umkq69QkuB1Ij7g/qM4xeV06Wx5aT2zsL98dSTqjDZ3AqlWb0KCHznpS4kBEbclG n2e52Je5nmDYIbBQFg9qHHQKjP/1tcEMkuoo013fhgQH3BPgsPjDBRHZ1jUqeZ060nyxQygSxdZG3 mRr0GgSg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tXMMt-00000000snb-2w4K; Mon, 13 Jan 2025 15:28:43 +0000 Date: Mon, 13 Jan 2025 15:28:43 +0000 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Andrew Morton , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] mm: Remove PG_reclaim Message-ID: References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-9-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250113093453.1932083-9-kirill.shutemov@linux.intel.com> X-Rspamd-Queue-Id: 4D78DC000A X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: r6q7q1zapmrrhis8s78j81mgocz8hphp X-HE-Tag: 1736782147-958342 X-HE-Meta: U2FsdGVkX183wJotqCPiJHsIU9wOi4ntrmtQ8/19M52zUPOK3OnCuU70HT0MnR+KoihLVPTA5gr4X3iSV+5xzDtEKxXGTGnlpBIUfmXnrkERL0RNedMS08wK226QK5l8oRDWWcCgdKRpKbug5ke5wbHm9TtTHre4hjREDDtPxym+qPGXWHkt5PI19QWa1T/ywOIj9wdfZPw32aRMGKM/nxTYrHojvbW8hXYGMyQKefxNsneR3R0Fb1wOGasMLzXFEJWI+iOWtB8fQ/AoPVfJdD8cG+hcTIlRrSvUtJGNO0CISOTO6YCHl0zlx1dgCC44eLofgUiN6I+7t2l1lULKiQ3s9BL5xOS1wMzn701WuuoyJoK0mH9Hu5UAhxaQcdbSs3q5XPxCB/2qvfvhFnxXnHSssvKIDm9KhU6Xd+3JX1YSxv9mLTGqQK0tDroS5Swkse5QNcf9zn7un+YQzl1gEaJwEdWCiywwTelEOq+QJmXHhq8LsktUBlbjsK344AtvI0Y+ZBrqSVzgetPg8QD8vn6t1e5LY9ejPToAylVtrEu6gDrxYW410K+42oRVvKorUbPisPGTbg8trjGs2jkhF0PDtzVCDleWDcREJ3sfXc9eMMIQwzKak5CCTlsOqMXrXjicDFq2x9ow1ttkp7GtHqGTj+1RvU4U6mZReyPWIBmm53htfzBYyXWb32p9cNb2e46To3C0vmWASmx98r7daVejZ3M36qqfudKPNpLnjhikYfmLOjwUX8T9rXn3NEamzIzLfP2Ls4ZKHCJmjxKsM0DTTTE9rqumD7w0RyMmALCIw5b/a6nVN4jD/Xb21GhrewqibaHHJStFw3plMQLWofhVLJ4VbNsgXgV4W54jWvLAyUDwG7snkh65fgr83zAOoqGm3s7T/MbaAT6cj9Z6ntaTJEVFk4U11dpYdwANA3aZ7qXFgdw4L0A+XyTI4xYNGFTePa9MC0wFb2jnbeb /CIxTo7C 1YZXxa4uKQ/9BwKj+3gom5BapOsMs4GiC/k+K1KhuOeq0b02RQhyBJKBF6nBg4HS2RKWyAR+yRFgYKR8rvIAlvVxN4ofsfbxxnzqGZ5OjMX+cXSwdPBRz/jtRIj7cbpbXW+4WmofPhTfCFDLJjxWRj6cNTqUslWKT7hrseeOZD7qxKtPb4IRaKLGbJByP0zYXtZvvWWqHWHgApX4csQtNYSdglTQK8C2Rpd8JA077wNDDVBgxCSLC1F+kSjxqveEAsbj8PwfNwnL0sOvfTcXP3hJ40w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 11:34:53AM +0200, Kirill A. Shutemov wrote: > diff --git a/mm/migrate.c b/mm/migrate.c > index caadbe393aa2..beba72da5e33 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -686,6 +686,8 @@ void folio_migrate_flags(struct folio *newfolio, struct folio *folio) > folio_set_young(newfolio); > if (folio_test_idle(folio)) > folio_set_idle(newfolio); > + if (folio_test_readahead(folio)) > + folio_set_readahead(newfolio); > > folio_migrate_refs(newfolio, folio); > /* Not a problem with this patch ... but aren't we missing a test_dropbehind / set_dropbehind pair in this function? Or are we prohibited from migrating a folio with the dropbehind flag set somewhere? > +++ b/mm/swap.c > @@ -221,22 +221,6 @@ static void lru_move_tail(struct lruvec *lruvec, struct folio *folio) > __count_vm_events(PGROTATED, folio_nr_pages(folio)); > } > > -/* > - * Writeback is about to end against a folio which has been marked for > - * immediate reclaim. If it still appears to be reclaimable, move it > - * to the tail of the inactive list. > - * > - * folio_rotate_reclaimable() must disable IRQs, to prevent nasty races. > - */ > -void folio_rotate_reclaimable(struct folio *folio) > -{ > - if (folio_test_locked(folio) || folio_test_dirty(folio) || > - folio_test_unevictable(folio)) > - return; > - > - folio_batch_add_and_move(folio, lru_move_tail, true); > -} I think this is the last caller of lru_move_tail(), which means we can get rid of fbatches->lru_move_tail and the local_lock that protects it. Or did I miss something?