From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E442C02183 for ; Mon, 13 Jan 2025 15:48:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB6F16B008C; Mon, 13 Jan 2025 10:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D67206B0092; Mon, 13 Jan 2025 10:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2FC66B0093; Mon, 13 Jan 2025 10:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A65C06B008C for ; Mon, 13 Jan 2025 10:48:12 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 23D1CC0346 for ; Mon, 13 Jan 2025 15:48:12 +0000 (UTC) X-FDA: 83002860024.21.C78A8F0 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf26.hostedemail.com (Postfix) with ESMTP id B7709140014 for ; Mon, 13 Jan 2025 15:48:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ks321ull; spf=none (imf26.hostedemail.com: domain of ville.syrjala@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=ville.syrjala@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736783289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G28yqugAlJScHZ2HkCvTNUvzqa9MzgDG2HADPL1S7dQ=; b=8hd1PFXK37YvSjVabZ5+s1JgefiEuh8Kn0n4CHW+vVVaffGXPWtskLBsIiEENluouoB9q7 oEjtH5mOOtIcWEMfGTPpdZ98IZHmQY9J5K412TTjn5L3P2LgsOC1cWSHeWAPEP1cLEO0iJ HeOPURzJMsdjTnvpvG9h3vXsjxASCcU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736783289; a=rsa-sha256; cv=none; b=uaXIYcBeOTWoi8LaN8jMKo84hVytiGZAxTEzMIRDchGn+OVWhUSOIaPDtF20AHjQdXosah tpAczbfFMVyVJEYhxheiHHCr1dyuK7Uq7yh9hHKGfGB8T6IG1Nyigfu6BrdlIL1k4yIa+x Ds6GqJR/9JFuHoA0GxV0KtfM59nZ7jA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ks321ull; spf=none (imf26.hostedemail.com: domain of ville.syrjala@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=ville.syrjala@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736783290; x=1768319290; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ExydEF6oUbBv3mhxl1sgVJvfB6r3da1uy1h0Ey5whoQ=; b=Ks321ullDJpg5XTiRDSBSCuTbjM5I6UfgV50GHRMSV0XBWs2tELr3GNL bpUOxrjwxeEhK+g6ZxKw9vy/vxCWSNAwgHPFfU1oCY+L+3wMq249a4dZc PpNn+1QASH5xXhBq2uB6aemF6nStCDaoUtkHUtNMq5EEkGIoo0Fu4UIE+ awRn9Xctgv8OEA5AtMhEk2xYSPbWx24qXFHTe1cyGYMIle36zpngDbemE 4a5TwelzwFW2c+83e/LTl3P6ZE3yL005xKGPZykVsegenwvtyEmlz6M9L t/7gGSFhvdo7CGWwJdubgZL21WXbklRM/dP4WwQcg1ysiWCDqw/GxhFDA Q==; X-CSE-ConnectionGUID: L2PDfbJvRLG/LYC9g9JL6A== X-CSE-MsgGUID: u7QlpJ0sR/WAHVSTOtWEyw== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="36340674" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="36340674" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2025 07:48:08 -0800 X-CSE-ConnectionGUID: tF9prx5vSTOp32e9QHNHAA== X-CSE-MsgGUID: idxS4SPKSjyFVgzRZeU+/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="104693236" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 13 Jan 2025 07:47:55 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 13 Jan 2025 17:47:54 +0200 Date: Mon, 13 Jan 2025 17:47:54 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Peter Zijlstra Cc: Borislav Petkov , Mike Rapoport , Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.or Subject: Re: [PATCH] x86: Disable EXECMEM_ROX support Message-ID: References: <20241023162711.2579610-1-rppt@kernel.org> <20241023162711.2579610-9-rppt@kernel.org> <20250112190755.GCZ4QTC01KzoZkxel9@fat_crate.local> <20250113111116.GF5388@noisy.programming.kicks-ass.net> <20250113112934.GA8385@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250113112934.GA8385@noisy.programming.kicks-ass.net> X-Patchwork-Hint: comment X-Rspamd-Queue-Id: B7709140014 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: d5iyme3ppg6r8xdy4khtdxzehui3fe5c X-HE-Tag: 1736783289-943132 X-HE-Meta: U2FsdGVkX18J/pwr8PVRQtQFpuGK6ysPvD0RL489QIBq413kvygpitOHp9cNpLDI7fsLuBNkUvP+HEM79FYN31Rj3BpMljxTZEDa9XQbp13Zv+pH+jgoss4es3XyL0qsmOPNk5kGu01Rq2JGodn0st11DzrAvpdPBvhn4c+Bk4e8O4U3W8PMaMaQiClC2G96G+AkXYdL3tq2dZXkkWIMQRO2eNlEeX7V5Om/N/CjuJmEBFcjfu2Zo+sJrUHXf1bcRly5HUkzcsuI9Gu2Yc7sxCDhh+Lv64U1sOpFeRLh86ZY4TD83Fx4vU1Lmaism7j4KKHUaATXuNehjzrtpsKAfWip8ZCuIPoSyFFGQPendIQF8TOhdG9rU4AlNGc+WRmngXV9/Qaz0BAZc8uVfK2JtIUjaXAAXL1hLxckyhhauWL7+HDRjyxmgz+JK4pw8OeaQUHog+jb3679rozli3+52v69jQvpMsIvkq+lahKtuPyN0Wc5bfbmuPoxUjpO3RYeH4Jwhdh/uY9OZuHClG1MnvJAoHL+eSSrcDvvql4IawXjAhqYAy/6M1XRdUj8TvvNFKL0dlYa1810/6KryKJVVZqjDsTbbITx4hQa5wEUgs5uMUTxgvLIA1sQVuUP/SWjI8ir2eMXVQ5v0rAn02+8cNBFqWppRxZUMrXbYewdEF9UKCkwM4ek+UJWAx7iwJlaefn+TBv6MbGksr4R3clz8WsV2VsidQigOCMbU0n8/Cd9YeqN4o7U6i6ynWf+K2zkC6OqVjvCAILSIjpamrCrzAMke/qeUTSeXgkN8aRFsJVlV26v9SP68qxvYuxFGwlU19d9xUaWeZ7xinfF4DV1nZiDi821zHlwi32PoNM+zbGTk72vDW7jm9UpEJo+048X8FSLrH+PtVtahXjPM/u49BgunH+lhJf7j+C9H8tJZFhjy8R5aCeeLaADXRyX9FSlSDn+cFqpo/gtgWa5412 1Hqrd9xA 6VdbZSB1pEdIEoZQcbr8fKa/ev/vx9YF7qV/Fw8bXV8fVbQ4sc/ZMewBWNDEfSatHRlhnGG1FC/Xm7BWa76h/ryQr85pJirbnX/VTcpk1L9okNx2dtm3Not4XvDUOygO0nDtovvZgr2HMJRHBRRDzy9I+tIV/Y8BDc9MHxrMj+HynJ2tRqAAjzbNIe0j42fMbdzpYM4I8ugyNmtrUl2jqI3XmwGj9yCuR7GiwjrxTnlxuPYGt041V9DGU05BTq3OvR8CWUx7HuBKgD00XNHONjtMi3yWbSwIO5Q5SijALe2/smOjpz+aBxn9jG2socin7OKWHluFFSDF2ft8Hez6Zuuq/MA+AVAXFjuJdKHZQOeC42n6bCKDvaOaXj9sUnLJDpLPiImZdGsTN6zDMLT5DVR9D1TI4tHmBRKmA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 13, 2025 at 12:29:34PM +0100, Peter Zijlstra wrote: > On Mon, Jan 13, 2025 at 12:11:16PM +0100, Peter Zijlstra wrote: > > > There's definiltely breakage with that module_writable_address() > > nonsense in alternative.c that will not be fixed by that patch. > > > > The very simplest thing at this point is to remove: > > > > select ARCH_HAS_EXECMEM_ROX if X86_64 > > > > and try again next cycle. > > Boris asked I send it as a proper patch, so here goes. Perhaps next time > let x86 merge x86 code :/ > > --- > Subject: x86: Disable EXECMEM_ROX support > > The whole module_writable_address() nonsense made a giant mess of > alternative.c, not to mention it still contains bugs -- notable some of the CFI > variants crash and burn. > > Mike has been working on patches to clean all this up again, but given the > current state of things, this stuff just isn't ready. > > Disable for now, lets try again next cycle. > > Fixes: 5185e7f9f3bd ("x86/module: enable ROX caches for module text on 64 bit") > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 9d7bd0ae48c4..ef6cfea9df73 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -83,7 +83,6 @@ config X86 > select ARCH_HAS_DMA_OPS if GART_IOMMU || XEN > select ARCH_HAS_EARLY_DEBUG if KGDB > select ARCH_HAS_ELF_RANDOMIZE > - select ARCH_HAS_EXECMEM_ROX if X86_64 > select ARCH_HAS_FAST_MULTIPLIER > select ARCH_HAS_FORTIFY_SOURCE > select ARCH_HAS_GCOV_PROFILE_ALL This one works for my hibernate woes. In case you want it: Tested-by: Ville Syrjälä -- Ville Syrjälä Intel