[akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
head:   dfbe2aeb5ed491cb9f0a2de5a7ad9a9d4d477a8f
commit: 1bc3c5db9becd0171108c2dcfaf7ef5ef10c1e03 [171/173] kthread: modify kernel-doc function name to match code
config: i386-buildonly-randconfig-001-20250112 (https://download.01.org/0day-ci/archive/20250112/202501122249.upmy4970-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250112/202501122249.upmy4970-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501122249.upmy4970-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead


vim +913 kernel/kthread.c

fbae2d44aa1df7 Petr Mladek  2016-10-11  901  
fbae2d44aa1df7 Petr Mladek  2016-10-11  902  /**
1bc3c5db9becd0 Randy Dunlap 2025-01-10  903   * kthread_create_worker_on_node - create a kthread worker
dbf52682cb0286 Petr Mladek  2016-10-11  904   * @flags: flags modifying the default behavior of the worker
fbae2d44aa1df7 Petr Mladek  2016-10-11  905   * @namefmt: printf-style name for the kthread worker (task).
fbae2d44aa1df7 Petr Mladek  2016-10-11  906   *
fbae2d44aa1df7 Petr Mladek  2016-10-11  907   * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
fbae2d44aa1df7 Petr Mladek  2016-10-11  908   * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
d25c83c6606ffc Petr Mladek  2022-03-15  909   * when the caller was killed by a fatal signal.
fbae2d44aa1df7 Petr Mladek  2016-10-11  910   */
fbae2d44aa1df7 Petr Mladek  2016-10-11  911  struct kthread_worker *
dbf52682cb0286 Petr Mladek  2016-10-11  912  kthread_create_worker(unsigned int flags, const char namefmt[], ...)
fbae2d44aa1df7 Petr Mladek  2016-10-11 @913  {
fbae2d44aa1df7 Petr Mladek  2016-10-11  914  	struct kthread_worker *worker;
fbae2d44aa1df7 Petr Mladek  2016-10-11  915  	va_list args;
fbae2d44aa1df7 Petr Mladek  2016-10-11  916  
fbae2d44aa1df7 Petr Mladek  2016-10-11  917  	va_start(args, namefmt);
dbf52682cb0286 Petr Mladek  2016-10-11  918  	worker = __kthread_create_worker(-1, flags, namefmt, args);
fbae2d44aa1df7 Petr Mladek  2016-10-11  919  	va_end(args);
fbae2d44aa1df7 Petr Mladek  2016-10-11  920  
fbae2d44aa1df7 Petr Mladek  2016-10-11  921  	return worker;
fbae2d44aa1df7 Petr Mladek  2016-10-11  922  }
fbae2d44aa1df7 Petr Mladek  2016-10-11  923  EXPORT_SYMBOL(kthread_create_worker);
fbae2d44aa1df7 Petr Mladek  2016-10-11  924  

:::::: The code at line 913 was first introduced by commit
:::::: fbae2d44aa1df72d0154be77eb4d71e1e34c0f8f kthread: add kthread_create_worker*()

:::::: TO: Petr Mladek <pmladek@suse.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[Randy Dunlap]

Hi ktr, Andrew,

On 1/12/25 6:37 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
> head:   dfbe2aeb5ed491cb9f0a2de5a7ad9a9d4d477a8f
> commit: 1bc3c5db9becd0171108c2dcfaf7ef5ef10c1e03 [171/173] kthread: modify kernel-doc function name to match code
> config: i386-buildonly-randconfig-001-20250112 (https://download.01.org/0day-ci/archive/20250112/202501122249.upmy4970-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250112/202501122249.upmy4970-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501122249.upmy4970-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead
> 
> 
> vim +913 kernel/kthread.c
> 
> fbae2d44aa1df7 Petr Mladek  2016-10-11  901  
> fbae2d44aa1df7 Petr Mladek  2016-10-11  902  /**
> 1bc3c5db9becd0 Randy Dunlap 2025-01-10  903   * kthread_create_worker_on_node - create a kthread worker
> dbf52682cb0286 Petr Mladek  2016-10-11  904   * @flags: flags modifying the default behavior of the worker
> fbae2d44aa1df7 Petr Mladek  2016-10-11  905   * @namefmt: printf-style name for the kthread worker (task).
> fbae2d44aa1df7 Petr Mladek  2016-10-11  906   *
> fbae2d44aa1df7 Petr Mladek  2016-10-11  907   * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
> fbae2d44aa1df7 Petr Mladek  2016-10-11  908   * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
> d25c83c6606ffc Petr Mladek  2022-03-15  909   * when the caller was killed by a fatal signal.
> fbae2d44aa1df7 Petr Mladek  2016-10-11  910   */
> fbae2d44aa1df7 Petr Mladek  2016-10-11  911  struct kthread_worker *
> dbf52682cb0286 Petr Mladek  2016-10-11  912  kthread_create_worker(unsigned int flags, const char namefmt[], ...)
> fbae2d44aa1df7 Petr Mladek  2016-10-11 @913  {

@Andrew: I don't know how to handle this. My patch applies correctly to linux-next
where this function name has been changed. It looks like 0day is applying it
to mainline linux + your tree(s?) for testing.

-- 
~Randy

Re: [akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[Andrew Morton]

On Sun, 12 Jan 2025 10:21:40 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:

> > 
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  901  
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  902  /**
> > 1bc3c5db9becd0 Randy Dunlap 2025-01-10  903   * kthread_create_worker_on_node - create a kthread worker
> > dbf52682cb0286 Petr Mladek  2016-10-11  904   * @flags: flags modifying the default behavior of the worker
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  905   * @namefmt: printf-style name for the kthread worker (task).
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  906   *
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  907   * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  908   * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
> > d25c83c6606ffc Petr Mladek  2022-03-15  909   * when the caller was killed by a fatal signal.
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  910   */
> > fbae2d44aa1df7 Petr Mladek  2016-10-11  911  struct kthread_worker *
> > dbf52682cb0286 Petr Mladek  2016-10-11  912  kthread_create_worker(unsigned int flags, const char namefmt[], ...)
> > fbae2d44aa1df7 Petr Mladek  2016-10-11 @913  {
> 
> @Andrew: I don't know how to handle this. My patch applies correctly to linux-next
> where this function name has been changed. It looks like 0day is applying it
> to mainline linux + your tree(s?) for testing.

It appears to be a fix against Frederic's b1e125dcbcea ("kthread: Unify
kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic
format") so it would best be carried in whatever tree holds
b1e125dcbcea.

From: Randy Dunlap <rdunlap@infradead.org>
Subject: kthread: modify kernel-doc function name to match code
Date: Fri, 10 Jan 2025 22:30:08 -0800

kthread.c:1073: warning: expecting prototype for kthread_create_worker(). Prototype was for kthread_create_worker_on_node() instead

Link: https://lkml.kernel.org/r/20250111063008.910712-1-rdunlap@infradead.org
Fixes: b1e125dcbcea ("kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/kthread.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/kthread.c~kthread-modify-kernel-doc-function-name-to-match-code
+++ a/kernel/kthread.c
@@ -900,7 +900,7 @@ fail_task:
 }
 
 /**
- * kthread_create_worker - create a kthread worker
+ * kthread_create_worker_on_node - create a kthread worker
  * @flags: flags modifying the default behavior of the worker
  * @namefmt: printf-style name for the kthread worker (task).
  *
_

Re: [akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[Frederic Weisbecker]

Le Sun, Jan 12, 2025 at 06:33:38PM -0800, Andrew Morton a écrit :
> On Sun, 12 Jan 2025 10:21:40 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> > > 
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  901  
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  902  /**
> > > 1bc3c5db9becd0 Randy Dunlap 2025-01-10  903   * kthread_create_worker_on_node - create a kthread worker
> > > dbf52682cb0286 Petr Mladek  2016-10-11  904   * @flags: flags modifying the default behavior of the worker
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  905   * @namefmt: printf-style name for the kthread worker (task).
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  906   *
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  907   * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  908   * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
> > > d25c83c6606ffc Petr Mladek  2022-03-15  909   * when the caller was killed by a fatal signal.
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  910   */
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  911  struct kthread_worker *
> > > dbf52682cb0286 Petr Mladek  2016-10-11  912  kthread_create_worker(unsigned int flags, const char namefmt[], ...)
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11 @913  {
> > 
> > @Andrew: I don't know how to handle this. My patch applies correctly to linux-next
> > where this function name has been changed. It looks like 0day is applying it
> > to mainline linux + your tree(s?) for testing.
> 
> It appears to be a fix against Frederic's b1e125dcbcea ("kthread: Unify
> kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic
> format") so it would best be carried in whatever tree holds
> b1e125dcbcea.

Exactly! I have queued it to my tree (with an update to the Fixes: reference),
which should appear in -next soon..

Thanks.