Re: [akpm-mm:mm-nonmm-unstable 171/173] kernel/kthread.c:913: warning: expecting prototype for kthread_create_worker_on_node(). Prototype was for kthread_create_worker() instead

[Frederic Weisbecker <frederic@kernel.org>]

Le Sun, Jan 12, 2025 at 06:33:38PM -0800, Andrew Morton a écrit :
> On Sun, 12 Jan 2025 10:21:40 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> > > 
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  901  
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  902  /**
> > > 1bc3c5db9becd0 Randy Dunlap 2025-01-10  903   * kthread_create_worker_on_node - create a kthread worker
> > > dbf52682cb0286 Petr Mladek  2016-10-11  904   * @flags: flags modifying the default behavior of the worker
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  905   * @namefmt: printf-style name for the kthread worker (task).
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  906   *
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  907   * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  908   * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
> > > d25c83c6606ffc Petr Mladek  2022-03-15  909   * when the caller was killed by a fatal signal.
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  910   */
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11  911  struct kthread_worker *
> > > dbf52682cb0286 Petr Mladek  2016-10-11  912  kthread_create_worker(unsigned int flags, const char namefmt[], ...)
> > > fbae2d44aa1df7 Petr Mladek  2016-10-11 @913  {
> > 
> > @Andrew: I don't know how to handle this. My patch applies correctly to linux-next
> > where this function name has been changed. It looks like 0day is applying it
> > to mainline linux + your tree(s?) for testing.
> 
> It appears to be a fix against Frederic's b1e125dcbcea ("kthread: Unify
> kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic
> format") so it would best be carried in whatever tree holds
> b1e125dcbcea.

Exactly! I have queued it to my tree (with an update to the Fixes: reference),
which should appear in -next soon..

Thanks.