From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4607E77188 for ; Fri, 10 Jan 2025 18:45:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C28D8D000C; Fri, 10 Jan 2025 13:45:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24B1E8D0005; Fri, 10 Jan 2025 13:45:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EB858D000C; Fri, 10 Jan 2025 13:45:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DA4D18D0005 for ; Fri, 10 Jan 2025 13:45:06 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 92D88C0DFC for ; Fri, 10 Jan 2025 18:45:06 +0000 (UTC) X-FDA: 82992419412.19.2B68002 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id F1C5E4000F for ; Fri, 10 Jan 2025 18:45:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oCjkSTA7; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736534705; a=rsa-sha256; cv=none; b=RYLBhcE/IfySKIYhsPy2hlgE+f0Pgx/m8kjHiC1SyDsl2eEvDTqyEFMDvwpnsJZixuBjDv nl8hUlGAA+ACCrAS/t732LtM4205sEJgrP/q+NUMxb50RsXWDymdGDR8FUhotPLrzOfeMK yScfzUFi9uKRek4YcnEwHqG60YioGro= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oCjkSTA7; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736534705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5InbpCOLJKLOI3lB2+B7Tb2EWADmtNQafgcmsUy8GSw=; b=ThTL8wd4ZNZNmhyqiqex9g3A34CYd50llSSRr6nn4mmvy2gAKHEvEtYfDdAR/C+GPvxiLX t1sppEu5QIiHDrt7lAmJw2GddZf6TUbMHfO3FRCeHdz3BkqxARxb9ERtKyU1ho164HCJDy R9OJmGQB1lUOTxrnwc5I9AN21HLOAAk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5InbpCOLJKLOI3lB2+B7Tb2EWADmtNQafgcmsUy8GSw=; b=oCjkSTA7Mzu1SMuWcksT+fx8Wf O/Tv9UCQSNN1KBgOf/hPucOH2i3ARVmZCu68CFgtpsa/RSRjOHDnKCe/Hhma6Wz3U/2/XzEYSEyj9 /3JZUZCpYtA+e0pW3jmFblpUFiDs5Qwv6V2iJnTuIsf+MJqSNQmrVZ4USELHiAyEZo00VreykbWxr 3TmK15isyi97aEOd9i8aJaSh3EsbP9FrmFaR0OD8W7SfTd4Tp1JZtsyiQBoVQBd29fXYVWdvSiW3j wM5cmDMlv7Ca/q44F1rvivvyodEGyJTjEFFeGkiVY+mBoCI7LSYF6o/ZDOWiGBW/r9V76AQUoe3HN dYAveY+A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tWK0F-0000000EBht-1rvR; Fri, 10 Jan 2025 18:45:03 +0000 Date: Fri, 10 Jan 2025 18:45:03 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song Subject: Re: [PATCH v1 5/6] mm/hugetlb-cgroup: convert hugetlb_cgroup_css_offline() to work on folios Message-ID: References: <20250110182149.746551-1-david@redhat.com> <20250110182149.746551-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250110182149.746551-6-david@redhat.com> X-Stat-Signature: s6jyxnrb787muymj8yqrw9ommwwfddfr X-Rspam-User: X-Rspamd-Queue-Id: F1C5E4000F X-Rspamd-Server: rspam08 X-HE-Tag: 1736534704-974045 X-HE-Meta: U2FsdGVkX1885Eu4BNoAAXetV098GlmD+wYM50Yp47IVO2LD7Gu9st1gMiqEG3gF73+II+hk1gjeOS8bcdq+Zr5EvosZaVjJadmmfKSMLMQb+CIJj53PBK7F3u3zSKSqXxqWHo5Urud1NkNnVMiTiQANwyrv56OzHIz8cKKtBFTQqWM7mUhuyT2LmvKCWD9yBzXcYylVLVbJYKm4KGmKRbBh2M9iY12JcgtRbYdc7Fr9gGyZrBBgxJDxfBz2UtNYgQJZFS9w08KtgUVY5zKAoAoJKPkuSLlTAjFnFCF0E65rNk16vGMx1lhnwPO/IcuZO4Tf6BR0MtRwmUjXPbcK8WJgiRPVapMq4Cz1faGbkz4ofzfbPMaSj4wiIAPDnl1avMiAwj6yenU2et12LsQKo+jb3yyCIpCFJlqf+2M0De/uhZIn8A7jZ7+h9THCNg4Y/U0p0Tg5iTEWbWqdoXjlDlTdMiywLEk8sJANQM7xClouJB9T62G4cvgr7zSyA0IdbLW04cMiNNS1/IHunaZ+CZATk8XfKRzNSUNuPVNcUVwlOQ2wyoHEcrAjfnls5YiY9Sssqm49VhIX2E25dx2jIfaFpHrEc/uFjFrvUv7C99p3NSNDHXI2j0q2w+6atUfG1yY6RJWa135Lx8D+q5AcyNYmgR6Uaj2x1aOi0l/kBinq7FB2M5dkeW/qdkvBguwJSvQsnWbZVuI2/hHq5SS4bxz1cgOBZdtvKjf+0ONifJP0FaT3o0ks4L7lDgwhz8gL7wK7kYbh0FsBCMMaSWBjnniBr05P1Y00UTDHvP2uTZ0BvWUp95qXGxSJ6BEjhOtyn746zhEgPgop3hdmKfojzxP7oV9bae/jnWPv0ipzammbfqEyymf6vJBZZQitzYhj5k3zVmy7+5OrJS5/xEre2mYziQ5gjN0XbdiT+d9QDTY6hmNh9Fuvrbh9zIGgOyl/F3kyKGwNLZqDpYc3gZg gtjtCzRx TgoWYKyAWENapagQ34okRlc6GGbaVde/mRNR1eGattcLwUZDq7px2x9D7Uy3RPzzXg3yDZ3pgQCMehn9bHmr8auGf7bIhhD1Iz/vSXGWGA5Z1PGuuokledxrYibDNJUl4SkjZYmuqn9o/cvLyIQ+gGFWGITSbzVyNwZCRSJpfuh/IROgcVCOrbHapQYgfLDF/8hivv8xo4kKe6ElljK3n3efYCG9yhXvZzWHxr6wzlNF0+9rG9yEIxhvTrivb0mkCsv6dV+wlBc/lej2mq3tsH0ir5Gaq627aDtjTcnpqWhIJVkyHdltjLxUf0uH2eKNBmixu7Ck74yhQx6vDTEmUJ0a8eZ9TehNi7qtUfCyvkxwhDvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 07:21:48PM +0100, David Hildenbrand wrote: > Let's convert hugetlb_cgroup_css_offline() and > hugetlb_cgroup_move_parent() to work on folios. hugepage_activelist > contains folios, not pages. > > While at it, rename page_hcg simply to hcg, removing most of the "page" > terminology. > > Signed-off-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle) I might also note that this removes an unnecessary call to compound_head().