From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE315E77188 for ; Fri, 10 Jan 2025 16:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72C5A6B0095; Fri, 10 Jan 2025 11:42:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DCA56B00A5; Fri, 10 Jan 2025 11:42:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A43C6B00A0; Fri, 10 Jan 2025 11:42:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 795FD6B00B6 for ; Fri, 10 Jan 2025 11:42:57 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 310D9B0097 for ; Fri, 10 Jan 2025 16:42:57 +0000 (UTC) X-FDA: 82992111594.25.1F9F016 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 33F3F1C0012 for ; Fri, 10 Jan 2025 16:42:55 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o9vjkB7+; spf=pass (imf18.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736527375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8B9UEM3Amqhe8i/EQ+pCj0mhLJDNX+jIbcuBZxmyH8k=; b=2qCF6/OI4h+XyJEdCEBB5wTwrdOsaIK6/V4Qge4Rcq8wf9hH9XuKLiBi3qZABX3MLVcngG FSmL2BFg5C+a7LctRyJi7oBD9G335tbXDG5r6BllMZYTI+XyjYeaHZ5Z/7PgEi9s0Xa7Eb 6lGemJ3446sV8TOA9eHznmrhJPKKuAs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=o9vjkB7+; spf=pass (imf18.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736527375; a=rsa-sha256; cv=none; b=2Z5iJHX3ntpdmw+DNWQnbszB+nXP6K/5UJk9bnzatKi8/JaWrhuMn9xIJPJB8yuTe53mYl sNEhlbQlCa2/C+1Gh7dJ0FEGpk142N/+tG+nuHcMIlpcFEeUaYE7hYdBHZGlHXKmtpKwZ8 0jJ0zqC/3HxA2ScUb65jEv3lWVMT12o= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21625b4f978so131115ad.0 for ; Fri, 10 Jan 2025 08:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736527374; x=1737132174; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8B9UEM3Amqhe8i/EQ+pCj0mhLJDNX+jIbcuBZxmyH8k=; b=o9vjkB7+kTmW75ROgb1g65buZ83eb49MEcm38ykZO/MoeANW7Z56jH1TFBx5gStSls 6D0wSXTRrkHAmQaegEZa15LhJGPu29tuIv1l8U2EjhW+o5yx7cdhE3LYEv3KPMYRzASe CPtZr63Yyd2Zjyy2duRXXv+xzx60ZTR0WcsgxDNluYJaXAgqSrhRbkTsznwqN8RxlQIZ tDQxFvs8YdqJiH54t7CUU9aNoviyFBYtWA6YopBrOGtMBaDF6rUtrtZqHjZxtp5AZjYO PkQcDGhvt9xI3iSpJMBoMuGoWqCo+7zw0mgsfRf414AcHDQCsLHzcs60tiDraiSmvN+G F+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736527374; x=1737132174; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8B9UEM3Amqhe8i/EQ+pCj0mhLJDNX+jIbcuBZxmyH8k=; b=KZvyooRsBlIxzf35EoTxMSrqtIMCWz8mvU/XmGBnIAlkYuTJFtqg9ov3VsHWH42eAi dbuA1ojKnI7qbsm0S2exdogOoYT49+NKcI0U8v7qLOpxJd4B7wngXzaaRBbm2pMURqi6 r6qEYMNDuRixTYiBJd/SmSO/hWjEurE38j7HzjbNi9ZDp9PAdV8F35kfWBABsADy+mBc ijiW7yVsduS+Ogmb7wCmFQqMgZcWjuYBiqeo/xOavR1XcKRL++yvZ6aZJzzUEb3Ij4Qi NTiKSaS0VC8icMxXO/PDX8HL77AJ+U392KlvFeaUWmwHL58j/DcgJSpfAsUg0pahAx+8 3sYw== X-Forwarded-Encrypted: i=1; AJvYcCX8Ajn4SxTml4a9DEt/hAacZdIGPTpJsB9/DcCAhto0WBgwMXJGQU101Iqhr1OhTMb4TXbSO1sa+w==@kvack.org X-Gm-Message-State: AOJu0YxDJKJp8qQ4TnTwWRGj39clAFk4NytamFmaLTimrBi8kdaCpKSO 1mVGAGMTbSBoRBsT/bv3bQxNLQMe/kNEDPmqw9KhZeFB54lkEWirSJ+OsDb04Q== X-Gm-Gg: ASbGncuMu1jnU1q0VZ9+j9hJJwc6EFQdbn7BDcd0pzBacptclNcd8//I3FvP3ZMmLli bUo2xzRNz6VCTqp6LrRzwl4j+sUquV1ED8WqwRnPNTAo0/x7I18ACMetJsTcCg5KEKbqbJczrOH IiOjyC4kA9U9+vp604gxMIkttS3VgAX10d+Kp9a5kojZTb8oVwUgJuucTsw1S6+NOPLRKcM/f8k gSDzcZX6mT9+urlsZfBrLjpAfhmpqvYH7xfmsiJPWfdTa9K6XzPEORPxA== X-Google-Smtp-Source: AGHT+IElpsrYihhFYviENoY8X80XRkHv+RxF4IdnwvSfZybXx4mdHJqjSDS5ZB5vhbkvbrYg0AMpFQ== X-Received: by 2002:a17:903:31d8:b0:216:6dab:8042 with SMTP id d9443c01a7336-21aa07f34a2mr2672725ad.12.1736527373861; Fri, 10 Jan 2025 08:42:53 -0800 (PST) Received: from google.com ([2620:15c:2d:3:99d3:ef93:6e2e:8b59]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4056d477sm1719467b3a.42.2025.01.10.08.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 08:42:53 -0800 (PST) Date: Fri, 10 Jan 2025 08:42:49 -0800 From: Isaac Manjarres To: Lorenzo Stoakes Cc: Andrew Morton , kaleshsingh@google.com, jstultz@google.com, aliceryhl@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/memfd: Refactor and cleanup the logic in memfd_create() Message-ID: References: <20250109185908.1006310-1-isaacmanjarres@google.com> <20250109185908.1006310-2-isaacmanjarres@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 33F3F1C0012 X-Rspamd-Server: rspam12 X-Stat-Signature: xz66ryhw8g3ijxic4kksixiin4j8bubm X-Rspam-User: X-HE-Tag: 1736527375-337655 X-HE-Meta: U2FsdGVkX1/KVA74edMjYStnvARp47R6fS7sK2khi5Tt90ZV9Rkt/ggRHfpXffYTB2uenFgjPJHvoHFzTupCRJgRI0pa4OYFiLhzhOwP1bKWEhset9F+2GwLwCkaIfPQ7l+VdUw+2GOxKDv7N4VDhqvI8FG6EpT6ZCdJGw9cQL6FamuuBbzhsXIl9LRX3gTeNO/tS5dkN97JmO9k5docpkktbnR0uKxsYOGtz8d4fJrdZg++7RwClQxf6scbGv7hHOwI3jj1Cq32Nm9SPwpq5FJ8amEbHN8QnBLpBCK660wjwpl1S14HON3u5TgrTqdZOnEFzi5ltHzTPx82zA8Ga0cDY/zd9+QMAh5MeTYTHZdIc6GPqOQ3yb8fqs5x5UoNINj9a3/XsSS5/m8tFEID/ff//4Pt+OHBDdYalPIRw+S0GaZd4qJrBohjOD5XLKwgjnEVOtYhZoPFByaJQ2St+Fz7aa3k33Xmfb0JD9ftqnAIMoQWT8rZfegywFYPe8vyu+2xR8W95UNH4u2L85k54GKWa1ltf+QHutIhfj1cBER0XVgwni41QbaeB4n4ZUWwdkUBF8+JZJrc1/B7O0/ayf/t0i/B1+4vL3sZ46WmgFhDxzAJEnk6AudUMAjVFYM/JyVCibwMVKRyRKW29epT+KaIVn1XbUvi2US0DRBJVR3nK0QVjGis10M6/cqv0g+A+WPZ7WPpahjm+8x6Dx4WBZFYE34CUTq3UJPkg1WIBWECnTSX4ewCgWfUadDq/E20KbM8HuYftmXSmRKAX/DmMX5t6LHaoDTnomzbUkDZhHIWN3k596LV7NCv4wzT7bmoZOteJ3pSIoPUesRHrz7TFfVSgGTT3ERJXuSTilsGoui60ala2Mt13wTnfkeNZK0jSfz+IdAsMHAdtPrJKwloSttl+SCbS5pXqZNe0PLdDEFJczfzrlbf2CqO3sVpQDXgEAKeB0X3bvutnjhjiwN rAftaXEt wkNJqDV1BLoBMVPX1D565ysxu6Phl7e9PJyPlA/6V4qiInOmpkgtCjZcKUWLCN6dVXhghVHAGs1sIrMNZ9c26yfyLUvYnbmS+tM6iLCYYDLv1uqfPzL73/U3Ge8Ab0o0wMY2rr5Repl5jNBasevKwQ4Dd4i19fs97L9ymHy/LdAayDjyJqUAoT3kEaKtxj7qW3va9Za1qpKLh8u/tU4y8IBE+A6o1XSb9YxKrjMagXu0pzXnUTDOSGH986+cAlpydXg8yP4ub+JnyROncmuQer5vb/s4S64toZjm2Lm6wHfbO8TVHA49WrELF+L4lguBOyKe4znE+gdfWftVW7qLaIDOpucwsZ55Lyj88oQtfZ1n3GxoiVDRhmhx1aG9zSkI20pyzJDNs3Rsw6abTRSNcR176GiF57n7Cl4uraGGApm44+ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.422221, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 12:47:42PM +0000, Lorenzo Stoakes wrote: > On Thu, Jan 09, 2025 at 10:59:04AM -0800, Isaac J. Manjarres wrote: > > memfd_create() is a pretty busy function that could be easier to read > > if some of the logic was split out into helper functions. > > > > Therefore, split the flags sanitization, name allocation, and file > > structure allocation into their own helper functions. > > > > No functional change. > > > > Signed-off-by: Isaac J. Manjarres > > Great this looks good now, thanks! > > Reviewed-by: Lorenzo Stoakes > > I agree with Alice that the comment re: kfree() is superfluous, not > critical, but if you want to do a v4 feel free to migrate tags to that. > Thanks! Yes, I'll go ahead and do that. --Isaac