From: Isaac Manjarres <isaacmanjarres@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kaleshsingh@google.com, jstultz@google.com, aliceryhl@google.com,
surenb@google.com, kernel-team@android.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm/memfd: Refactor and cleanup the logic in memfd_create()
Date: Fri, 10 Jan 2025 08:42:49 -0800 [thread overview]
Message-ID: <Z4FOCRf5SBvpcsk4@google.com> (raw)
In-Reply-To: <b5cf5046-de0e-4470-b020-877fe2b0c4c2@lucifer.local>
On Fri, Jan 10, 2025 at 12:47:42PM +0000, Lorenzo Stoakes wrote:
> On Thu, Jan 09, 2025 at 10:59:04AM -0800, Isaac J. Manjarres wrote:
> > memfd_create() is a pretty busy function that could be easier to read
> > if some of the logic was split out into helper functions.
> >
> > Therefore, split the flags sanitization, name allocation, and file
> > structure allocation into their own helper functions.
> >
> > No functional change.
> >
> > Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
>
> Great this looks good now, thanks!
>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> I agree with Alice that the comment re: kfree() is superfluous, not
> critical, but if you want to do a v4 feel free to migrate tags to that.
>
Thanks! Yes, I'll go ahead and do that.
--Isaac
next prev parent reply other threads:[~2025-01-10 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 18:59 [PATCH v3 0/2] Cleanup for memfd_create() Isaac J. Manjarres
2025-01-09 18:59 ` [PATCH v3 1/2] mm/memfd: Refactor and cleanup the logic in memfd_create() Isaac J. Manjarres
2025-01-10 9:12 ` Alice Ryhl
2025-01-10 16:41 ` Isaac Manjarres
2025-01-10 12:47 ` Lorenzo Stoakes
2025-01-10 16:42 ` Isaac Manjarres [this message]
2025-01-09 18:59 ` [PATCH v3 2/2] mm/memfd: Use strncpy_from_user() to read memfd name Isaac J. Manjarres
2025-01-10 12:48 ` Lorenzo Stoakes
2025-01-10 16:43 ` Isaac Manjarres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4FOCRf5SBvpcsk4@google.com \
--to=isaacmanjarres@google.com \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=jstultz@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox