From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ADCFE77188 for ; Fri, 10 Jan 2025 16:42:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04ED68D0005; Fri, 10 Jan 2025 11:42:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F41378D0003; Fri, 10 Jan 2025 11:42:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E386D8D0005; Fri, 10 Jan 2025 11:42:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C02778D0003 for ; Fri, 10 Jan 2025 11:42:05 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E07631C7CE3 for ; Fri, 10 Jan 2025 16:42:04 +0000 (UTC) X-FDA: 82992109368.29.319D42A Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf22.hostedemail.com (Postfix) with ESMTP id E90BAC0006 for ; Fri, 10 Jan 2025 16:42:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CEC+RaUQ; spf=pass (imf22.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736527323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dV58z0nJ44j5t2aJuwKc3i2eVlBRn5ILcjtzVtoWX7w=; b=4f2aNWXq9290z+nCkKqH7BX1qn56fsaTJFkAwdq5/nwSMZeCpy7gAldzdHvNUpkcx6jYrS YlMpH+NlfI0HOayPKXB/yTWbh5Ws380d+XW2lkclBTbQRDxjIPaGIC7tbnbnAMUaNCeKu8 ul7cwsFSUr+mLkRHsbA+8F1CKpDdjKc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736527323; a=rsa-sha256; cv=none; b=rysANOdPcVP2AYJ3Ztm6ZG5Ak1zVY6de1yy7BFwamiYS2fZyg8BYRAu9Kd2BqffyxL2XQ7 PHunSPUiBnzzG5ax9J1AncZKQHQUZiZ3v+ZquQ4vpwivn4Sd5MAT7h7yB3ksS6SksryDky JWrlDQgBHjqZDjGi4A/Ij2jAbPg4xH8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CEC+RaUQ; spf=pass (imf22.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21625b4f978so130995ad.0 for ; Fri, 10 Jan 2025 08:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736527321; x=1737132121; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dV58z0nJ44j5t2aJuwKc3i2eVlBRn5ILcjtzVtoWX7w=; b=CEC+RaUQxVgd9ntpCuiXe0nRMgX5uP/Nig60Y0+xKBbPJEuzU4GREg8GFn65057m+6 MpSBa1KTZi/U6y6oMZArLepnyqqtW2bhs7yg89J/d4W6HVIvwSnmpq2ZbcjBETj0mV7P pJ87qE8Hd02tdud61cOCurqNVy5i6XlzvfIk5slfxqR7+D/ebVws9sCqYlmWv7SYKrSJ x3CkXNyJFPWuRJ7fY9pVOMYGDdQOq2lmoku4IKOujcJb3ayZCK3lY2aMDm6E51CWxh+G qRmYz2hxxjMhZAmSPcIimcbI7oVdUnaVzWBYTpWrQzNnhBf4MuhCdNonBgbdggIGxTfD W2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736527321; x=1737132121; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dV58z0nJ44j5t2aJuwKc3i2eVlBRn5ILcjtzVtoWX7w=; b=lZ/ab12zt+ETwhxIoAw2HQY1g8svB9w2b/RTzTKPjcpHffGzUGM/2K9nzTNbsanG7s ONOW1HeDSG5dL9VfwLV72WSJ1cZMGT5t/MvgAv9vV8527dBRIgFDOj+2wH0UJTQRoPGg OKpLxtb4I0vKvqrGHlFh3qYoQLelV9TtG8NtCPQjZIXEFJjOcnfg3ZqUSSsPlUSQ4gIN FEAb3TEi2TOs0wYY87biBmVw/JdwnrqB2fVpXrsOCZh3soKuf64H/1hWCwsyCr1yEPjH oZGeLKBXEG29UIwj71mQuMm4l/ZRqsCboWCwndAuoV/Il3xzndIljDRjCQz6D08LP/eZ POdA== X-Forwarded-Encrypted: i=1; AJvYcCXc+iGlKaG0q9cyTKcTOP0PqFq1nWU1YgKwSTA27yuaN6KOP/HekcORTrB0KJwFJPTl/Pze9XO4SQ==@kvack.org X-Gm-Message-State: AOJu0YwK5Ju80kW5hRboVs80vLtZ2NeEKt4OssXkBT105AcxK6RPyNR4 SPZi7DtCcVJADjky2l8VITzLQPcE6JAdmnhF4uxgQ4bItGttq9t/baid3SW27g== X-Gm-Gg: ASbGnctx0w/+Qaaiusx6gqSSlPjo+6J7sdbsJiuxEpo3lrVuVc73fRdQj7VLd1Ypqoi ZIyNn0gEqEQkVjnZlntSrimwYRFzbNPxnwGo1seaRpupdjtkliZNVQK/qJxWJf3Qa7Tg5K+7NCa Ob0wSiU347haFvhnjrx5jIcblLfnhKAR6MNakCNuxJZYPXs/jXoTpcQ5Yf9WIrcbgPQLRTlfJC0 qscITCPTEl6BSou1FrpLxx81hyo1fE215cbGY/3xWe0ggrXQI4ZnqNEDg== X-Google-Smtp-Source: AGHT+IFXrt64XWN5+xxbt3NGJ7TQWkuqYQKPyGO8+oeAQoVify+8kHR+ehnu9S0Eu95eQXGzwLq4qA== X-Received: by 2002:a17:902:7088:b0:212:26e:1b46 with SMTP id d9443c01a7336-21aa33b7344mr2173005ad.23.1736527321425; Fri, 10 Jan 2025 08:42:01 -0800 (PST) Received: from google.com ([2620:15c:2d:3:99d3:ef93:6e2e:8b59]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f219a94sm15767945ad.129.2025.01.10.08.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 08:42:01 -0800 (PST) Date: Fri, 10 Jan 2025 08:41:56 -0800 From: Isaac Manjarres To: Alice Ryhl Cc: lorenzo.stoakes@oracle.com, Andrew Morton , kaleshsingh@google.com, jstultz@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/memfd: Refactor and cleanup the logic in memfd_create() Message-ID: References: <20250109185908.1006310-1-isaacmanjarres@google.com> <20250109185908.1006310-2-isaacmanjarres@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E90BAC0006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: d8chwmqqprh7s77ss54mwrjsxnm3dat6 X-HE-Tag: 1736527322-398139 X-HE-Meta: U2FsdGVkX199A8XBtboWZ0VM0bfWGosBp8Ldd8V3Mingjaz5aShDBaKXjfAUPJhFwwYCD5OiUf7gsVVISHEKxexP3FLrisYT8qxlqzZXpMtdvhWhgGk1NQ4HKGPtruTEeNi+uecbuqsnlRhMYtaqHF9JDNC+HzE8pRNMuT4nu+hsGt/SZMPXRwd+TXRvBaC/Uj3SC8uluCoLtgMo4B5EAvrId9X+NuUn6Pd0fEdw9LQ1JifVrq++PFv7DwzRQ7vw98Uip3YKsee8LqL0DQioNS0sok3GyWVB2UuxEteJ1UU2QDrF2IZKkpbP7VP9u1Xk6KW07pWXrvvdbMKH06Sap+EoPuqRrW8hxBHdIw1M1DZbI8MY6ziga4s6AhSGNoJPley/5EhtMhVY0z9EQJXz97PDVRRac9jm6X3vk+IjjK0z51kQATau8WHheuLSFKM6ieW++/xZ3+PpdcSsOP3TMdjyjTpqOcDjvhzfUxP4NhLNAe/UcqQVdQXjtyAS85rj9k1FQ+9fCcm7wM+jfZQCwzRNuCSZQGWRQfyRr+vU5C/+O+oaphCRT/PJLRhDLd9Nn5eK2gBXS2KS8tZBiUn6kwl/m85qQ/vj1ZSwzbPeIayXwhUrZ1gxUWejhMrDOUXkhw7Cicf/EI8dWCuAofxI4x2etiLfFkoRxl6Q55jPaIYddlovg5oLc8T/gjfOT4vnz3gfaXU5YHj/QBoM/UF8JD8EBFMsiP9/aM9k5e9XCuQ91HGN+nXtrz3ctlYowqW+Wfzb4NkFMwKwpWEGG7lL1HXyLEL4MGE4zgndl9RqPOjcELHu4evC6Mwz2aM0Or9Gz9frM+4Iw5DISsNekbORZ0icIkNlVlwPO1sEOVGfMfbJOJu6vDrKhWCWmVFCIV4EBR5nCvPXcsRIUWvp2ZdO8n/h2O8Jvsvoa7KOkh9moLbLookMkbsiSaKSY2vGzEAJ/pkx6PDjGmr0MyGRO27 zP6+tlzA u3nEVAdIWh1VUhtk7OLOWeLx48PzaRXbov/iOdrNyR5nnKVV806co2+RyY+00eTt6khDi6Kb6dvA8++44b4QNNWUowJN7zLQVcFSH53lZ2lYBXUnbPh7bEwVEfb6iPdT1xRB9R/wHC4ZynSB292LC4D7TuPLVDQ/+c4ZcDNf+E3U8V+cpVrhCvVbMuUEkWoj4g42S45+/EOPpBOM8pfvXSGQ73tJdvGATk88YvWQClDuf0VzPYokPRT6ZUA/PvnfEYb/yHY8eH4Wfo57yQNruEwlB8IDLkR9CL2/Di/wKOU8E4/S6GDgqnj5kio+bKSU4k6vSzb2kxA8q9cFRq/PjHOkWKxGe5ncNQok1Q4u09tUfIo8O0nibQ0FUMtolX2BHDpF0aVbUmms5n8KnRhHg/1Cg0RR08bg4Hr6hdUn83pn9LeHiQOn0W3KtgUHPBfAVzmlkc9CgHj6vwyWWxvVpPloJKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.422424, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 10:12:13AM +0100, Alice Ryhl wrote: > On Thu, Jan 9, 2025 at 7:59 PM Isaac J. Manjarres > wrote: > > > > memfd_create() is a pretty busy function that could be easier to read > > if some of the logic was split out into helper functions. > > > > Therefore, split the flags sanitization, name allocation, and file > > structure allocation into their own helper functions. > > > > No functional change. > > > > Signed-off-by: Isaac J. Manjarres > > This looks reasonable to me. One nit below, but: > > Reviewed-by: Alice Ryhl > > > fd_install(fd, file); > > + /* name is not needed beyond this point. */ > > kfree(name); > > return fd; > > This comment seems superfluous at this point, since kfree(name) is the > last statement of the function. > > Alice Thanks! I'll go ahead and remove that and send out a new version. --Isaac