From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB42E77188 for ; Fri, 10 Jan 2025 12:49:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2C288D0006; Fri, 10 Jan 2025 07:49:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDB268D0002; Fri, 10 Jan 2025 07:49:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCA1E8D0006; Fri, 10 Jan 2025 07:49:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8EA6F8D0002 for ; Fri, 10 Jan 2025 07:49:55 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0825A4425D for ; Fri, 10 Jan 2025 12:49:55 +0000 (UTC) X-FDA: 82991524350.21.56E22C0 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf18.hostedemail.com (Postfix) with ESMTP id B727A1C0015 for ; Fri, 10 Jan 2025 12:49:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cs.cmu.edu header.s=google-2021 header.b=QhM8Nqaz; spf=pass (imf18.hostedemail.com: domain of kaiyang2@andrew.cmu.edu designates 209.85.219.47 as permitted sender) smtp.mailfrom=kaiyang2@andrew.cmu.edu; dmarc=pass (policy=none) header.from=cs.cmu.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736513393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vJky8B4EAIREUHVvUfhJ8ETCIYAkyvIKALgrInQ4Iyc=; b=ElaQ6sbfgbDWNHE5pD3RhHO8TKRK7Vg6eaZMxsaym1kCX6ntO4wtKJjvzWRJgKeEuL3V87 2pp+lhko7rsQukoQXjh7Wrnp9gNlJvdCueP+iL9ccF2QQu+3Tgvp7r++vukrou1XOPolAj fs0IjBtG/zpEUSemBg+pvzhhRaecScg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736513393; a=rsa-sha256; cv=none; b=a3ZcvY3lgN4oGLW6BtpK0dZe7qnr/wirGgd9zs0bGjzZcc8MrZx3Ft15IqyostCLrbxQzs pc5X6nS36TLff+3Rg7C5++s074AK/6fldVyVoYsRCIDorLbwPLYtLMJH+OiUn+8E4tiY/A KKqhvBQCjhHuQ/wOa9hJngXKTEAEyuM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cs.cmu.edu header.s=google-2021 header.b=QhM8Nqaz; spf=pass (imf18.hostedemail.com: domain of kaiyang2@andrew.cmu.edu designates 209.85.219.47 as permitted sender) smtp.mailfrom=kaiyang2@andrew.cmu.edu; dmarc=pass (policy=none) header.from=cs.cmu.edu Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6dcc42b5e30so22501646d6.1 for ; Fri, 10 Jan 2025 04:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.cmu.edu; s=google-2021; t=1736513392; x=1737118192; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vJky8B4EAIREUHVvUfhJ8ETCIYAkyvIKALgrInQ4Iyc=; b=QhM8NqazS50t9lqiadTXNW27ijmXhBUm9+yAZ8BChGHtPSKdBbb8wemNRqU7xDJ+ot KVGQ7e55xgMrNTgUxg9abLbaV11GSGD9K/BFlPZME9zlDmMcSGVnyhB4j8DX/23rvNTQ 0JvOULy+ug0D0TxIi75AxrW4thpLro7hZZlB5Mbh6Ri8J8TyAUtnGP6tGf1codi+san1 9NopOYXrDmdHSuaes/CFhik5QMibHbayac/JgDQKUb5n+Ud+8Wq33dOnF9cOjDYZ0iQS OyKnPc7pcjp/rev4K7bafjRPe+MSudPsSaP3vVbmHUIqet1B+cubjdrqb0GodddvlLM5 +s0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736513392; x=1737118192; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vJky8B4EAIREUHVvUfhJ8ETCIYAkyvIKALgrInQ4Iyc=; b=wVSWt+j9XLhtrvKXPKbs1cTW2VMTrfRKnotBUU9h++DHGXpxn+u1AWLpET1uj+rt1S 9tlKllC0bQtaRUpCINfjzV6s+rYUvfoXIfMhDvL3pFz4mQJCyA+Qg9iBqCBxgf2nchJA kXzcdKrg41YfIIX+beZ8bijbfrDdoa6Gks4bmG+4K1jmz91uV+TH7EJ6QrINbA+Z3X0s uWeIMB4Qjbe2VFc5QEhgnb4vhrzNQFVs1zBB0bSjchgTwMM4b5I5zNHixFjysU4UBpOq ab90SHasOFt6E+JCvVa4r+aDdyPsS6mfUwuelr8XBzwud65Uoeak2+i+JgnFp27R7m4p HqGg== X-Gm-Message-State: AOJu0YzzSVMro8N3d7FynUvRtBG1/zD8KmqGGSF4XOJupnM0pDdpoeH+ TbzeynIPFQge+D0GC0n5cvvPY12k9aaHHp1xWvPIP7WEPtZgrHUe2gZBFb9vPg== X-Gm-Gg: ASbGncsohh8x7rl72znQsIKe4afO6oWEIlvxhFETrT0iqYXTEZl0iSLf0k2fJUVf0Qf cN9AaMRUDh+mNcN5M3d54b+kxSpZOA/AR/l5CPFqCuCp/BS/0I+fQ/68g7dktNeZT9zWa8e7Ohc Hc4dsmLQMdH71fHC6TSEO+56aQ47mTTP8vabtZTabx3R1QRh5E7xsMk3yWiHgnLO06W3uByf6Jv jY3qV5umcer8EUbhP9WBDUhtbUqGWNqn74hGbKnZz9MS+CBzgYGvXfKkMQ9NvNVwM2KVm356ufO 4ABUfk4AEUs+c7nddXUgJHy374PoMSgROLlnAQ== X-Google-Smtp-Source: AGHT+IGLBvKrivi8j23RZOR9DDS5CjiSRR9Ak4BiI0aARHL5/HRtUGhxyK1GHn5l3KK6K29SIc3yPg== X-Received: by 2002:a05:6214:e8b:b0:6d8:81cd:a0ce with SMTP id 6a1803df08f44-6df9b327016mr187334626d6.43.1736513391826; Fri, 10 Jan 2025 04:49:51 -0800 (PST) Received: from localhost.localhost (pool-74-98-231-160.pitbpa.fios.verizon.net. [74.98.231.160]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dfad85ffbasm8870066d6.15.2025.01.10.04.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 04:49:51 -0800 (PST) Date: Fri, 10 Jan 2025 12:49:49 +0000 From: Kaiyang Zhao To: Li Zhijian Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/vmscan: Accumulate nr_demoted for accurate demotion statistics Message-ID: References: <20250110122133.423481-1-lizhijian@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250110122133.423481-1-lizhijian@fujitsu.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B727A1C0015 X-Stat-Signature: ge1wu7outwomxgdcumg34ac96egntnuu X-Rspam-User: X-HE-Tag: 1736513392-401908 X-HE-Meta: U2FsdGVkX1+uf5KdDTSDP9/P9WRoFGBwOHBTfae71hnFYfTZRJPXOzpDm8f6q9Ay9dAY1t7ogizuAhBitNiK372xBRyrCTU1qrWPzGN8T8dpq0kNOUdQcMr80SsdECy7slZinjLl7/RWUhIAygGoOFg4z61+ZkIP79qDK7aBYN0pdMXps5T/MgfGbPbGj4QmAG6xvLRjpYBgKUHeeSLF0+gMogY4qLwAZywGY1DxEevbMjhwmffAaFYv691ZPipPZWz/UkbbJxbCSyqpHQv5v8LHHXgXW/I0wWGH5T2M44c2jlltdWhsdreEaGZuqddE3dEOD5t7h4BBB3XvlAEP0ljWJjS1G7N/tvKarCqcesGt2RPFiGn3NGFgIGQCbCuiAYi81h1z4dNCvrbiro4BzfjuzUQjzhnJyXfhdBuurRA9dhjFWyVr+1lxCF5L8IF+vPhpGn/GG7ICIR05xvak9TuDGS1WIi5QBmf1eZHNryTqOXmusT80GPXMIFG19ekqXZ7QCPsNX8TQFzJJcCnuMUKvEqy5CgivCjEFPdmCOpb+uPfSFbVggrLUPSj1aWAhJucRyrZQM+uxsZKFqlQXc1wBjaaaB5X/D1fBkHqyrcB/cXcCn+DidP+3fKAnp+euhFXtWXHg1K2KCTGsMIgf/YyGabkZ47wWTtdBLFLMw3yKKjUu14okkfv35kEk/rc1b8c8ymsynizAkC5LXOrRhaOGZj1jjyo/3x9rDWpsxapaN+dp5aC7FvZNMV3cZ7n8fo/o0nSwzalPB+jZNPaPIQmC8CyNnzoWsSwNgDHWoDXTm4u1ClVuJjaHmm91xgK7WbPdu6G6/98B9DAAXi/k3Ms/6ugDadvxcQ7Nasd1Zh4/KGseE5BqonXTlcYB/lBzJYUcjnyBRk44banhTbTr/iDnAzIbFOGxuo5zBOaUhV2Ws03LBToSsOwIsWpQFKDzAT42RiZ++5tj41TiL7U Sv5Q4CgK NTZMtTlYdUzB7NII3V0w5iG2D8Es3bu5R8jXcziKR5jgp9meg+AlByfHAVadBcLcWiEHd03aXVPKpGmvFNhxy8Osxx7N1BoGZEwja6b8zm5vDqIWO2eek+caNV4RVAQAGXCVvFzKiMBwkUV7X2zPorLFh/xk86omP1K2MUz/OjWzqavzr//lGCq+EpeYgsH1cgNwpDCRsXPXvMStpPE1THTSv6dm7uu/mecS1By144QNRoWhuy/x02g2o4G6eG+jqfZuk3ymMfyEUwm9Ei7CVQmSqeEqPCJTQwpzgGc2/x84vXnh9DhSUQig+03s3SOOtifAHLJxnE0KA+APbVmA2glDxILzJ0MB12ZZJu90b61htB+uvlQW8tP/Yt6iuS+KawyUN9jqf2fQhJPRwsW/I4HO+uF0+E8i2MVFp7nab70XcVOQ7BROTuCjXEG/7GaYzKEI5oo8U/TSczLfH9NnrzrxZ0g== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499825, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 08:21:32PM +0800, Li Zhijian wrote: > In the shrink_folio_list() function, demote_folio_list() can be called > multiple times, which can lead to inaccurate demotion statistics if the > number of demoted pages is not accumulated correctly. It looks like demotion will only be attempted once. On the second pass, do_demote_pass will be false, demote_folios will be empty and demote_folio_list() will do nothing. But I guess there is no harm in making nr_demoted an accumulation for less confusion in the future...