From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D64E7719C for ; Fri, 10 Jan 2025 15:24:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7824E6B00B9; Fri, 10 Jan 2025 10:24:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72F5F6B00BB; Fri, 10 Jan 2025 10:24:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D1576B00BC; Fri, 10 Jan 2025 10:24:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EC8906B00B9 for ; Fri, 10 Jan 2025 10:24:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6642CADB61 for ; Fri, 10 Jan 2025 15:24:17 +0000 (UTC) X-FDA: 82991913354.10.2627FB3 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf18.hostedemail.com (Postfix) with ESMTP id 4D9F31C0009 for ; Fri, 10 Jan 2025 15:24:15 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cs.cmu.edu header.s=google-2021 header.b=YJZsGiTK; spf=pass (imf18.hostedemail.com: domain of kaiyang2@andrew.cmu.edu designates 209.85.222.175 as permitted sender) smtp.mailfrom=kaiyang2@andrew.cmu.edu; dmarc=pass (policy=none) header.from=cs.cmu.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736522655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OOepsUM1TiRNJGNg+5Q+9ESc+ok+SkXbqe3ywE+cOlg=; b=fGRi0UI9sIRAUDA26v6ckabBvZnFKvmwWBkY4roIFFpszmiOCtwVCqDKOj6P/8zN0Rdhtz 1+be9SG7Z5Uk2A9OH0ftyb4HbLA5VgmPTbKKsnsvXUz2MBD2l6JsIwcQc9KYPVrAxga7PT JjenZg4E7ux/h16vO/aDL5LDMvyKpEo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736522655; a=rsa-sha256; cv=none; b=612kd1629pcgymeN+ZYPbkJVTzm0Nkztj5JX3TBY0gOJnmmDWn2ZiNK0R+sT4PhWRyWaY2 LK/0PECSJ0gv/kHq60vBtDz5j8psLN2mwyA9DQAVz+zYgGAhfx8K8UqtRIhIGVlErwB1Vk Z7sPY4qbJyKfebvklnyXDQXImFmLm7M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cs.cmu.edu header.s=google-2021 header.b=YJZsGiTK; spf=pass (imf18.hostedemail.com: domain of kaiyang2@andrew.cmu.edu designates 209.85.222.175 as permitted sender) smtp.mailfrom=kaiyang2@andrew.cmu.edu; dmarc=pass (policy=none) header.from=cs.cmu.edu Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7b6eeff1fdfso178683785a.2 for ; Fri, 10 Jan 2025 07:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.cmu.edu; s=google-2021; t=1736522654; x=1737127454; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=OOepsUM1TiRNJGNg+5Q+9ESc+ok+SkXbqe3ywE+cOlg=; b=YJZsGiTKjaCFpZXlu50Yq/BjklhgNOGT5qVeK2uDuFnXXgbmAr7Sq24APxmvlQymVw vARxiwin9zlpCYzBlUW++Iu/opNPYxNKSjZULdPM6sdV76m8pP2JDf5sE7NAo37JBw5m uQiVFBOiAf/kR8J5/J0vJBtG79u5Os2W5+QU7eFX5xvefqpTfI0xwDd/aSamkBMA9j/Z 5MNmenE6ex9JvbnhUoR2wX+eMzt1s3NJj8l1vzxJxc+zL9Kkd/inZ5dQjfGxqDXgbSAp gq8I0H7vahrkKMInMzhuDXE0eQ0vRPEUCupS3N6EDCfk0779Gn9ARWSmZD+ncA2/rQ42 5+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736522654; x=1737127454; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OOepsUM1TiRNJGNg+5Q+9ESc+ok+SkXbqe3ywE+cOlg=; b=iS2AO8JdljBx5JdZIH8C8mQjjGyCQ09MRoWa4ilxGzkjqxLKRVXb7+6i5TyCSWsMJq aNyjqM73/6K2xqX/UtyO3hj0Gj3q0rm/p+TYjeDX7Y4bSeG0okWahxoMbA5BKw/mBuRc GftLOc4eDzyi2nqMcb3lV4MkvJCjLo6UpGhZn7fc9qdd6VIyJLwxOwED095XDRjEJ7ly t9vOdulyoK/g2Y6+Zs24xFpBV6o2xlQbvR17NIwkT5ZN6tc/NZy8kAAM60/WjaSI5hmC 78TY/istOacAtl0aVrvzzs9eU4mo5LDWkGsGCE/8VvU5l6oEWg54as07gsp0+Z+H8Cfu KTxQ== X-Gm-Message-State: AOJu0Yzsce6SIYwAtOhXt1gibTqT1c6OXn/BZ00/bKvKYGY3vVOcgjeI WUpVsnQsyDbxU2tBBXhkzB4ZNGS169iU+Yor77DL60VOtV2SZ+hk/zY6f2H2sQ== X-Gm-Gg: ASbGncu0nUmNdWNbOhjlKLR9R8jEU8dc7CkUrz+XC0tTV1127VDEpWW/GYpDmLI2bKs 9KolVvQcp3W/k5bLPfACFC2C31fxM0MKhM+xgJ3K5ZpBRVLbC9EjSNNlUqYsUIZhqx0tI+E3dDs ef1m0hvEKpr8o+59Ruu6yZzhGbW6p4xmJQzAPm8vzpxdGAfH/J/N6y1fWav2KQ0UkkPRYi78d4f RndUX1lYdp4NLJT8C6EhZIim/h/sZFjCfE6BIWBxfiZu64CHxZrcrEUyF/43bIPyJqtPRBkrjTP VloumdVmwoOmjXCKEfk1DPN4AA/lEmNSSe4bqQ== X-Google-Smtp-Source: AGHT+IHZ/TzUGQFpUp1yKd5u44JR82Ij0B4Jfyt4J9NNiAn9+VdbgFO7jdkTTZEHVLLTgHQul6l3+Q== X-Received: by 2002:a05:620a:40c2:b0:7b6:d089:2757 with SMTP id af79cd13be357-7bcd977ebb5mr1763421985a.35.1736522654406; Fri, 10 Jan 2025 07:24:14 -0800 (PST) Received: from localhost.localhost (pool-74-98-231-160.pitbpa.fios.verizon.net. [74.98.231.160]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce3237e25sm182089385a.10.2025.01.10.07.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 07:24:13 -0800 (PST) Date: Fri, 10 Jan 2025 15:24:11 +0000 From: Kaiyang Zhao To: "Zhijian Li (Fujitsu)" Cc: "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] mm/vmscan: Accumulate nr_demoted for accurate demotion statistics Message-ID: References: <20250110122133.423481-1-lizhijian@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4D9F31C0009 X-Stat-Signature: q354kwres57ufr4qemaa8wqocyuik6sp X-Rspam-User: X-HE-Tag: 1736522655-684871 X-HE-Meta: U2FsdGVkX1/XLuiKHrAEq1cUdn6pDA+hGN4hm5hBPVJ7R4dKGFze97EDwn4JYYExXqAzH0+5Q6mGDmZMbWxVGOj/SbJdXgcxpRfTKFuAdmItnk9fKr6vny57O0fdhDdSfFclIHRKumcBQ29qgPIC0bZKffCEfg21PledQpwT5eZKMrEovIwkOdZhj4Z0HtFPCpOI0lWyU/EwMwO0ujevexB6wTxVbPy2bqNx4bjzUwdCPi7/ggvTgwHsz//yWlEsg8jhX9JybKh61PcDiPHZPlc6x59s9A8R/Jr4NY7m8TvlPWd432DucnOXiszEegm9Od+5uze4A3lDgSh1F7gf5fZqxpGABGO9TtZzBCUWyl2dDTz7q/ZI5i9RGxgISue3vZV9rBwjWA8KD65EP2rkMq5kvBCeH2pPsj0fjWxGvzf4CC53zGvHIf6PVu/DkrQHohse78LuI7HH2A42GHCqZHg+mTW0QOD+YYYR5Z/zXw5UfN57XoZUD+ii+hbW5OwLr7NqC1R2TqQc6alJfLuR3TTuI2ayyAbfZHCM8rllSxzbe7sZVASf8soIuUqABhMbf6TPu7JF7i0C9AldczQmdijLBj+15Tg4oN3FgDJ9++LQqlp0DEUq/Pw+R7hKhyMEIOD+8l1nO5QrrfVN/v/FyOBlx8qeg9yHNN0T2Zeo9cRXcW+7hocsKkoOPsol7Dvcqq1l5NdcVYn8GyIlGsBnE9P22vjBTiqkQ0Gf+8wtiWm9Ou666krHtDCwkfYwe99hQK4Bt95embfQMxBbCOeJzncaJMWgVNmUPPrI3Vp0ZNhiW/VHRRu2urGyyX7Vtqe/Nd1wOAdE1sb6vXfQ8EP+o+As+GOmQQb8sattSgyp4JNBze8U+ico11wn9QgliSysCQR/bDA6wVODWFsfxq/1XwbVvvzYL8o9kdIgtK6UUypXPZeL5JHT6q1+zCbjev42cpw72BPk93pidg5GkRm V+XbHfYx cL084iJF0H2mSgYMgDgxZUY3/sGF9E5a8ugXFl/+lxUnUBI34EijYACz7tSmgWWMEeCz1OwCu+pRDmsHl4mxHJG168Qu/MhuV+S7E+dAttvrzzJygKsUQsOxS5ns/vNo+2/7Pjl7fTxDufVYRqwUSrp3TzR12DpTdWxmBdhwlJFfXpHrvBwpLCq111H3VWBlhR8GIgvsdLzbyMbi+638aQKdrp8oMSt9i8WR/ZJ/y0PbeYg+tRdcLDk2EfiHQF3T6Rw94ARXMCriie3m1r/TlWKUbja+0GqquWtMtjcyQIJueVeWlmEsxLdeilsYFvrYfXDbiDYtPvHkqfRMyFsSsAVWQdA5ph2iY95Rn/OiPHTBp3XnPlzrz8WJoWYKSjgcwKG35QTX3TNbDnsajVNXuKLZpclI4n4TBy4k4vmmyRz0CVKdvW/53xYu0DjXKVbi3vSEGuUqny0GEL/y0eOYPkHuqBlwMMFgXI/C5U1czPKQk9AjwYUer7E5/hoCgnmmOmwUf/eDYT/VNMuo9TfpMVRcdJvmaDVq22/gz X-Bogosity: Ham, tests=bogofilter, spamicity=0.314073, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Well... I know what was going on, the second pass will override stat-＞nr_demoted to be *zero* that makes the first try stat-＞nr_demoted got lost. Ah you are right. This is a bug when demotion partially succeeds in the first pass. Thanks for catching it. Acked-by: Kaiyang Zhao